From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6842309179660566528 X-Received: by 2002:a1c:48d:: with SMTP id 135mr1971807wme.102.1593155865101; Fri, 26 Jun 2020 00:17:45 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:9687:: with SMTP id y129ls3908044wmd.2.canary-gmail; Fri, 26 Jun 2020 00:17:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmhoRFNkqZaV27UQ23q1iBQhsljd39niEYH3IGDS4eq/G9N8E67CvCdSzQLFPtiT949RZ1 X-Received: by 2002:a1c:6354:: with SMTP id x81mr1840287wmb.98.1593155864363; Fri, 26 Jun 2020 00:17:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593155864; cv=none; d=google.com; s=arc-20160816; b=XPd3sLM/Zi9YSeGx452EguSDJNLPSamZ8Zsz8cDg+K+pRqf2deMTJNySP7AcK+3yNx obnS1q6YBkYefU+z2fzpvcb+kjYRGcFpCmk+QqEDEoQ3CDhh4o4O4DJxZGqVY3IXKkQW uQhhVvbI8fiQ1w9DPoYcMxQPQopuW1GOycwfSRCJopXnIhRGCwcRB/EAYmMLmYth78NS UJAH/f3LsOmWZ8nFv1L0xvl4x1s2O9grfYDtvjtwJQ13mRH+mGFM8Yk3vFZ605OH3LsH cel0NgC21MCrnIdPo7KYjPMzoipDO+3p4YFzCzX25sUyWyse1gdXZ3IZ8Vfoha4dinYV 0ZJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:mime-version:user-agent:date:message-id:organization :autocrypt:from:references:cc:to:subject; bh=bY1rUSc+j9rs2o62w8uD7oS6Ij3Ov2ov1+CeItpkChY=; b=X7eY6GHX6GgYgt0z0cUUyML5rfWvdkRhqFyFzrssSwaaqnLkuk31qBOi43RzmC0ede 2pDzS91ffPbulMk3mYUud0lyHnY9gmagd0jYJG1QGlAdSmjoZMb0/43IUSyDsfosRACr PY75rfTBZxAWpwIJEBXR6xGVPq8idg0WFCJMTsc+EXNqa6I2M9J8B0Oit9EniywBDM9U yJJAoQotpKkkrmn5BFzM+Gu87nOCcD2xk/oDHAws4HVbTAjAzSxpEviLz8t/9/YVk3VB e5JTBrkrByXo9HuUdYC4diTARcIZdj6K8EnIMozdomZ5om/y/sI4/7e7S0RXtn1uaanD Skmw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.10 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.10]) by gmr-mx.google.com with ESMTPS id y6si23935wrh.5.2020.06.26.00.17.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Jun 2020 00:17:44 -0700 (PDT) Received-SPF: neutral (google.com: 212.18.0.10 is neither permitted nor denied by best guess record for domain of ch@denx.de) client-ip=212.18.0.10; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.10 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 49tSrm0SH8z1rx8y; Fri, 26 Jun 2020 09:17:44 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 49tSrm061sz1qqkt; Fri, 26 Jun 2020 09:17:44 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id ta5njaQygg_D; Fri, 26 Jun 2020 09:17:42 +0200 (CEST) X-Auth-Info: PO7U+DIEflQjNLS9cn08TNUkwC3sMyKuYheirfcjtqs= Received: from [10.88.0.186] (dslb-090-186-059-007.090.186.pools.vodafone-ip.de [90.186.59.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 26 Jun 2020 09:17:41 +0200 (CEST) Subject: Re: [PATCH] image: Run copy_boot_files after rootfs postprocessing To: Harald Seiler , Jan Kiszka , Henning Schild Cc: isar-users@googlegroups.com References: <20200625153351.3402179-1-hws@denx.de> <20200625184822.236ff069@md1za8fc.ad001.siemens.net> <91ce92c15d267e4836ab4d9de2870bc8e6f6dfa1.camel@denx.de> From: Claudius Heine Autocrypt: addr=ch@denx.de; keydata= mQINBFSuWugBEADI18RqDRNsXrWtQBuI60knLMfJ6j26C4ArB5ht4TzTQg9PfTJf1BwKUMYH 1s5qKikAX1mAFm7ca4uxc8uY1AdTFKepNp6ewcRShWPFo1+7DJcTlS1O+cIUyOeo6yrMMI2D DeILzcird0ATI+v7QzO1TmAmEGB28kp9KozZqFKS28p6/GLJ8qCYo50MpacsB0oi8pUeU6+8 KUlKfDDNZvwM+7rVlshOdp0iuAe12IH4gePkXycTm/PvCdqpvm6Uc0FryYh2AzB78Zvzpysb VTdGzFYavdLJJjNifj1XKgeRayR1UG0dMpcUwzLxqRmeRN1Ca7/NVT/NUHm8r80ta6mvjDHj 0vHWfn0CFgfikRtB4tftWmsvYs8YtDtR7X4gaYk5CHhR9iAGU2zElYp2Q417oe1FuXn0eFxG 1SzENtFdUZv64oQSOblJ9ZKslXLBlwCLacSdNK499IEs03UAaTPgh5L/t8G81FDeXduFt129 h6UY6Si2xDYE9wZ90XGag7Uv0wC2LKyOWzEgeOJDIGjQVAMlcr5i6nNa30n/qMTWSf+jahLa 7cr8Mgzw0W9lSAX1CytJJjh5hTHF/atZkl6+vInHJLTtBA2leRF7og2H6PHfUmpJ/A46x71l rODfqjq4/ZblSgqgQCU3rXq8bPwnl7zo/dlyqYUPVAJQ79m9jwARAQABtBtDbGF1ZGl1cyBI ZWluZSA8Y2hAZGVueC5kZT6JAlUEEwEKAD8CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheA FiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAl4pTU4FCQtcJeYACgkQEXPLGZgIsVM+ow//beDC TngJxFrJIgYqHKe93kMBUNjeY9X96nYxELg2dtQQXVeMx+CWsZymP4B9UVXQLGti9ZStKuOB HHlxfVGttwdNeQ1BjjeO9TNJNS0T1jSfz+j/lmSuoCGveojONse2/MOwMNRHtfrkws0JoM1L X3oZkv5JGXDQ51ZVIKXe2+aqIu7oouYpGsDYhxyP2tMhS3J/BHjFDjtQu1H/w64Hq28oa2aY 44prBgz0eCS8V88nlbFPc8K0nZNQYxb0bFcm4VuEHqpSHwbr6Gll9zXVpiOUddv/kbghsz3l u1/7k5Va5ZtRMumhnids5ttmrOIEib+GjpukWGUgZaukF0SNHxhHoAiyklgjEAPMJXYUZjw6 PEUMY+ocYMOgU7uZVLu8rWyCztE0/MW/JawfX/jPAUSRWluA8mP6UNkJDQmuquoaDAv1cQCH h8te/W+Rqa5xYCJCx5B4jEa8Kxmdq6kaWxU2/RXLAHypssiO5Y1XRhDImSjG2SEwJ3nzVpP5 Rd0lDhuoz+UnyidB5Np0tAvQ/4dq4XXxg7/dze0isi58GDtUxMDvtbOnmH2Y/AwxWiM4bC2B gq3JOuG4zAhWFbTG8WHirsvvkzdNXwCyepcR+2jzj1v80k3YqZOYE05POhr0dqeGPFAJJdxl TzwsLPp1z+fsE2nr9jAGd/rLNQ0YCzC5Ag0EVK5a6AEQANbSW8FeAXDMaL26JYiaWriOCB4g zqSIGXPjy1pdtS3dghks2WvADdoUuXBE6ZdbEGl+3QUlXhv167iY1M48oOVCmBnp/ENt1D9s mYB8lby4bVfb5e6eP4VivRUKiU1S2Yvp3en6/Bnts8q6clDezcbWu8lOjzlZEgXbcUPM77r3 3knriTtjnGEGc4Blta/1ED6U00NjqZ3mxpyVT1dmafmMt2Onh6XsYUgCuuAFOkhg0hUB3ems 7NPawURj6PYDYxnbpt/qTJiKbWM6CCkPDHrHesoY/ONvCeGaxzIytaUwXJ/mi3ws36hJXSST Nfyo2W5SskPJvGyn06KXr9YMW9IyZ4AV1pIs2iJ6T1rUXlXpxZ63BMY8Ja8r58Zg5+0cOaBr IAtMCo2aPsfChHEBc3m7XBCfM8yNtvzex8SCVLa/pOVXbKmXKbseInpdtP+3EM1p3R/PjBvK bvsyesk90F6+zsyVu46JVCyqrN3RGGyZCdicFHIPfqzUAnuFIOlUYSDwqvJXMwT5XcZ1jvNR eUvYwqpIJJYumoL3V5SFu434Wu81vMLeFPEccgLW4tbqpckBdbwP8GaPVmgnCWsQhcO9KUDE bnL4nO4lNPgz94dmb579BLsoAH5VVNQONyBEBxeiQBsK3DebwCmQha3qunRc4VUJQlZm/if4 lBdkNMavABEBAAGJAjwEGAEKACYCGwwWIQRv8uWfAMa8KDHYZMERc8sZmAixUwUCXilOFQUJ C1wmrQAKCRARc8sZmAixUyC7EACZIIclsnQc9gLSLxDwBMdEIXmTOEy0tuqJ5MPLNkULH6Sz nPtNBufvkhkKgt56pxTUrxS3ARahLb6AGn8Pl0B2DDtc8SE/L16LCXElssz4VpZ51udKHDzk ijPuaeCevQdTU2Rqdvx26XZre7kQBTXGgvlJAMJlJp0SMfsQ8QdhIHtGLtQmRAzSy6cHNeHX 3HDC7jxrJlJYsmwxbViagYVd9g1D7OE3dCfv9AWqclzbCMLxL0K5QCLLpqiI89dCNKzYyL4F +Cnt98PDa5GG+VXeMB6X6nfWApR20mC1pZP7Tb3XJrEtVkDONejUgQMj9Ao1cPWndma3LAtO aWcenPIPjYQ5Ab38rlE9hEHBfWSC7NriRvCEID7jDmcNG+4j5shKexz7KBoM+Kdr1WjUb3h5 TemrZycE3JGQ4GK46FwRp2O6F4mnrmNdVpnFRT+ilwZ5HOhxKqi8MslDlWmfu6m15JZSvv48 sBWpuXSbJlAKtJkuHVf45gejesDEqG89wE3xGuEnoMsn3+1rpcdLlsXtGuY8fXV4nlPw6Y8e iMuaOyn8qWvxczORDrWk1ZfRlUyV64LDDnbosHoxGLxZ1hf7V6VBtwPqngij2rsMTnCOD11y 3V3xxZAIv7Im43MsUbhZe2andR4UCQFE6NKWG5yHZtCC51APbLwM4ryINad1LA== Organization: Denx Software Engineering Message-ID: Date: Fri, 26 Jun 2020 09:17:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <91ce92c15d267e4836ab4d9de2870bc8e6f6dfa1.camel@denx.de> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DCFrEAzLj3MmljOdaRHbzze6uwrgr2seZ" X-TUID: gylSnaoL35TL This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DCFrEAzLj3MmljOdaRHbzze6uwrgr2seZ Content-Type: multipart/mixed; boundary="DG1Mu7ToERQuWr0I8On3cHb6eCnD6JvK4" --DG1Mu7ToERQuWr0I8On3cHb6eCnD6JvK4 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Harald, On 2020-06-25 19:24, Harald Seiler wrote: > Hello Henning, >=20 > On Thu, 2020-06-25 at 19:02 +0200, Jan Kiszka wrote: >> On 25.06.20 18:48, [ext] Henning Schild wrote: >>> Hi Harald, >>> >>> can you elaborate on those cases? The postprocessing is hacky, if the= >>> problem is coming from your layer you should probably keep this patch= >>> in you layer. >> >> Basically do_generate_image_uuid from=20 >> https://lore.kernel.org/cip-dev/20200625141015.31719-4-Quirin.Gylstorf= f@siemens.com/T/#u,=20 >> just modeled as post-processing hook, rather than a task. >=20 > For reference, this is the exact code: >=20 > ROOTFS_POSTPROCESS_COMMAND =3D+ "image_postprocess_generate_uuid" > image_postprocess_generate_uuid() { > sudo sed -i '/^IMAGE_UUID=3D.*/d' '${IMAGE_ROOTFS}/etc/os-relea= se' > echo "IMAGE_UUID=3D\"${IMAGE_UUID}\"" | \ > sudo tee -a '${IMAGE_ROOTFS}/etc/os-release' >=20 > sudo -E chroot '${ROOTFSDIR}' \ > update-initramfs -u > } >=20 >> Jan >> >>> Maybe you can point out an issue in isar itself, or explain how you g= ot >>> into this situation? We can then see if your change is generic enough= >>> for upstream. You could also provide the error-case from your layer a= s >>> an upstream feature, if that is generic enough. >=20 > I think this patch addresses an issue in isar itself. There is no reas= on > for copy_boot_files() to run before the postprocessing does. I've chec= ked > through the git history and the reason this relationship was introduced= > was a bigger refactor of the task dependency chain. It does not seem t= o > be intentionally this way from what I can tell. >=20 > The other way around makes more sense, in my opinion. As stated in the= > commit message, postprocessing might do an update to the initramfs (as > seen above) and this change needs to be reflected in the deployed > initramfs as well, instead of silently only living in the version that = is > part of the rootfs. >=20 > I also checked all existing postprocessing commands and did not see any= > that assume to be run after the boot files have been deployed. Its been a while when I implemented this, but I also thought of the scenario where someone would like to 'minimize' a image via the root fs postprocessing by deleting everything that is not needed, and that could possible include the kernel + initramfs, if those are stored somewhere else outside the root file system. So the idea was, IIRC, to move the kernel and initrd to the deploy dir, out of harms way, before postprocessing does its rootfs manipulation. So by ordering the copy_boot_files behind the root fs post processing, you might break other layers that rely on this ordering and have such 'minimization' procedures, that remove the kernel package and specific files. We don't have such 'minimization' stuff in upstream isar, since it pretty much breaks apt and dpkg, but if you do image based update, you might not care. regards, Claudius --DG1Mu7ToERQuWr0I8On3cHb6eCnD6JvK4-- --DCFrEAzLj3MmljOdaRHbzze6uwrgr2seZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAl71oQ8ACgkQEXPLGZgI sVNuSQ/8DZGlxhYTeCClSLGE0a7wcBYmP3kUuoKtEIljvk5noAYEtGOmYm6TtiI6 Q3NaTHDQOMWZvc9MsNLZTSeF/VEGa4gBnqYVaxhNcM6fYAfj97VDTGCZzTriJDpz GZNvpVztrZDI86Z1URqOMqBAOH19uEWAlAO1nzoKt8v8Er6SimZpLZ0ZgZ6L1kTp QTwpgjWaSRGVxXxV8FGRjYe/WhGYlHSwVn+Y4N3t7cns1QLL0RG1+WGqNBx+hzVW CnMwiahMdjU2XeDJTRY1vWx0G5rDsEFJUoBnuOPKzyaM0DlD05AHbeyoZTu64bTO 3/+bdb+AjAs81FCour91VrA9iHnTxzEes8GbDdD1i658qekl5xWz3eiduK5rif4h f0FfvO+EdQdvB3ByiOvN8wkniQHxKfzuXM219oduIQkyJRsbBkdCRqNdj6bDs48i wjbr8BDcy3WtILERx0kfntDgiRAYi7Ca1gURvXUOdGJinba5Fm28ks9krUMTqsbv ZEFAP+tv8JOvSHqu1VuqfdXySd5nY3E9LBaOB5CjycK1IHYWetvkNkTCiPisz6sa ufLevc6dzjNxjzwtCryfYu21aZFvn12UzZ1qg4Sgx/1h4sWndlHiZDPy5DUw2Er3 lhg99Lt0QzfGX75dJqkvoOmIF2ZHVuqL3Qw5mtNA/YtFr/Qsxag= =tMLS -----END PGP SIGNATURE----- --DCFrEAzLj3MmljOdaRHbzze6uwrgr2seZ--