[PATCH] meta: Add Debian package conflicts in debianize class

[PATCH] meta: Add Debian package conflicts in debianize class

[Schilling, Benjamin]

[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]

Before it was not possible to specify conflicting packages in recipes
using the debianize class.
Now the conflicting packages can be defined using the DEBIAN_CONFLICTS
variable in the recipe. This is especially useful in dpkg-raw recipes
that should conflict with each other.

Signed-off-by: Benjamin Schilling <schilling.benjamin@siemens.com>
---
meta/classes/debianize.bbclass | 3 +++
1 file changed, 3 insertions(+)

diff --git a/meta/classes/debianize.bbclass b/meta/classes/debianize.bbclass
index dad1cb4..4486778 100644
--- a/meta/classes/debianize.bbclass
+++ b/meta/classes/debianize.bbclass
@@ -1,5 +1,6 @@
# This software is a part of ISAR.
# Copyright (C) 2017-2019 Siemens AG
+# Copyright (C) 2021 Siemens Mobility GmbH
#
# SPDX-License-Identifier: MIT
@@ -7,6 +8,7 @@ CHANGELOG_V ??= "${PV}"
DPKG_ARCH ??= "any"
DEBIAN_BUILD_DEPENDS ??= ""
DEBIAN_DEPENDS ??= ""
+DEBIAN_CONFLICTS ??= ""
DESCRIPTION ??= "must not be empty"
MAINTAINER ??= "Unknown maintainer unknown@example.com<mailto:unknown@example.com>"
@@ -63,6 +65,7 @@ Build-Depends: debhelper (>= ${compat}), ${DEBIAN_BUILD_DEPENDS}
Package: ${PN}
Architecture: ${DPKG_ARCH}
Depends: ${DEBIAN_DEPENDS}
+Conflicts: ${DEBIAN_CONFLICTS}
Description: ${DESCRIPTION}
EOF
}
--
2.20.1


[-- Attachment #2: Type: text/html, Size: 5329 bytes --]

Re: [PATCH] meta: Add Debian package conflicts in debianize class

[Henning Schild]

Am Tue, 27 Jul 2021 15:54:12 +0200
schrieb "Schilling, Benjamin (SMO RI R&D SYS SEC)"
<schilling.benjamin@siemens.com>:

> Before it was not possible to specify conflicting packages in recipes
> 
> using the debianize class.
> 
> Now the conflicting packages can be defined using the DEBIAN_CONFLICTS
> 
> variable in the recipe. This is especially useful in dpkg-raw recipes
> 
> that should conflict with each other.

Having an all-mighty debianize class will be impossible. But others
have extended what we have and your use-case seems valid.
So i would say this is a questionable but overall good idea.

But this mail seems too "html" to actually apply that patch. A patch
that otherwise looks fine.

Henning

>  
> 
> Signed-off-by: Benjamin Schilling <schilling.benjamin@siemens.com>
> 
> ---
> 
> meta/classes/debianize.bbclass | 3 +++
> 
> 1 file changed, 3 insertions(+)
> 
>  
> 
> diff --git a/meta/classes/debianize.bbclass
> b/meta/classes/debianize.bbclass
> 
> index dad1cb4..4486778 100644
> 
> --- a/meta/classes/debianize.bbclass
> 
> +++ b/meta/classes/debianize.bbclass
> 
> @@ -1,5 +1,6 @@
> 
> # This software is a part of ISAR.
> 
> # Copyright (C) 2017-2019 Siemens AG
> 
> +# Copyright (C) 2021 Siemens Mobility GmbH
> 
> #
> 
> # SPDX-License-Identifier: MIT
> 
> @@ -7,6 +8,7 @@ CHANGELOG_V ??= "${PV}"
> 
> DPKG_ARCH ??= "any"
> 
> DEBIAN_BUILD_DEPENDS ??= ""
> 
> DEBIAN_DEPENDS ??= ""
> 
> +DEBIAN_CONFLICTS ??= ""
> 
> DESCRIPTION ??= "must not be empty"
> 
> MAINTAINER ??= "Unknown maintainer unknown@example.com"
> 
> @@ -63,6 +65,7 @@ Build-Depends: debhelper (>= ${compat}),
> ${DEBIAN_BUILD_DEPENDS}
> 
> Package: ${PN}
> 
> Architecture: ${DPKG_ARCH}
> 
> Depends: ${DEBIAN_DEPENDS}
> 
> +Conflicts: ${DEBIAN_CONFLICTS}
> 
> Description: ${DESCRIPTION}
> 
> EOF
> 
> }
> 
> --
> 
> 2.20.1
> 
>  
> 

Re: [PATCH] meta: Add Debian package conflicts in debianize class

[Anton Mikanovich]

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

27.07.2021 16:54, Schilling, Benjamin wrote:
>
> Before it was not possible to specify conflicting packages in recipes
>
> using the debianize class.
>
> Now the conflicting packages can be defined using the DEBIAN_CONFLICTS
>
> variable in the recipe. This is especially useful in dpkg-raw recipes
>
> that should conflict with each other.
>
> Signed-off-by: Benjamin Schilling <schilling.benjamin@siemens.com>
>
Applied to next, thanks.
Please send patches in plain text next time.

-- 
Anton Mikanovich
Promwad Ltd.
External service provider of ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn, Germany
+49 (89) 122 67 24-0
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov


[-- Attachment #2: Type: text/html, Size: 2631 bytes --]