From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6724322178273116160 X-Received: by 2002:a5d:4703:: with SMTP id y3mr39365414wrq.63.1565792241018; Wed, 14 Aug 2019 07:17:21 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:4982:: with SMTP id r2ls645386wrq.15.gmail; Wed, 14 Aug 2019 07:17:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqzJrqZKl3WHBg59bgJHnqwyRta/b/ptUPM7FDWTRc9nGb2TDVbKwZoLnHaWEvF7sKUoqFca X-Received: by 2002:adf:f206:: with SMTP id p6mr55085413wro.216.1565792240211; Wed, 14 Aug 2019 07:17:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565792240; cv=none; d=google.com; s=arc-20160816; b=p+3i922eKDMaNjFjvJ8vy2i4X/XN3m1nfA8MDrABLYaXekzB/CetZ5yyrBTrUMYTHl bVr/6KdQd5Rx7y/cP3mNlrN/CNcJMz/Yf3ug7LmqAyWMWMlm1yLbWrJydwYON38G/wCQ PUd3/+TDfbPo/Le0x7oY++6mXKt5IY5Oxbiq/eHsDYj5C+BA0/crx11Zus03n5LKFVbW lOBQT4RCSrVvD0E18OSiMytYBCECdnZYiP0syqteDx5c4+VM9clJGswZtD7vn3zcs9s0 QZjxYnPr9bAX8viGyDLz/BugfatKNgN3ykOy1+6ffuW+Aoq3WLqyi41DjOIAfPCqeuFs 7xTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=i12v6o2xdPX5Bvi4Y5KKa+QtT5dCNlXG8UHtOrj510k=; b=qmZbIfGUiygC66+AfXA2HGycNuKjLBri4fUvJiJOgW01PbDqe+kFezzKgZasHyE3zq wRDEg6vPfanANC82KvsXFJiLxvQBmIsj6lVYPhLhEjmK5ZQnmG5FUNKk1rvQuz3MwFFj N4+aHHZpafPG9yN65fBK4kYWgEUxtvQwJwsGR1LzMrfZpJvDA+Qv/tMEfPAyHzkBdThi FFW92HP/ybfXId7oSunLIgTLVjgQ8cOGkSOeEdgGxyPvUhC+FuDU1JnFAPGJhBHanJgM uDR+/n6ddOei3VitNh+fwdaCB6/DgpsSQhqQW07Kt5DkpXFJYKu5XQyDZ1mVkN3i0FeS FQDg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id w17si226368wmk.1.2019.08.14.07.17.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Aug 2019 07:17:20 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x7EEHJQT025483 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Aug 2019 16:17:19 +0200 Received: from [139.23.113.48] ([139.23.113.48]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x7EEHIGU004274; Wed, 14 Aug 2019 16:17:19 +0200 Subject: Re: [PATCH v2] Set STAMPCLEAN variable To: Claudius Heine , isar-users References: <52fdf0b1-a06e-aaed-fd69-da515ebf0ec4@siemens.com> From: Jan Kiszka Message-ID: Date: Wed, 14 Aug 2019 16:17:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: F9zr+pXnChE2 On 14.08.19 16:10, Claudius Heine wrote: > Hi Jan, > > you probably mean v3. Yes, sorry. > > On 14/08/2019 14.39, Jan Kiszka wrote: >> This ensures that stamp files are cleaned when a task is rebuilt. Not >> providing this pattern likely caused a lot of failures when doing >> partial rebuilds. >> >> As we are at it, switch do_clean to STAMPCLEAN as well. >> >> Signed-off-by: Jan Kiszka >> --- >> meta/classes/base.bbclass | 4 ++-- >> meta/conf/bitbake.conf | 1 + >> 2 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass >> index ca80bf8..b6638ca 100644 >> --- a/meta/classes/base.bbclass >> +++ b/meta/classes/base.bbclass >> @@ -206,8 +206,8 @@ python do_clean() { >> workdir = d.expand("${WORKDIR}") >> subprocess.check_call(["sudo", "rm", "-rf", workdir]) >> >> - stamppath = bb.data.expand(d.getVar('STAMP', False), d) >> - stampdirs = glob.glob(stamppath + ".*") >> + stampclean = bb.data.expand(d.getVar('STAMPCLEAN', False), d) >> + stampdirs = glob.glob(stampclean) >> subprocess.check_call(["sudo", "rm", "-rf"] + stampdirs) >> } >> >> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf >> index 3d18223..ee86ee0 100644 >> --- a/meta/conf/bitbake.conf >> +++ b/meta/conf/bitbake.conf >> @@ -36,6 +36,7 @@ S = "${WORKDIR}/${P}" >> AUTOREV = "${@bb.fetch2.get_autorev(d)}" >> SRC_URI = "file://${FILE}" >> STAMP = "${TMPDIR}/stamps/${PF}" >> +STAMPCLEAN = "${TMPDIR}/stamps/${PN}-*" > > What I did come across when looking at the commit messages of OE was, > that they used to have all stamps in just one directory. They changed > that, because they and problems when a recipe name 'recipe-1.2.3' > removing stamps from a recipe named 'recipe-name-4.5.6'. > > Maybe we should really copy what current OE upstream does. > > Like this: > > STAMPS_DIR ?= "${TMPDIR}/stamps" > STAMP = "${STAMPS_DIR}/${PN}/${PV}-${PR}" > STAMPCLEAN = "${STAMPS_DIR}/${PN}/*-*" I agree that aligning makes sense, but let's to that on top. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux