From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6741467829768290304 X-Received: by 2002:a1c:3904:: with SMTP id g4mr16611707wma.116.1569826920947; Mon, 30 Sep 2019 00:02:00 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:99d7:: with SMTP id b206ls2247161wme.2.canary-gmail; Mon, 30 Sep 2019 00:02:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqzw5C2jw7NTms2eSB+P73rid2UIolalKKsFKDytdLjt9mq2blcd+xMPVZqFgfX1y7qkOr2i X-Received: by 2002:a1c:c189:: with SMTP id r131mr16337990wmf.153.1569826920402; Mon, 30 Sep 2019 00:02:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569826920; cv=none; d=google.com; s=arc-20160816; b=0ZhvKxb8E9HKS7wEA0dbEThn35uQ4QTr9R3IhrvF0f5B5qRh4xKZA1jmaduDucs0cL IQ7Xz6htxN3ykBTmh08d2wlhY8y1VFNRT4MwQ9l17j9ztfjXKiJKcqF92kwEK2qR0y58 HRUbk8NeZVu/xM45da8WpuIgcRkPfPk6TIejbfSdB0YsxxVuDzGTJEqkA5d/WTSYQTA5 uT4+bgigCdF0rC5zNx0TmKq2nTZK3lfr55igm1BzRxqmyp+L0n+H5eeBSHwPlSd/k6Ps LkDqNZZ2ECanc7JaB86pyX6o7/35VINKyH2rMDKawGodVCzBIijEtpaYnKPEbV78ZxRv rEHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=IcLXmNCRaNHd+I67P/xWPn1VoS4hJ3JJHNk7N29X/Fc=; b=nVTGKjuj1m+16T5xvAgUs2tYmnf8C+gkbKzBr2eodQtKd/OTnaA8UNCsLVmZKwAvOw rbftnIKbP8SFoyZvngBh1vE4PWThTBCVxfRGwptIklTdG4co0+u7acvf9dujXxvdY9z2 1xyiWYUh+u4DT1Xz3iiugXdvJBw6r08Kk+RpgRYDVbT7DOR/rdL8vFWtzdAGlELfmiN6 JW7lI788mdbSGOIJFzfYG7rnm5US1gjV78f0mWxuR9G6mL8WXHoXEM0ilJrP8m4W03k+ rNqzKS8HGSSDes5D9FF2jGdy+NrAEMVBU78HJzxYPF75T1Vca/Y0eBHNiix2QyNYqRvE 9ucg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id i21si1305517wml.4.2019.09.30.00.02.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Sep 2019 00:02:00 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x8U71xDk010826 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 30 Sep 2019 09:01:59 +0200 Received: from [167.87.40.9] ([167.87.40.9]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x8U71wkh019600; Mon, 30 Sep 2019 09:01:58 +0200 Subject: Re: [PATCH v2] isar-init-build-env: Always set ISARROOT To: Vijai Kumar K Cc: isar-users@googlegroups.com, henning.schild@siemens.com, claudius.heine.ext@siemens.com References: <20190927213804.31651-1-Vijaikumar_Kangarajan@mentor.com> <20190927214352.32114-1-Vijaikumar_Kangarajan@mentor.com> <20190930064655.GA10223@lightning> From: Jan Kiszka Message-ID: Date: Mon, 30 Sep 2019 09:01:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190930064655.GA10223@lightning> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: NhQp2NkHhux1 On 30.09.19 08:46, Vijai Kumar K wrote: > On Mon, Sep 30, 2019 at 08:06:14AM +0200, Jan Kiszka wrote: >> On 27.09.19 23:43, vijaikumar.kanagarajan@gmail.com wrote: >>> From: Vijai Kumar K >>> >>> When switching between two ISAR workspaces in the same shell >>> session, the ISARROOT setting of the previous workspace would be >>> picked up for the new workspace resulting in an incorrect >>> configuration. >>> >>> Always set ISARROOT irrespective of whether it is empty or not. >>> >>> Signed-off-by: Vijai Kumar K >>> --- >>> Changes in v2: >>> - Remove redundant code >>> >>> isar-init-build-env | 7 ++----- >>> 1 file changed, 2 insertions(+), 5 deletions(-) >>> >>> diff --git a/isar-init-build-env b/isar-init-build-env >>> index b08bb59..404efcb 100755 >>> --- a/isar-init-build-env >>> +++ b/isar-init-build-env >>> @@ -42,13 +42,10 @@ if [ -z "$ZSH_NAME" ] && [ "$0" = "$THIS_SCRIPT" ]; then >>> exit 1 >>> fi >>> -if [ -z "$ISARROOT" ]; then >>> - ISARROOT=$(dirname "$THIS_SCRIPT") >>> - ISARROOT=$(readlink -f "$ISARROOT") >>> -fi >>> +ISARROOT=$(dirname "$THIS_SCRIPT") >>> +ISARROOT=$(readlink -f "$ISARROOT") >>> unset THIS_SCRIPT >>> -ISARROOT=$(readlink -f "$ISARROOT") >>> export ISARROOT >>> . "$ISARROOT/scripts/isar-buildenv-internal" "$1" && \ >>> TEMPLATECONF="$TEMPLATECONF" "$ISARROOT/scripts/isar-setup-builddir" || { >>> >> >> OE is doing the same, i.e. does not update OEROOT on second execution. This >> allows to set OEROOT prior to calling the script (https://github.com/openembedded/openembedded-core/commit/3327e2a9222004d8ac7974cb1d9fe77c81176cfc). > > Yes. But then OE also unsets OEROOT later in that script. > > But with our below change we are no longer doing the same. > https://github.com/ilbers/isar/commit/b59cf9ef8aae682937e8a4a5cda1c6d080d329b7 > But this is not changing the fact that we can current take ISARROOT from the caller's environment. If we remove that, in deviation from OE, it should be a clear decision. And it should be stated somewhere. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux