From: Claudius Heine <claudius.heine.ext@siemens.com>
To: "[ext] Jan Kiszka" <jan.kiszka@siemens.com>,
isar-users <isar-users@googlegroups.com>,
Claudius Heine <ch@denx.de>
Subject: Re: isar-bootstrap fails to rebuild after config changes
Date: Tue, 13 Aug 2019 10:01:22 +0200 [thread overview]
Message-ID: <a30b2f4d-09df-6df0-6832-de005e00e8e1@siemens.com> (raw)
In-Reply-To: <fa96e417-2516-177d-e58b-192dd42bb927@siemens.com>
Hi Jan,
On 12/08/2019 19.18, [ext] Jan Kiszka wrote:
> Hi,
>
> I noticed today that I'm not getting a new bootstrap rootfs after adding
> a repo to DISTRO_APT_SOURCES. Digging deeper, this revealed missing
> STAMPCLEAN setting, but also more:
>
> Why are we probing for the existence of the DEPLOY_ISAR_BOOTSTRAP link
> in do_apt_config_prepare(), Claudius? This obviously exists after a
> first run, and that blocks refreshing all the apt settings if they have
> changed.
I do not know. That was added by a patch of Maxim
(ab0a1c8c357a18ddd67fe4c0efc66a296d93dae2), maybe he knows.
isar-bootstrap: Eliminate multiple debootstraps for the same
distro/host
After applying this patch only single debootstrap for
particular platform is created and pointed by corresponding
link under DEPLOY_DIR_IMAGE.
For proper locking of parallel builds shell tasks
apt_config_install, set_locale, setup_chroot, apt_update
and deploy were collapsed to common debootstrap helper.
Due to problems in bitbake with shell functions expansion
under quotes these functions were substituted by their
bodies.
Signed-off-by: Maxim Yu. Osipov <mosipov@ilbers.de>
That is by the way a pretty big patch. Also parts of it could probably
be reverted, since the 'problems in bitbake with shell functions
expansion under quotes' are resolved in the current version by removing
these quotes IIUC.
> There is CLEANFUNCS set with clean_deploy(), but that is only run on
> true do_clean(), not on rebuilds.
Right.
>
> And finally, when I look at isar_bootstrap(), run by do_bootstrap(), it
> protects checking and creating DEPLOY_ISAR_BOOTSTRAP with a lock. But
> do_apt_config_prepare() runs lockless. This cannot work reliably.
When I initially wrote isar-bootstrap, it didn't contain any looks. IIRC
the locks where added when I wasn't active with isar and I haven't yet
looked into why exactly they are needed and what they protect against
etc. So you know probably more about them than me.
regards,
Claudius
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
next prev parent reply other threads:[~2019-08-13 8:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 17:18 Jan Kiszka
2019-08-13 8:01 ` Claudius Heine [this message]
2019-08-13 8:14 ` Jan Kiszka
2019-08-20 19:33 ` Jan Kiszka
2019-08-21 9:02 ` Baurzhan Ismagulov
2019-08-21 9:06 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a30b2f4d-09df-6df0-6832-de005e00e8e1@siemens.com \
--to=claudius.heine.ext@siemens.com \
--cc=ch@denx.de \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox