From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6724331065971834880 X-Received: by 2002:a2e:9117:: with SMTP id m23mr21222168ljg.134.1565683284075; Tue, 13 Aug 2019 01:01:24 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:b4ef:: with SMTP id s15ls645456ljm.14.gmail; Tue, 13 Aug 2019 01:01:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqwtjP2FcO5gSDQqonmLWilR5RO5pPZ8D8fB4gS6iWtKfmDDvbzQIlOWVpShx1rvKnFG7r3B X-Received: by 2002:a2e:3e18:: with SMTP id l24mr6237727lja.67.1565683283580; Tue, 13 Aug 2019 01:01:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565683283; cv=none; d=google.com; s=arc-20160816; b=KYMQQKeHdZ1ZyWb6WFJIPiONqHf/v7K0crlKxFStxkrqQallMrmjLaiOhELpZK8Knk d0IIbd/iS4hAuyiYoaj1u0rORODFslyUv5+XNeCQ8br7UH+AxXfRPcpyQowvup3JbLfc rPSjVTdMn6wOOleldk10IMXN5gHtJ8eSxZgPY9wpDUsmEaHgHHeFzGy53RPr6ARjaIlw MuqTKT//YmbNXhMWApQsg8V5o6j9C0OeSl4Uwo8XKCqpRE7V0mwUYDi8YjmA9UyFiz0b 0yZ/N7qTqLWWb94Eb2Ld92SeiRkNZtKfD24pguBk1KAn0BjaYCTTgXJo3S6geNXIHZU2 UThw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=jeJHRfHImcK/U4nqREX2UVBc2j3cFdw289iYKIJvqxE=; b=nYL/PoMkvKLdXkmTCcg3GnnKDps/93U4AlRBBGaGREeH0hBCa/tPZfkiCC6zYXx5U+ 4bpMmvQ5D1KsfEvVrhNDSQxd0FrBOlKLW57jmS+aR+3vewFCq/KBvKMKc6tPySMlZ56N CklwD/H65c7aFW+bzJbahDUjnPBYQK2Z2es4+wxxhCHfJtTz8Z2TqjYjts5RM4ZytReY exnm4J8jNi8knw1iTxnTjebU09EbASi0eSLpWT/UwIhWPqshULMwju3PKvYNbYjJ7O57 ePjvNlBWhr4aNQe5X6BPRvV1O3yHWpAmexTM9cEOLPLWWbn0aLpWenogXOPGUeX6TZO9 PrYw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id b8si2398622lfp.3.2019.08.13.01.01.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Aug 2019 01:01:23 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id x7D81MhX027986 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Aug 2019 10:01:22 +0200 Received: from [139.25.69.208] (linux-ses-ext02.ppmd.siemens.net [139.25.69.208]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x7D81MUh019484; Tue, 13 Aug 2019 10:01:22 +0200 Subject: Re: isar-bootstrap fails to rebuild after config changes To: "[ext] Jan Kiszka" , isar-users , Claudius Heine References: From: Claudius Heine Message-ID: Date: Tue, 13 Aug 2019 10:01:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: Bzy+Q1J4zXj4 Hi Jan, On 12/08/2019 19.18, [ext] Jan Kiszka wrote: > Hi, > > I noticed today that I'm not getting a new bootstrap rootfs after adding > a repo to DISTRO_APT_SOURCES. Digging deeper, this revealed missing > STAMPCLEAN setting, but also more: > > Why are we probing for the existence of the DEPLOY_ISAR_BOOTSTRAP link > in do_apt_config_prepare(), Claudius? This obviously exists after a > first run, and that blocks refreshing all the apt settings if they have > changed. I do not know. That was added by a patch of Maxim (ab0a1c8c357a18ddd67fe4c0efc66a296d93dae2), maybe he knows. isar-bootstrap: Eliminate multiple debootstraps for the same distro/host After applying this patch only single debootstrap for particular platform is created and pointed by corresponding link under DEPLOY_DIR_IMAGE. For proper locking of parallel builds shell tasks apt_config_install, set_locale, setup_chroot, apt_update and deploy were collapsed to common debootstrap helper. Due to problems in bitbake with shell functions expansion under quotes these functions were substituted by their bodies. Signed-off-by: Maxim Yu. Osipov That is by the way a pretty big patch. Also parts of it could probably be reverted, since the 'problems in bitbake with shell functions expansion under quotes' are resolved in the current version by removing these quotes IIUC. > There is CLEANFUNCS set with clean_deploy(), but that is only run on > true do_clean(), not on rebuilds. Right. > > And finally, when I look at isar_bootstrap(), run by do_bootstrap(), it > protects checking and creating DEPLOY_ISAR_BOOTSTRAP with a lock. But > do_apt_config_prepare() runs lockless. This cannot work reliably. When I initially wrote isar-bootstrap, it didn't contain any looks. IIRC the locks where added when I wasn't active with isar and I haven't yet looked into why exactly they are needed and what they protect against etc. So you know probably more about them than me. regards, Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de