From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6695999620571463680 X-Received: by 2002:a5d:4e89:: with SMTP id e9mr10655084wru.72.1559112461533; Tue, 28 May 2019 23:47:41 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:f404:: with SMTP id z4ls322082wma.1.canary-gmail; Tue, 28 May 2019 23:47:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqx2oCD3t1nnZUrzql7etQtV23Ndbigb2xfXYe35tCylVCHm/5+Q0Wi6YZsV1qituUHfG43p X-Received: by 2002:a1c:f413:: with SMTP id z19mr5869023wma.145.1559112461142; Tue, 28 May 2019 23:47:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559112461; cv=none; d=google.com; s=arc-20160816; b=QGuZ53ROXnajUgO0qXZYCEfFvjpukay4zjcIy5ow6tXsuZlkzl+6dO8edxph3+F/Aq JP5+JPMsXoimLdWXhrQICYDV4vzA+OaAA4ABGYQph/fusdZaj11kLTYKaGTV7wERSgdG EfcTMX8Ivt8ju10d20Vbaed4b4nowz2IrHROzRwiMOOLnDD3StXC1Gnf3wRgFcRrfPRp Os6mtcW9o6a9sxYnM8TITq2Gd6g/bLgfbZQsJKnHozTDy6RcJR17E2/OpDNrhlmg4sxi JWvB9mAP7gY/2+D8d7tVbcfBVa6alCivIILBv/8jHlbfThZYzlT4HJmkPFt7AQqHHUal ApZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=CV6oLGqxVXIeScerSxeuVyiv/zi9MzoYyfDUTIN5yZM=; b=TxtQo3cRwRs87jRzf+VEX6lRIkVNFN8TLZ7otY3wYJz6jLLp5kcn5kmrADvbLkQ5ye OpMrcUMVjSbJ10+f/0NITV0tL2bMXg1Rjt5nTBlWD/WUM00GyM5s1DhjWdQrBSp8vlVi yMgXYWYn551mEm78qF0Yr//duxAbiRnax+3HDE/E7A3xpsYy56wDWbvk/y/wc23vmkOF iU3ThJGU1wXp6wZMSbsH8OTHMoAWmpqGE/ajeGhkN3UVue6EHnKTVLlb03pmYHExKX8j YXN1lQ0b6RkJXJfqk9aXa12bpm169hmSuFGJs7+/VWzsvkepaGKXjbJwALFliOwAmXsU 4dGw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id q11si644696wrj.2.2019.05.28.23.47.41 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 May 2019 23:47:41 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x4T6leTx016293 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 May 2019 08:47:40 +0200 Received: from [139.25.69.232] (linux-ses-ext02.ppmd.siemens.net [139.25.69.232]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x4T6ldJC018595; Wed, 29 May 2019 08:47:40 +0200 Subject: Re: [PATCH 2/3] image.bbclass: remove fstab generation To: Henning Schild Cc: isar-users@googlegroups.com, Claudius Heine References: <20190528085814.12967-1-claudius.heine.ext@siemens.com> <20190528085814.12967-3-claudius.heine.ext@siemens.com> <20190528193422.305051be@md1za8fc.ad001.siemens.net> From: Claudius Heine Message-ID: Date: Wed, 29 May 2019 08:47:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190528193422.305051be@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 0wgwJaLnITfN On 28/05/2019 19.34, Henning Schild wrote: > Systemd might be default, but is not guaranteed to be installed on a > working and officially supported debian. > > Yes we do kind of need it at the moment (for very few features where > other inits can be enabled as needed). But we would at least see a > conflict. I.e ssh-key-regen is pulling systemd while someone else is > pulling sysvinit. > > With this patch we might create non-bootable images, which is not OK. I would like to support any init system that debian supports as well, but I currently don't have any project that does not use systemd with isar, so for me there is currently no use case. But if you would implement a test case for SysV in meta-isar, then I could try to find a solution that works with SysV as well as systemd or any other init system we have a test case for (if the workload is at a manageable level). As is currently stands though we only test systemd and therefor officially only support that in isar. Claudius > > Henning > > Am Tue, 28 May 2019 10:58:13 +0200 > schrieb "[ext] claudius.heine.ext@siemens.com" > : > >> From: Claudius Heine >> >> Generating the fstab is not necessary, since the mounts are either >> default [1] or can be described via kernel command line or >> systemd.mount files. The current fstab generation mechanism is also >> to inflexible to allow easy customization from within an image recipe. >> >> [1] https://www.freedesktop.org/wiki/Software/systemd/APIFileSystems/ >> >> Signed-off-by: Claudius Heine >> --- >> meta/classes/image.bbclass | 16 ---------------- >> 1 file changed, 16 deletions(-) >> >> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass >> index 1950263..5682134 100644 >> --- a/meta/classes/image.bbclass >> +++ b/meta/classes/image.bbclass >> @@ -105,22 +105,6 @@ python set_image_size () { >> d.setVarFlag('ROOTFS_SIZE', 'export', '1') >> } >> >> -ROOTFS_CONFIGURE_COMMAND += "image_configure_fstab" >> -image_configure_fstab[weight] = "2" >> -image_configure_fstab() { >> - sudo tee '${IMAGE_ROOTFS}/etc/fstab' << EOF >> -# Begin /etc/fstab >> -/dev/root / auto >> defaults 0 0 >> -proc /proc proc >> nosuid,noexec,nodev 0 0 >> -sysfs /sys sysfs >> nosuid,noexec,nodev 0 0 >> -devpts /dev/pts devpts >> gid=5,mode=620 0 0 >> -tmpfs /run tmpfs >> defaults 0 0 >> -devtmpfs /dev devtmpfs >> mode=0755,nosuid 0 0 - -# End /etc/fstab -EOF -} - >> do_copy_boot_files[dirs] = "${DEPLOY_DIR_IMAGE}" do_copy_boot_files() >> { kernel="$(realpath -q '${IMAGE_ROOTFS}/vmlinuz')" > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de