From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6984671516770172928 X-Received: by 2002:aa7:d395:: with SMTP id x21mr21790120edq.98.1627312021081; Mon, 26 Jul 2021 08:07:01 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:aa7:df0b:: with SMTP id c11ls1576839edy.0.gmail; Mon, 26 Jul 2021 08:07:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxS/D7oDkoGrla333WN5x6eBSK8Vlc3MCWK2sssxxAxXguBEzaWoWumyNBX3mgQZ1huT4ba X-Received: by 2002:a50:9b06:: with SMTP id o6mr22411777edi.284.1627312020144; Mon, 26 Jul 2021 08:07:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627312020; cv=none; d=google.com; s=arc-20160816; b=hOLIKsWnnuegK5WFEPM3nHWIf9GB0CKobdgu0WsnpQsdCY4zNUpXwvqCzzEjqucHuN gLLGogXTIV2TT7mgj6FIqeaF+gm7LkdNp2pR5A2iXvyGs3UFnAOHUFyZDBdpGQCUTVDX RPpba9Uf58HlVOFGWajx3xw+MynuayUrQ89uQkuGJzeL/Cu8Q3pKe8LsEAEGs1SfPfPl yq+4SlCgFEdQI3ygVB5FLOSVrS7DaLldX7zlhi2xPvyHGdr4u4fVycbRtgM0xKGioGU4 wBalTo+Xh7xyjRAMswqoiqG09ZwqnZPjdVwdEDXjDc0G+GohRPBI0qpocmYQbPlEQL0b e6Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:cc:references:to:subject; bh=aiIuc9G2OkdnsPYwrBS2YrCrQ/WlJ55R7mb3uM+A35c=; b=UqQybD0s4an9iapw5FZnT/33Wmrp2zNJX2qwYvRl080e7tmmgyvzBzDmlz6WNCwHot ShnV3YDFwx0SialYd4WQLHoGIPn1S/15b14ZO96dnwMus1cayzBQaNmPNuZiIW+/z1Jc fC4qapkQHxaaOGZOejd6M+oHRtLfqcYVrOehbEKEANY1eUTt7Szj5agDkEfeHk1tak12 9b/AJuWHxS9VYA8EleN6/vsAKbeXb/nePyK9PnHVZ1k5qBh+lDAh6TcGM/1Z432a5M5H GhINECR7oS4w8DOrDvF9nyE8VWP/HJBw35AYzio0TMyE01UIAGHABfC3iFxlLWu0xtd/ vyFQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id d26si5606edr.3.2021.07.26.08.07.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Jul 2021 08:07:00 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [192.168.67.164] (mm-198-62-214-37.mgts.dynamic.pppoe.byfly.by [37.214.62.198] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 16QF6wK6020381 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Jul 2021 17:06:59 +0200 Subject: Re: [PATCH v3 0/3] Fix imager-buildchroot dependency To: isar-users References: <20210714065234.300300-1-amikan@ilbers.de> Cc: Jan Kiszka , Baurzhan Ismagulov From: Anton Mikanovich Message-ID: Date: Mon, 26 Jul 2021 18:06:53 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210714065234.300300-1-amikan@ilbers.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: +fVBMscJnwJC 14.07.2021 09:52, Anton Mikanovich wrote: > If using imager with ISAR_CROSS_COMPILE="1" it still depends on > buildchroot-target because of hardcoded flag value. Moreover, there were > no way to depends on buildchroot based on logic placed in python > anonymous function in buildchroot.bbclass. It forced developer to place > dependency set code inside buildchroot choose logic for any tasks like > do_apt_fetch was implemented. > To be able to set dependencies in places where they were implemented but > still take care about cross compile modes we need to put buildchroot > choose result into datastore variable and rely on it later. > > Anton Mikanovich (3): > buildchroot: Introduce buildchroot dependency variable > buildchroot: Move apt_fetch dependency to dpkg-base > image: Fix do_install_imager_deps dependency > > meta/classes/buildchroot.bbclass | 4 ++-- > meta/classes/dpkg-base.bbclass | 3 +++ > meta/classes/image-tools-extension.bbclass | 2 +- > 3 files changed, 6 insertions(+), 3 deletions(-) > Does anything speaks against it or someone see more clear implementation? If not, will merge this. -- Anton Mikanovich Promwad Ltd. External service provider of ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn, Germany +49 (89) 122 67 24-0 Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov