Re: [PATCH v3 5/6] Use all source lists in target root apt

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi,

On Wed, 2019-03-06 at 18:27 +0100, [ext] Henning Schild wrote:
> Am Wed, 6 Mar 2019 17:26:17 +0100
> schrieb "[ext] Andreas J. Reichel" <andreas.reichel.ext@siemens.com>:
> 
> > From: Andreas Reichel <andreas.reichel.ext@siemens.com>
> > 
> > When we only use isar-apt.list, we cannot add additional
> > repositories
> > since they are listed in the bootstrap list only.
> 
> As far as i understood some entries in the list are not "enabled" or
> fully working before we added the key. The reasoning behind this
> change
> is somehow gpg ... and that needs to go in here. Because that is the
> first violation of "we only update isar-apt". But the violation is so
> early in the bootstrap that it is probably ok.

I don't think so. That apt-get update is part of the isar-bootstrap-
helper, so it will be called late when the image is build. That could
cause conflicting versions between the buildchroot and the resulting
image.

The reason why the general apt-get update is called only in the isar-
bootstrap recipe is so that there are no index conflicts between all
images that base itself on the same isar-bootstrap rootfs.

Claudius

> 
> Henning
> 
> > Signed-off-by: Andreas Reichel <andreas.reichel.ext@siemens.com>
> > ---
> >  meta/classes/isar-bootstrap-helper.bbclass | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> > 
> > diff --git a/meta/classes/isar-bootstrap-helper.bbclass
> > b/meta/classes/isar-bootstrap-helper.bbclass index 1f24037..f9e3fba
> > 100644 --- a/meta/classes/isar-bootstrap-helper.bbclass
> > +++ b/meta/classes/isar-bootstrap-helper.bbclass
> > @@ -130,10 +130,7 @@ setup_root_file_system() {
> >              rm "$ROOTFSDIR/tmp/$kfn"
> >          done
> >      fi
> > -    sudo -E chroot "$ROOTFSDIR" /usr/bin/apt-get update \
> > -        -o Dir::Etc::sourcelist="sources.list.d/isar-apt.list" \
> > -        -o Dir::Etc::sourceparts="-" \
> > -        -o APT::Get::List-Cleanup="0"
> > +    sudo -E chroot "$ROOTFSDIR" /usr/bin/apt-get update
> >      # Add multiarch for cross-target
> >      if [ "${ROOTFS_ARCH}" != "${DISTRO_ARCH}" ]; then
> >          sudo -E chroot "$ROOTFSDIR" /usr/bin/dpkg --add-
> > architecture
> > ${DISTRO_ARCH}