Re: [PATCH v2] isar-init-build-env: Always set ISARROOT

[vijai kumar <vijaikumar.kanagarajan@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1692 bytes --]



On Tuesday, December 17, 2019 at 5:54:03 PM UTC+5:30, Baurzhan Ismagulov 
wrote:
>
> On Wed, Dec 11, 2019 at 02:14:03AM -0800, vijai kumar wrote: 
> > Ok. On a recent thought, Things would go wrong only when someone moves 
> the 
> > isar-init-build-env and writes 
> > a wrapper script in the same location. In that case, one would need to 
> pass 
> > in the ISARROOT from the caller to isar-init-build-env. 
>
> A pattern I see in Yocto downstream projects is the project directory 
> containing poky as subdirectory. The project wrapper script calls the poky 
> one 
> from the subdirectory. I think the problem is that there is no reliable 
> way to 
> determine ISARROOT under different shells, e.g.: 
>
> cd /home/ibr/myprj 
> . myprj-init 
>     . isar/isar-init-build-env 
>
> The desired value is /home/ibr/myprj/isar. This works with shell 
> extensions 
> under bash and zsh, but not with dash, thus the ugly 
> THIS_SCRIPT="$(pwd)/isar-init-build-env" (which also doesn't work for the 
> scenario above). Dash is the default in Debian to speed up the boot 
> process. 
>
>  
Ah, I see.


> > The issue we have in hand is more critical than this one feature, which 
> > could very well be written in other ways. 
>
> I agree this is an important issue. My suggestion: 
>
> * Keep accepting the preset ISARROOT from the environment. 
>
> * Remove ISARROOT from the wic scripts. 
>
> * Restore unsetting ISARROOT. 
>
>
Agreed. I think its better remove ISARROOT references now before it gets 
used in multiple places.
Right now, I think its mostly in wic-img and ci-build. I will keep this in 
my todo-list pipeline.

Thanks,
Vijai Kumar K



> With kind regards, 
> Baurzhan. 
>

[-- Attachment #1.2: Type: text/html, Size: 2357 bytes --]