From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6613620343774904320 Date: Thu, 18 Oct 2018 04:45:00 -0700 (PDT) From: chombourger@gmail.com To: isar-users Message-Id: In-Reply-To: <695f9e56-13af-9a25-df97-4f1b8a11a364@siemens.com> References: <1539853468-156-1-git-send-email-Cedric_Hombourger@mentor.com> <578d4e7b-292e-3795-08d7-041c9abe80ee@siemens.com> <695f9e56-13af-9a25-df97-4f1b8a11a364@siemens.com> Subject: Re: [PATCH] image: include image name in the kernel/initrd image copies MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_2731_588355321.1539863100714" X-Google-Token: ELzkod4FHA4vaJwokmQ0 X-Google-IP: 192.94.31.2 X-TUID: BOpKhQk9HiTt ------=_Part_2731_588355321.1539863100714 Content-Type: multipart/alternative; boundary="----=_Part_2732_2085785312.1539863100714" ------=_Part_2732_2085785312.1539863100714 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Jan, We have two use cases so far: QEMU and wic. Both work without downstream > effort > by just using those two variables. That by itself is not bad. An > alternative > might only by peeking directly into the rootfs trees of the images, i.e. > avoiding the copying to deploy. Not sure, actually, what value this > copy-out > provides, at least as long as the user does not manual deployment of the > artifacts. > Same here, it just sounded like a bigger change (which I am happy to work on if we want to go down this path) Anyway. If we keep copy-out: Instead of appending further elements to the > kernel/initrd prefix, we should really consolidate things. The image, > maybe it > be wic-generated or ext4-img or whatever, as well as associated artifacts > should > follow the same file naming scheme so that you can easily identify related > artifacts. > Aren't we there with this patch? $ ls *isar-image-base-debian-stretch-qemuamd64* initrd.img-4.9.0-8-amd64_isar-image-base-debian-stretch-qemuamd64 isar-image-base-debian-stretch-qemuamd64.wic.img vmlinuz-4.9.0-8-amd64_isar-image-base-debian-stretch-qemuamd6 The command returned as expected all the image artifacts we have for IMAGE=isar-image-base && DISTRO=debian-stretch && MACHINE=qemuamd64 The name pattern would be: [-]--[] Cedric ------=_Part_2732_2085785312.1539863100714 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Hi Jan,

We have two use cases so far: QEMU and wic. Both work without downstream= effort=20
by just using those two variables. That by itself is not bad. An altern= ative=20
might only by peeking directly into the rootfs trees of the images, i.e= .=20
avoiding the copying to deploy. Not sure, actually, what value this cop= y-out=20
provides, at least as long as the user does not manual deployment of th= e artifacts.

Same here, it just sounded like a bigg= er change (which I am happy to work on if we want to go down this path)

Anyway. If we= keep copy-out: Instead of appending further elements to the=20
kernel/initrd prefix, we should really consolidate things. The image, m= aybe it=20
be wic-generated or ext4-img or whatever, as well as associated artifac= ts should=20
follow the same file naming scheme so that you can easily identify rela= ted=20
artifacts.

Aren't we there with this patch?

$ ls *isar-image-base-debian-stretch-qemuamd64*
initrd.img-4.9.0-8-amd64_isar-image-base-debian-stretch-qemuamd64=C2= =A0 isar-image-base-debian-stretch-qemuamd64.wic.img=C2=A0 vmlinuz-4.9.0-8-= amd64_isar-image-base-debian-stretch-qemuamd6=C2=A0

The command returned as expected all the image artifacts we have for IMAG= E=3Disar-image-base && DISTRO=3Ddebian-stretch && MACHINE= =3Dqemuamd64
The name pattern would be: [<sub-image-name>-]= <image>-<distro>-<machine>[<suffix>]

=
Cedric
------=_Part_2732_2085785312.1539863100714-- ------=_Part_2731_588355321.1539863100714--