public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH] sbuild-chroot: Drop no longer needed and now broken riscv64 special case
@ 2025-02-24 21:02 'Jan Kiszka' via isar-users
  2025-03-10  6:31 ` 'Jan Kiszka' via isar-users
  2025-03-12 13:09 ` Uladzimir Bely
  0 siblings, 2 replies; 4+ messages in thread
From: 'Jan Kiszka' via isar-users @ 2025-02-24 21:02 UTC (permalink / raw)
  To: isar-users

From: Jan Kiszka <jan.kiszka@siemens.com>

This was forgotten while cleaning up for trixie in 735dc16c1e. However,
it continued to work - until these days. Fix the riscv64 build by simply
dropping the obsolete package list.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

Found via isar-cip-core where riscv64 is no longer allowed to break the 
build.

 meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
index 255d6937..3f0888d8 100644
--- a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
+++ b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
@@ -18,9 +18,3 @@ SBUILD_CHROOT_PREINSTALL ?= " \
     crossbuild-essential-${DISTRO_ARCH} \
     apt-utils \
     "
-
-SBUILD_CHROOT_PREINSTALL:riscv64 ?= " \
-    ${SBUILD_CHROOT_PREINSTALL_COMMON} \
-    gcc-riscv64-linux-gnu \
-    g++-riscv64-linux-gnu \
-    dpkg-cross"
-- 
2.43.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/e0283029-6862-4282-a235-0dab237a143e%40siemens.com.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] sbuild-chroot: Drop no longer needed and now broken riscv64 special case
  2025-02-24 21:02 [PATCH] sbuild-chroot: Drop no longer needed and now broken riscv64 special case 'Jan Kiszka' via isar-users
@ 2025-03-10  6:31 ` 'Jan Kiszka' via isar-users
  2025-03-10  8:35   ` 'MOESSBAUER, Felix' via isar-users
  2025-03-12 13:09 ` Uladzimir Bely
  1 sibling, 1 reply; 4+ messages in thread
From: 'Jan Kiszka' via isar-users @ 2025-03-10  6:31 UTC (permalink / raw)
  To: isar-users

On 24.02.25 22:02, 'Jan Kiszka' via isar-users wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> This was forgotten while cleaning up for trixie in 735dc16c1e. However,
> it continued to work - until these days. Fix the riscv64 build by simply
> dropping the obsolete package list.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
> Found via isar-cip-core where riscv64 is no longer allowed to break the 
> build.
> 
>  meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
> index 255d6937..3f0888d8 100644
> --- a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
> +++ b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
> @@ -18,9 +18,3 @@ SBUILD_CHROOT_PREINSTALL ?= " \
>      crossbuild-essential-${DISTRO_ARCH} \
>      apt-utils \
>      "
> -
> -SBUILD_CHROOT_PREINSTALL:riscv64 ?= " \
> -    ${SBUILD_CHROOT_PREINSTALL_COMMON} \
> -    gcc-riscv64-linux-gnu \
> -    g++-riscv64-linux-gnu \
> -    dpkg-cross"

Can we please finally merge this fix? I'd like to avoid have to release
a downstream layer with an isar patch.

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/a7ad8d8d-3a02-46fc-a32c-7c183081493e%40siemens.com.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] sbuild-chroot: Drop no longer needed and now broken riscv64 special case
  2025-03-10  6:31 ` 'Jan Kiszka' via isar-users
@ 2025-03-10  8:35   ` 'MOESSBAUER, Felix' via isar-users
  0 siblings, 0 replies; 4+ messages in thread
From: 'MOESSBAUER, Felix' via isar-users @ 2025-03-10  8:35 UTC (permalink / raw)
  To: isar-users, Kiszka, Jan

On Mon, 2025-03-10 at 07:31 +0100, 'Jan Kiszka' via isar-users wrote:
> On 24.02.25 22:02, 'Jan Kiszka' via isar-users wrote:
> > From: Jan Kiszka <jan.kiszka@siemens.com>
> > 
> > This was forgotten while cleaning up for trixie in 735dc16c1e.
> > However,
> > it continued to work - until these days. Fix the riscv64 build by
> > simply
> > dropping the obsolete package list.
> > 
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> > 
> > Found via isar-cip-core where riscv64 is no longer allowed to break
> > the 
> > build.
> > 
> >  meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb | 6 ----
> > --
> >  1 file changed, 6 deletions(-)
> > 
> > diff --git a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-
> > host.bb b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
> > index 255d6937..3f0888d8 100644
> > --- a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
> > +++ b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
> > @@ -18,9 +18,3 @@ SBUILD_CHROOT_PREINSTALL ?= " \
> >      crossbuild-essential-${DISTRO_ARCH} \
> >      apt-utils \
> >      "
> > -
> > -SBUILD_CHROOT_PREINSTALL:riscv64 ?= " \
> > -    ${SBUILD_CHROOT_PREINSTALL_COMMON} \
> > -    gcc-riscv64-linux-gnu \
> > -    g++-riscv64-linux-gnu \
> > -    dpkg-cross"
> 
> Can we please finally merge this fix? I'd like to avoid have to
> release
> a downstream layer with an isar patch.

If you want to release a downstream layer, you also need to consider
the "fix(rootfs): cleanup leftover 0000bootstrap.list" patch.
It would be good if that could get merged as well.

Currently ISAR is in a - let's say - not optimal state.

Felix

> 
> Jan
> 
> -- 
> Siemens AG, Foundational Technologies
> Linux Expert Center

-- 
Siemens AG
Linux Expert Center
Friedrich-Ludwig-Bauer-Str. 3
85748 Garching, Germany

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/d56133dbf2c25adb8ae46a4f45bd79a13fa20468.camel%40siemens.com.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] sbuild-chroot: Drop no longer needed and now broken riscv64 special case
  2025-02-24 21:02 [PATCH] sbuild-chroot: Drop no longer needed and now broken riscv64 special case 'Jan Kiszka' via isar-users
  2025-03-10  6:31 ` 'Jan Kiszka' via isar-users
@ 2025-03-12 13:09 ` Uladzimir Bely
  1 sibling, 0 replies; 4+ messages in thread
From: Uladzimir Bely @ 2025-03-12 13:09 UTC (permalink / raw)
  To: Jan Kiszka, isar-users

On Mon, 2025-02-24 at 22:02 +0100, 'Jan Kiszka' via isar-users wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> This was forgotten while cleaning up for trixie in 735dc16c1e.
> However,
> it continued to work - until these days. Fix the riscv64 build by
> simply
> dropping the obsolete package list.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
> Found via isar-cip-core where riscv64 is no longer allowed to break
> the 
> build.
> 
>  meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-
> host.bb b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
> index 255d6937..3f0888d8 100644
> --- a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
> +++ b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
> @@ -18,9 +18,3 @@ SBUILD_CHROOT_PREINSTALL ?= " \
>      crossbuild-essential-${DISTRO_ARCH} \
>      apt-utils \
>      "
> -
> -SBUILD_CHROOT_PREINSTALL:riscv64 ?= " \
> -    ${SBUILD_CHROOT_PREINSTALL_COMMON} \
> -    gcc-riscv64-linux-gnu \
> -    g++-riscv64-linux-gnu \
> -    dpkg-cross"
> -- 
> 2.43.0
> 

Applied to next, thanks.

-- 
Best regards,
Uladzimir.

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/a4846998ce68611c107bcf6f9da0678fb1b30211.camel%40ilbers.de.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-03-12 13:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-24 21:02 [PATCH] sbuild-chroot: Drop no longer needed and now broken riscv64 special case 'Jan Kiszka' via isar-users
2025-03-10  6:31 ` 'Jan Kiszka' via isar-users
2025-03-10  8:35   ` 'MOESSBAUER, Felix' via isar-users
2025-03-12 13:09 ` Uladzimir Bely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox