On Tue, 2023-05-09 at 09:44 +0200, 'T. Schaffner' via isar-users wrote: > From: Tobias Schaffner > > This allows us to drop a lot of encoding and parsing code that was > used > to transition to shell and therefore makes it easier to read and > maintain. > > Using python functions for more complex tasks allows us the usage of > unittests. A very basic infrastructure for unittesting using the > build > in python unittest and the bb.parse module was added. This was used > to > test the re-implementation of the image-account-extension as a first > showcase. > > This is a rebased version of the refactoring part of the "allow > creation > of users/groups before rootfs creation" patch series to decouple the > merge of the simplifications. > > Changes since v1: > - Fix wrong yeaar in copyright of image-account-extension > > Tobias Schaffner (4): >   simplify image-account-extension >   create a minimal python unittest infrastructure >   add unittests for the image-account-extension >   set minimal python version in user_manual to 3.5 > >  doc/user_manual.md                            |   2 +- >  meta/classes/image-account-extension.bbclass  | 368 ++++++---------- > -- >  testsuite/unittests/README.md                 |  28 ++ >  testsuite/unittests/bitbake.py                |  37 ++ >  testsuite/unittests/rootfs.py                 |  45 +++ >  .../unittests/test_image_account_extension.py | 145 +++++++ >  6 files changed, 380 insertions(+), 245 deletions(-) >  create mode 100644 testsuite/unittests/README.md >  create mode 100644 testsuite/unittests/bitbake.py >  create mode 100644 testsuite/unittests/rootfs.py >  create mode 100644 > testsuite/unittests/test_image_account_extension.py > > -- > 2.34.1 > While testing this in CI, got the following error while building any targets: /usr/sbin/groupmod: unrecognized option '--system' I didn't deeply debug why exactly this arg comes to gropmod. The strange thing is that there are no visible errors in do_image_postprocess log, while build in general fails. See the attachments.