From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7288709884549267456 X-Received: by 2002:a05:6402:1cab:b0:53d:f180:3cc5 with SMTP id cz11-20020a0564021cab00b0053df1803cc5mr2344827edb.20.1697095440099; Thu, 12 Oct 2023 00:24:00 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:797:b0:532:b974:6714 with SMTP id d23-20020a056402079700b00532b9746714ls69801edy.0.-pod-prod-04-eu; Thu, 12 Oct 2023 00:23:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGFpmJ7AK/gUlifFZMY9767vvRhsyVkWx4zoc+rwvOPKUywgX3RGXm7kxzw4ssKuENQ/kS/ X-Received: by 2002:aa7:c0d8:0:b0:525:469a:fc47 with SMTP id j24-20020aa7c0d8000000b00525469afc47mr19892132edp.22.1697095438041; Thu, 12 Oct 2023 00:23:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1697095438; cv=pass; d=google.com; s=arc-20160816; b=U7r/Opu8ReXF8sseaaJaNlu/DAm9HLE1xN58wnZF9Ta7rPMeWflU33z5azX6atnJhK 8P67hJkuFbvJi9VYVnVxTIq0FENFwO5ZGhhJ8jo7cMYeNTSLfPGzqw766bGaaIwgKMWs y2hsXulyCOy6UpKOQdUk9TsOJjzR2VoJjWX8J87iHk/yL02gkFhbl2Nndg+xzhBUClkP XacTgGC5tAGQyE08svppzG+oWlNAxhxaGzeUcBpheJ7q8mPtZh/H8kMv63Mt9+WqWAiz qoWSFDvG6eW0X4bnwTmeL3Ma7Q2ohu1bFvCJgzzdbI1YwgV4M+qJqOTmfQ60CzQUy522 JFkw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :cc:to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=Ocqk6WfJ1LAAg/FBpJEaA3tsXzUYqky71YdG88wMotA=; fh=+MsiJ3+n32sX/1mUuHDBorlPvpDGOXeSQm8uk6tvrgc=; b=lZfhEOMlqdrWVP6vDF0eJR3f86MoIPU8yN64renYK7WWodxTFO6xL+E/qppUyvgGwz vFX4HeKrbolC4mW5OLO1/J7qVxp01HGpdjaQjroC59EKEAO8IqxZ1v5EzwoJT7u6WiCY 3QPQR+tUrlq9/EiC5wFipx2OzKZ4rTCHUFF3leGqltnZnb5szEXG40HSVvlNKhu/V0m3 +acvAfQiTE4PlDcgS2QjuIZelulOyiP1W3Httn51jFKPr0Qjxj8EuJ9+UeL0kzHfD5JP f+8SELQwseAL1++1bhmxKAv25EQ6YwE7Ab1Q6nEEQ33gbMmTSJdB8qEVhfdyedJzTyWo tncQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=gmZzTa4P; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0c::62a as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on062a.outbound.protection.outlook.com. [2a01:111:f400:fe0c::62a]) by gmr-mx.google.com with ESMTPS id h2-20020a0564020e8200b00530b66cee61si823693eda.0.2023.10.12.00.23.57 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Oct 2023 00:23:57 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0c::62a as permitted sender) client-ip=2a01:111:f400:fe0c::62a; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=gmZzTa4P; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0c::62a as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZZ18K/ICJFtWZliEYx9qzcxRJfDWG+i0OhMaoHj2HYJomggjXDN7x/7XTfuaEtDmYzBGwABiy0yZ8JUOVXz98MXuIogtqJyuIVWP59NV0fqzAuy5hscBAZGvlzA6bQObVt3ADSW5BId+NCp/pQMaDqyZUAfZlTwtx+jsylCZPbQ7IwSg2dZZQlMgdGJn9IAVrrTk0/oEayIJsw4yf/0ogrpl0uubhrNlEVeZf9fOq53epddvLn2+MZcsuj3+86CsPhiaD2hYDYuZQod77YU8RrzJed0a80eLKsWmbaSHiCGSBjQT54Z9GjzE2UY8UI9Cn2td5ExRU3Pqp9MStLYRhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ocqk6WfJ1LAAg/FBpJEaA3tsXzUYqky71YdG88wMotA=; b=DCbD8yYktebN+Pjbgwlf6h1opmRiUOiFwkicz7QctctR9kCTrItxXJM3TDmY37Qpjqa7XhahbqGwUpDR9VVSib0pDO8zscsFRwYAJkxSajVW8NxRUpjRl0OVT76za0SniIb3tMjzZF/J6V5Qo0Gw22UQZ8iXO3ZOAYF0vanSIQgYfHMOJoRZLOXfhLM1EHvx8D9tqpPI4OHouICwfGBEMomNBv87ZdAd/3s0xmqtCye5w2tDKBV/Ya6ArcHzlXyxuOE4H6e42qpEL4NAcTQ6ls37OQxUg5MzMj5QFcThZWYNjOL0xWueOiBbvR+aBYSI0k1HizVDLEAMcKAdSQpnKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ocqk6WfJ1LAAg/FBpJEaA3tsXzUYqky71YdG88wMotA=; b=gmZzTa4P8sW8J/KPosA/olm6EGErZbda8Wm1EklWA481BwWYB2nRCSR5+mWilYB/nhGBbNAv4Cp2hDXbYGyxyuRdXmri4YvL66POBbLSaoAer2NaEv/P9LPkXmewSzU1lgPeG0HxPX6BdELpT8qsx1nebLcdxAltlDfu9TgbRSqt1hzqiL8z7NSK2U+Z3D2TgjIQ9O6EUjT8LqbRmg2eXqAPRtsS9dzxwbnJpiYYF89U9TpTboKQouFxq40PzDU2nFWjlnK3tWrtxZ9FmAAZdQ/Fi7WTUJ0d8AwMTNuaKkyrPgYVIi2Bk77/6aoLmZRGFq53Djvrl+acSZ+zfPtC+Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by DU0PR10MB5311.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:34e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.45; Thu, 12 Oct 2023 07:23:56 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::2a90:96cb:b3f:6e5]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::2a90:96cb:b3f:6e5%2]) with mapi id 15.20.6863.032; Thu, 12 Oct 2023 07:23:56 +0000 Message-ID: Date: Thu, 12 Oct 2023 09:23:49 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] meta: optee-client: Generalize and update shutdown rule Content-Language: en-US To: Uladzimir Bely , isar-users Cc: "Su, Bao Cheng (RC-CN DF FA R&D)" , "Lopes Ivo, Diogo Miguel (T CED IFD-PT)" References: <9f958987-bf89-4dd6-8242-f4e5c90aad1f@siemens.com> From: Jan Kiszka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FRYP281CA0011.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::21) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|DU0PR10MB5311:EE_ X-MS-Office365-Filtering-Correlation-Id: 68191324-1646-4d6b-075e-08dbcaf431dd X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h5bEzOHHyOyptl4DYXv1RCnDKiXFzCqZZHac2IRxMJC0/TXqH9GDMpMn0Jo6wth+Fi9O6rUfjLyrtb5eL6LuuYGiuucTGLyKTotH9eZFsj6RjXsVI7/T/qnUZEfkpALf77hBqcw1N0Et521cCUosQrwNv8l7d8LF3lfadTCULo8Tk/YnVUHLCqAuwQl+PUJrho1gejL1FHvmoxLmVUK2ul3yVgRDuHemroHC0+a+7DdJka2XyeAIDYG2eZvShMhbG8K0UrBqAYkzR54K1eWAskYNDdjJKQSz+nHbsCkoqIp7kTxhAIo3jXwW2VxOdXwwAyy4Ru7nHjUS/0p5Z8H6L84ql+yPXdEt5kvJDiLFz5UHOkSU+wNQ7q/t4UH0xrNFV3gM07ZkQEfQZkXZjJrYFVORKaSwETIKBJNCXUgsFu8XBBa+Avzj6QLUjlhBOWjfZ+mpMDwDbNxdJtm9mf1+/Sd0ZX2Yd3DzuwHFhVIbIIJjX+i6NzvOnypeoSDbd+nE72LGP4OOnu1IHz5L3ADA4d0G14N15JMpBSks97wCEld+wFWk/NO6tLHnOLwdxpOy1qL+ZeKRGmSjVNnrhBUZ51q4wFu43i0/MCnHDpoCfNyt7vCU5uLMKdTKTthKKF5ZG0UB5JnuIcpQItWKSfUtog== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(376002)(346002)(39860400002)(136003)(366004)(396003)(230922051799003)(1800799009)(64100799003)(451199024)(186009)(2906002)(4001150100001)(15650500001)(86362001)(36756003)(31696002)(82960400001)(38100700002)(66556008)(2616005)(54906003)(107886003)(316002)(41300700001)(66946007)(110136005)(26005)(66476007)(6486002)(6666004)(31686004)(6512007)(83380400001)(53546011)(6506007)(478600001)(5660300002)(44832011)(8936002)(8676002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUlGa3k4UHRoL3ZiTHNkbkhmYmRDNmt5ZnpqRWZRQjZ2ak1GeFRQbE12cTdO?= =?utf-8?B?Nm5kSjlDY1ZxMncyY0pQNTZCSnpXZFNULzJHblFxTyt1em1kUVB0M2ZxUmFW?= =?utf-8?B?am1VbFh4VGhNMStjemdOcktoM1JST3JmVFJBTGZCMVVFbkJkdktZUzJCdU5N?= =?utf-8?B?MXdSVWgrbnRFanB2eWcvbDAwSmsyL2RsM2c1WFhpckFGQmdmUkdNUjI1TWIz?= =?utf-8?B?UG1OV25IdlNMT3hKQVFNZnJXb2Z4ZzQzNDlCWjUrUFk3Y2Y1cHBCQUp2TExS?= =?utf-8?B?NEZuL0tsQVI2dW4yc2p0ZUVRSGdwUjlGNWs4SVlqSFJWbWlCWVlWeHdHajNH?= =?utf-8?B?YlU4V3pRdFA3S2Zqa0hhTEdzTFo4ZlRYK0QxRm5reExBYWJmbXh3UU1jOGVs?= =?utf-8?B?ZEtGRGFucklhN3dVRzlkQzh4eTNjSlhFQi82ZDYxYzRDVDlpTTNrQkhjZ3Mz?= =?utf-8?B?bzg3V1ZweHRSWUc5d0RlV0RHdTNnTkMyTWQ5VjMxSGpmZXVaQWFzUzZjU1kw?= =?utf-8?B?UWtSZTZHSlRtL0VPekt1SmFFTFZtclM0ZXo5aGp4WEZVejVmK3VNUlpMcXVU?= =?utf-8?B?bXI4NEhaRy9Qa1IwLzBzYzR0bUg2Qi9ta0pEdURnU0JuWnhuSnE4V0lVUm9Y?= =?utf-8?B?ZCtjaHhheEZoYmFsd0w0R0pHS2R5SlAyRllUd0cybjFHZm82SmdQSmswdGl6?= =?utf-8?B?c3kzWmVab01BZEJmQ2VZblA2eXRLRXE1TUlaS3BRWXNMT1dkQnJDZmdIL0I4?= =?utf-8?B?cWYzRWNpc1Fwa1JVLzZCT0Y4UGhnVkRIOXpXeTMvamlwNDRDN3FBRG1OUnFo?= =?utf-8?B?eWZySVQ1RUZ4TFhTRkQ5ZUo3MHUxbkV6a0psUWE4amhDK2R1SmZ3NzBDR1Z2?= =?utf-8?B?aHVVUmUvM3p6eStBYXlCSHdZdXlWMjY2blppREtOVTM4Nk1OaGNXS3NBVnBl?= =?utf-8?B?ZGtaUWk1ang1ZXZpZDVDeGRPNEg1NGRsZThtUWEycmN6OWNnVHVwZjdVbWZK?= =?utf-8?B?WmV1TFpqSit3RHIrZUZacDVvMExmRHl3Uk1nczgxL253K1hnKzJYbEVWSHkv?= =?utf-8?B?UDJka0dENjZvMXdBTE9ZRmVBaXAyWnphTWdFOW03ai90RHRLalg4OHNYdGtM?= =?utf-8?B?OXkwcE56cFdzNzREQjk1Q3IzMTBiUU9yUEhjcVNKOVgrcWRMUWlMc1VJM3gw?= =?utf-8?B?UW52SjBLOGhSTTRHbUJVZTVyUGdBdW9meFZyV2xwUERXL0RPVjZ1Z2R6QnAy?= =?utf-8?B?bi8wUzUvRXptK0FGZUdzcnhDNGVsdFdzSVFwbzc3cklHSkpsZDdzQ3JGWXlo?= =?utf-8?B?UnhVbUJYRXhLWmRhQWRzTE1LUUxTTGdleDFvb0dJc1l4ZkJBc3A1L1RxL0Mw?= =?utf-8?B?SkpKQ2xabjhSQ2tuYjlLczM2TGRBQUQ0cXVyZEpxVmtCTWpCWUVPTkl2blNE?= =?utf-8?B?amkzenBBYUJzZkVsZ1NReTBpQTBXVFpnZGtNYkpHUFFlZDV6RnlyL1Mwd0o5?= =?utf-8?B?TmY4WHF1SmtTT2tsRXZ4WEs4aThPK3ArN21nTWxKd2thcXp6eW1CQ1BIK2Nw?= =?utf-8?B?ZTdyNTdONm5uM09hZ0RiV2lxT2QwNnZiZ0pxQzFFQlpSczVuaU9tOEg1ZVBh?= =?utf-8?B?VzR4K29oLzNqYnBrVXMvNFpyRStkTm9FYzBHL2VDVDRFb3hWUnhzMCtYb3Vn?= =?utf-8?B?VGx3VjRuZU1CeEJLZkUwTkNCaFFCcU5CUmZ6OVJNWHNYU0xDU2pkMENvMU1P?= =?utf-8?B?NnJVWWRKci9MNGVsK3FuSEpRTmVLenJGN1NpajlIVW9XOUhuWVBXN2ovOUxD?= =?utf-8?B?MUFwU2NqTGw1ZzVCYnMvblJsdmpTN29Fa1RnRWplN0hPWTRNQnpFOFdoZG9E?= =?utf-8?B?cEJSMGdxcmVJWUJkalR2NkpoUWxDYnp4eTVJckl5SjM2eFdGVFZqZ2k2Nngr?= =?utf-8?B?M3JnUnp5TTBrSkUyeU5aOHIvditYSjhnZUVFejVDdVhVWitjRkFiOGRuT1NS?= =?utf-8?B?Q0V5QkxVbHpHOE8rQTZSQTFXb3ZHdmJpYm82ZFNpaVdwVDEzSWFnTDVXeVpS?= =?utf-8?B?Z2dLM0tVN3UvWG1VSkp2RWZHV3NSTmQ0NjJ1MFVjL29lWGFTaDg2VkFmMTJ3?= =?utf-8?B?T1RldlYzdzFVUjkzVnVmbmRiem1EQ0pIajl2ZVRIZ1JwUHJLTWRpODk4SFB1?= =?utf-8?B?Vmc9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68191324-1646-4d6b-075e-08dbcaf431dd X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 07:23:56.1930 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2i8u+eoZmQJ59LsiuV7OpcSoIddD+AuT1EDzvnwvnjqkLewKfXg4T9kK87X1xFF0qQUd/oa1QUShgfJom6t6fA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB5311 X-TUID: XmMYMs7X675T On 12.10.23 09:15, Uladzimir Bely wrote: > On Thu, 2023-10-12 at 09:01 +0200, 'Jan Kiszka' via isar-users wrote: >> On 11.10.23 16:36, 'Jan Kiszka' via isar-users wrote: >>> From: Jan Kiszka >>> >>> First, naming changed somewhere between kernel 5.10 and 6.1 so that >>> optee-ta-bc50d971... is now optee-ta-supp-bc50d971... >>> >>> And then we should account for possibly more devices that need to >>> be >>> unbound. Use POSIX-compliant shell code for this. >>> >>> The generic loop allows to drop the explicit unmounting of efivarfs >>> because the corresponding driver will already get unbound. >>> >>> Signed-off-by: Jan Kiszka >>> --- >>>  .../optee-client/files/debian/tee-supplicant.service           | 3 >>> +-- >>>  1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/meta/recipes-bsp/optee-client/files/debian/tee- >>> supplicant.service b/meta/recipes-bsp/optee- >>> client/files/debian/tee-supplicant.service >>> index cc92a5fd..d8b630a4 100644 >>> --- a/meta/recipes-bsp/optee-client/files/debian/tee- >>> supplicant.service >>> +++ b/meta/recipes-bsp/optee-client/files/debian/tee- >>> supplicant.service >>> @@ -13,8 +13,7 @@ Type=oneshot >>>  RemainAfterExit=yes >>>  # Start if not already started by the initramfs hook >>>  ExecStart=/bin/sh -c '/usr/bin/pgrep tee-supplicant >/dev/null || >>> /usr/sbin/tee-supplicant -d' >>> -ExecStop=/bin/sh -c '/usr/bin/findmnt /sys/firmware/efi/efivars >>>> /dev/null && /usr/bin/umount /sys/firmware/efi/efivars || true' >>> -ExecStop=/bin/sh -c 'echo -n optee-ta-bc50d971-d4c9-42c4-82cb- >>> 343fb7f37896 > /sys/bus/tee/drivers/optee-ftpm/unbind || true' >>> +ExecStop=/bin/sh -c 'for dev in /sys/bus/tee/devices/*; do case >>> "$dev" in *optee-ta-*) basename "$dev" > "$dev"/driver/unbind;; >>> esac done' >>>  ExecStop=/usr/bin/pkill tee-supplicant >>>   >>>  [Install] >> >> Would be nice to get this quickly merged as well, then we could drop >> all >> isar patches again downstream. >> > > The patch (as soon as another optee-client patch) are currently under > CI testing (together with 3rd version of HOST_ARCH* patchset which now > is OK with repro_test). If it passes OK (I expect by the end of the > day) the patches will be merged. > > If there are some problems, I'll then check them separately. > Great, thanks! Jan -- Siemens AG, Technology Linux Expert Center