From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6664521764891000832 X-Received: by 2002:a1c:2dcb:: with SMTP id t194mr682344wmt.8.1551716466205; Mon, 04 Mar 2019 08:21:06 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:400e:: with SMTP id n14ls1625801wrp.16.gmail; Mon, 04 Mar 2019 08:21:05 -0800 (PST) X-Google-Smtp-Source: APXvYqwViph2T2kdx6F2jTPx3oH3+L6U2BUB9nCyTc7XLSUhot5j3b75wcfVCcq9/8KS48WqIYnW X-Received: by 2002:adf:8182:: with SMTP id 2mr993112wra.14.1551716465728; Mon, 04 Mar 2019 08:21:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551716465; cv=none; d=google.com; s=arc-20160816; b=KiEKxyNTCtLLAXpFhrPyQsB/dqDj7UAQXPT8d1J6SJg0oG6xDWM5UUTX3OWKqLGQ4o vNCx7atpOROtCgiwZQZLTf1oAEeQPs/pDzdjGb4lANX1HhFbHq1ISlbDYpaJugZcQuln AE/rnESgyGwOlN6M5wPGm19IzF1KLWbNpGemzNv094N8iVTdpSyMtqNfYaJXaqiHZlFC 9pxTd6xu+BQfBQ0aprYrqr0LrbI3MgXcr4PK4w8/b/ZVYSotT180tCfsUx80JjQcUYr/ EOGRkCHbsYxbsPkTLVLaJwVEgQgsLNuJcg7EXYVg3FH7kM4OQlhgpxJ1sUrdKvftU7fu l0Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:cc:to:from:subject; bh=130T7Q7/wA8c6eozCtEuqKc2PMZt/DodJq7x8bwUCwo=; b=jH+4CMJepHN/c2tDmfiuEZHxyr5qOu8Hg6FmWHx+/VUNsHo9srUKGMyM9W9Rm3zLS0 Zdp/ZRhWN43ZmQpzld163+n/pikl1iDBGEr3xWudE4IgLkY92esWppzEPBEOQZR1ztaF vSu5qRDxiUjjTiJtsttVrmSBTObQo9GQA/f0pceVJ0BoPvX6hfPts04aSdkGQPiZEQN3 Do9xLtq5iUzXpo6giJ6lmzEVnnIQTee6K572YCPjUAZlH0w3HBAdlBZ56fYTvmHzU7O7 9OuA1olCd/KckV8iVaKyCPae5y/H5HVcAivD/LxTcC06vH8Kab6DfS/OKRmcxpo4mOia KsAQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id b8si336841wru.1.2019.03.04.08.21.05 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Mar 2019 08:21:05 -0800 (PST) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x24GL39A014974 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 4 Mar 2019 17:21:03 +0100 Received: from [139.25.69.232] (linux-ses-ext02.ppmd.siemens.net [139.25.69.232]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x24GL2Cx006151; Mon, 4 Mar 2019 17:21:03 +0100 Subject: Re: [PATCH v4 0/6] Python refactoring From: Claudius Heine To: isar-users@googlegroups.com Cc: Claudius Heine References: <20190304130801.20628-1-claudius.heine.ext@siemens.com> Message-ID: Date: Mon, 4 Mar 2019 17:21:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190304130801.20628-1-claudius.heine.ext@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: l1yBQ2vPhOHo Hi, On 04/03/2019 14.07, [ext] claudius.heine.ext@siemens.com wrote: > From: Claudius Heine > > Hi, > > I just took Haralds patchset + Maxims rebase and fixed it up. > > There was just a tiny change necessary, I added that in an additional patch. > It builds on my machine (qemuamd64) and I am currently testing it on isar-ci. Ok I run this patchset two times on the isar-ci now. The exact same commit id failed the first time after ~10 minutes [1] and will go green the second time [2] (Not completely finished yet, but it looks good so far after 1h50m.) We really should fix the nondeterminism in the CI. regards, Claudius [1] http://isar-build.org:8080/job/isar_claudius_ilbers-ci/22/ [2] http://isar-build.org:8080/job/isar_claudius_ilbers-ci/23/ > > If that is successful and review is ok, my patch can be merged into the > 'Remove all uses of subprocess.call(shell=True)' or left separately. > > regards, > Claudius > > Claudius Heine (1): > isar-bootstrap-helper: get_deb_host_arch: fix decoding > > Harald Seiler (5): > Remove all uses of subprocess.call(shell=True) > Use modern python formatting > image: Remove recursion in get_image_name > wic: Refactor fakeroot script > Fix python style > > .../example-module/example-module.bb | 8 ++- > meta/classes/base.bbclass | 70 ++++++++++++------- > meta/classes/image.bbclass | 22 ++++-- > meta/classes/isar-bootstrap-helper.bbclass | 8 +-- > meta/classes/isar-events.bbclass | 14 ++-- > meta/classes/patch.bbclass | 13 ++-- > meta/classes/wic-img.bbclass | 21 ++++-- > .../isar-bootstrap/isar-bootstrap-host.bb | 9 ++- > .../isar-bootstrap/isar-bootstrap-target.bb | 5 +- > .../isar-bootstrap/isar-bootstrap.inc | 12 ++-- > scripts/wic_fakeroot | 9 +-- > 11 files changed, 120 insertions(+), 71 deletions(-) > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de