public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Henning Schild <henning.schild@siemens.com>
Cc: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] Fix mounting of downloads dir into buildchroot
Date: Thu, 14 Jun 2018 10:43:52 +0200	[thread overview]
Message-ID: <a876a76f-2d4c-38e0-247b-1b59f62ef2a3@siemens.com> (raw)
In-Reply-To: <20180614104003.09186edc@md1pvb1c.ad001.siemens.net>

On 2018-06-14 10:40, Henning Schild wrote:
> Am Tue, 12 Jun 2018 23:35:48 +0200
> schrieb "[ext] Jan Kiszka" <jan.kiszka@siemens.com>:
> 
>> setup_root_file_system() mounts most of the required paths buildchroot
>> needs into its rootfs - except for the downloads dir. But do_build()
>> of dpkg-base cannot not detect this gap because it tests for isar-apt
>> being mounted.
>>
>> To close the gap without causing duplicate mounts, just add the
>> missing mount to the end of buildchroot do_build().
> 
> I am not sure i understand why you need that directory mounted in the
> first place. You build deps or recipe SRC_URI should provide you with
> everything you need.
> Can you please provide an example?

 - retrieval of git revision for the build (see also 9a8b7fe77cbd)
 - pushing recipe-private downloads into that folder (that is a special
   case, granted)

Jan

> 
> Henning
>  
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  meta/recipes-devtools/buildchroot/buildchroot.bb | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb
>> b/meta/recipes-devtools/buildchroot/buildchroot.bb index
>> 538c577..2ed5cf2 100644 ---
>> a/meta/recipes-devtools/buildchroot/buildchroot.bb +++
>> b/meta/recipes-devtools/buildchroot/buildchroot.bb @@ -78,4 +78,6 @@
>> do_build() { # Configure root filesystem
>>      sudo install -m 755 ${WORKDIR}/configscript.sh ${BUILDCHROOT_DIR}
>>      sudo chroot ${BUILDCHROOT_DIR} /configscript.sh
>> +
>> +    sudo mount --bind ${DL_DIR} ${BUILDCHROOT_DIR}/downloads
>>  }
> 


-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

  reply	other threads:[~2018-06-14  8:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12 21:35 Jan Kiszka
2018-06-14  8:40 ` Henning Schild
2018-06-14  8:43   ` Jan Kiszka [this message]
2018-06-14 11:15     ` Henning Schild
2018-06-14 12:09       ` Jan Kiszka
2018-06-14 13:10 ` Maxim Yu. Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a876a76f-2d4c-38e0-247b-1b59f62ef2a3@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox