From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6665957031077216256 X-Received: by 2002:a2e:391d:: with SMTP id g29mr1093503lja.17.1552057997616; Fri, 08 Mar 2019 07:13:17 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:750a:: with SMTP id y10ls906401lfe.6.gmail; Fri, 08 Mar 2019 07:13:17 -0800 (PST) X-Google-Smtp-Source: APXvYqxhhHBfWmXZUg0maffVIINe+M3yGldz5b/AFLrAytgl5Xz9UEOHd0zlEvq1wdGlaUYQor7Z X-Received: by 2002:a19:9503:: with SMTP id x3mr551747lfd.11.1552057996202; Fri, 08 Mar 2019 07:13:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1552057995; cv=none; d=google.com; s=arc-20160816; b=u4dzZHzrkx8CSde6wshVe18r8gSaRBBgHXOIw93OMSCjfgmOgnm3NJj1ZWrlde/eG/ vrY+mpXEbB9vCncKeBzOpfok3pQ20sjnfSJNVp3GKh1VhRaS3pyPrTxWFTpBhVVdDYv1 50tiIuBNww8risYV/OGZxf3JOe3KBLTp3f5Je3G4Cn37RUaASdEBKoxRpa9oDVryxMaD wCBBWPvvgNpmGJ0RSId4BBoCC0q0aiwKzDKtGqpPS+puq4lzVEspFGHxo6qXDM9IThLZ 6p855egevgxsRmyuaxFgAliJ+/oxbkRNqyxl20KXY54/5KmYFgBnKb+LkQW3P/n9UDCh jFAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=3U1b8bMJd7vhgdKsXX41x4TVOSABsuQbyUZJnd5XOf0=; b=rJwkouLJWhdSdD/3YikbsnTaJL/m/4uEkBwOVCIjD+EJg84JEO1gUJapAptvrA/MPT xaDurI6cfIO8CYWs+QZo6X+2bX3nF3plJKKThwFHMk16GZK5ugc4+PFhBEgqP2M4rb46 WNp5olABa2UgS1RUZ2d8I6TJQWLR1tQRyukGUsTKixIccTWXnqStDJMVTdXlhE2bBLVs t0Mck4yfkOTlJFtrMwdOwadjiMnT6DCS/nId9WRkBMe5Snq7g8osBVzuOctaWPse3LLM R+kHenJ5h8wINl2zAAtFNdsoZdqT0cSrZ5CqU0S7sBpjZgnxY2zG3CnZyioexuhBQgB6 YR2Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id f20si312336lfc.5.2019.03.08.07.13.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 07:13:15 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x28FDEDw024885 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Mar 2019 16:13:14 +0100 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x28FDDYU026626; Fri, 8 Mar 2019 16:13:13 +0100 Subject: Re: [PATCH] dpkg: acquire a read (shared) locks while building packages To: cedric_hombourger@mentor.com, isar-users References: <1552039053-1152-1-git-send-email-Cedric_Hombourger@mentor.com> <473ab398-0c28-00d9-5dd2-8caafb7dbf5f@siemens.com> <35924a2e-5207-453e-afa3-609478c5b4e1@googlegroups.com> From: Jan Kiszka Message-ID: Date: Fri, 8 Mar 2019 16:13:13 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <35924a2e-5207-453e-afa3-609478c5b4e1@googlegroups.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: 0oOAfk0B1sgf On 08.03.19 14:33, cedric_hombourger@mentor.com wrote: > > On Friday, March 8, 2019 at 11:04:12 AM UTC+1, Jan Kiszka wrote: > > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > > index 24b9fe3..f4e3d7a 100644 > > --- a/meta/classes/dpkg.bbclass > > +++ b/meta/classes/dpkg.bbclass > > @@ -19,5 +19,6 @@ do_install_builddeps[stamp-extra-info] = > "${DISTRO}-${DISTRO_ARCH}" > >   # Build package from sources using build script > >   dpkg_runbuild() { > >       E="${@ bb.utils.export_proxies(d)}" > > +    flock -s "${REPO_ISAR_DIR}/isar.lock" \ > >       sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} > /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH} > >   } > > > > Couldn't we have the same issue with dpkg-base derived classes? The kernel? Or > downstream classes? IOW, shouldn't this go to the caller of dpkg_runbuild? > > > I do understand the intent but I don't think we can do something like: > flock -s dpkg_runbuild > > is there another flock construct we could use to get around this? Likely true. We would need a construct that bitbake can parse while unrolling this function - not aware of any. > > I can update the patch to correct the typo in the commit log > Then let's also patch meta/recipes-kernel/linux/linux-custom.inc analogously and leave external dpkg_runbuild to downstream. Thanks, Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux