* [PATCH] expand-on-first-boot: Switched exit behavior
@ 2022-07-25 8:09 Tobias Schmidl
2022-07-25 12:43 ` Anton Mikanovich
0 siblings, 1 reply; 3+ messages in thread
From: Tobias Schmidl @ 2022-07-25 8:09 UTC (permalink / raw)
To: isar-users; +Cc: Tobias Schmidl
RemainAfterExit=yes lets systemd to assume that we are still active
after exiting the main process. This is definitively not the case for
expand-on-first-boot. Instead, we'll use the cgroup to determine if
every spwaned process has finished or not.
Signed-off-by: Tobias Schmidl <tobiasschmidl@siemens.com>
---
.../expand-on-first-boot/files/expand-on-first-boot.service | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service b/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
index cd063f3..7d4a2c7 100644
--- a/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
+++ b/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
@@ -14,7 +14,7 @@ ConditionFirstBoot=true
[Service]
Type=oneshot
-RemainAfterExit=yes
+ExitType=cgroup
ExecStart=/usr/share/expand-on-first-boot/expand-last-partition.sh
[Install]
--
2.36.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] expand-on-first-boot: Switched exit behavior
2022-07-25 8:09 [PATCH] expand-on-first-boot: Switched exit behavior Tobias Schmidl
@ 2022-07-25 12:43 ` Anton Mikanovich
2022-07-25 13:40 ` Schmidl, Tobias
0 siblings, 1 reply; 3+ messages in thread
From: Anton Mikanovich @ 2022-07-25 12:43 UTC (permalink / raw)
To: Tobias Schmidl, isar-users
25.07.2022 11:09, Tobias Schmidl wrote:
> RemainAfterExit=yes lets systemd to assume that we are still active
> after exiting the main process. This is definitively not the case for
> expand-on-first-boot. Instead, we'll use the cgroup to determine if
> every spwaned process has finished or not.
>
> Signed-off-by: Tobias Schmidl <tobiasschmidl@siemens.com>
> ---
> .../expand-on-first-boot/files/expand-on-first-boot.service | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service b/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
> index cd063f3..7d4a2c7 100644
> --- a/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
> +++ b/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
> @@ -14,7 +14,7 @@ ConditionFirstBoot=true
>
> [Service]
> Type=oneshot
> -RemainAfterExit=yes
> +ExitType=cgroup
> ExecStart=/usr/share/expand-on-first-boot/expand-last-partition.sh
>
> [Install]
Hello Tobias,
What commit does this change based on?
Looks like not the current next.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] expand-on-first-boot: Switched exit behavior
2022-07-25 12:43 ` Anton Mikanovich
@ 2022-07-25 13:40 ` Schmidl, Tobias
0 siblings, 0 replies; 3+ messages in thread
From: Schmidl, Tobias @ 2022-07-25 13:40 UTC (permalink / raw)
To: amikan, isar-users
Hi Anton,
Am Montag, dem 25.07.2022 um 15:43 +0300 schrieb Anton Mikanovich:
>
> Hello Tobias,
> What commit does this change based on?
> Looks like not the current next.
>
you're right, sorry for the inconvenience. It was based upon a pending
patch that has Felix' fix for /etc/machine-id as requirement. I'm rebasing
it now onto next and will repost it.
Kind regards,
Tobias
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-25 13:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-25 8:09 [PATCH] expand-on-first-boot: Switched exit behavior Tobias Schmidl
2022-07-25 12:43 ` Anton Mikanovich
2022-07-25 13:40 ` Schmidl, Tobias
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox