From: Claudius Heine <claudius.heine.ext@siemens.com>
To: Harald Seiler <hws@denx.de>, isar-users@googlegroups.com
Subject: Re: [PATCH 1/2] Fix all shell-script expansions
Date: Wed, 6 Feb 2019 11:08:23 +0100 [thread overview]
Message-ID: <a9c8da5f-be76-21ee-3c81-78f977f18b6e@siemens.com> (raw)
In-Reply-To: <bce0fd6f3d63e6de57a7552553121488740b1505.camel@denx.de>
On 06/02/2019 10.27, Harald Seiler wrote:
> Hi Claudius,
>
> On Wed, 2019-02-06 at 08:49 +0100, Claudius Heine wrote:
>> Hi Harald,
>>
>>
>> On 05/02/2019 14.00, Harald Seiler wrote:
>>> Expansions behave weirdly if paths contain special characters.
>>> This commit fixes expansions in all applicable shell-scripts.
>>>
>>> Signed-off-by: Harald Seiler <hws@denx.de>
>>> ---
>>> isar-init-build-env | 6 ++--
>>> meta-isar/conf/distro/raspbian-configscript.sh | 2 +-
>>> .../isar-bootstrap/files/chroot-setup.sh | 8 ++---
>>> meta/recipes-devtools/buildchroot/files/common.sh | 2 +-
>>> meta/recipes-kernel/linux/files/build-kernel.sh | 36 +++++++++++-----------
>>> .../enable-fsck/files/enable-fsck.sh | 4 +--
>>> .../files/expand-last-partition.sh | 16 +++++-----
>>> scripts/ci_build.sh | 14 ++++-----
>>> scripts/mount_chroot.sh | 12 ++++----
>>> scripts/rpm2cpio.sh | 4 +--
>>> 10 files changed, 52 insertions(+), 52 deletions(-)
>>
>> Great idea!
>>
>> I think you used shellcheck to find most of those issues. I think you
>> forgot one:
>>
>> In ./meta/recipes-kernel/linux-module/files/debian/postinst line 2:
>> depmod -a $(ls /lib/modules)
>> ^-- SC2046: Quote this to prevent word splitting.
>>
>> Maybe while you are at it, you could fix this one as well ;)
>
> Ah, I see ... I only checked files ending in .sh so I missed all
> postinst files ... I think I'll send another patchset for fixes in
> those + shell-scripts in recipes.
Great! There are also some shell scripts without `.sh` in the `scripts/`
directory.
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
next prev parent reply other threads:[~2019-02-06 10:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 13:00 [PATCH 0/2] Fix shell-scripts Harald Seiler
2019-02-05 13:00 ` [PATCH 1/2] Fix all shell-script expansions Harald Seiler
2019-02-06 7:49 ` Claudius Heine
2019-02-06 9:27 ` Harald Seiler
2019-02-06 10:08 ` Claudius Heine [this message]
2019-02-05 13:00 ` [PATCH 2/2] buildchroot: Fix not checking group Harald Seiler
2019-02-05 18:34 ` Henning Schild
2019-02-06 10:09 ` [PATCH 0/2] Fix shell-scripts Maxim Yu. Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9c8da5f-be76-21ee-3c81-78f977f18b6e@siemens.com \
--to=claudius.heine.ext@siemens.com \
--cc=hws@denx.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox