From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6654500580778573824 X-Received: by 2002:ac2:5396:: with SMTP id g22mr631208lfh.9.1549447707082; Wed, 06 Feb 2019 02:08:27 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:21d1:: with SMTP id h78-v6ls223238lji.1.gmail; Wed, 06 Feb 2019 02:08:26 -0800 (PST) X-Google-Smtp-Source: AHgI3Iam2lAN8VhHjyb/0B3040rD9jEQT7B+t8xXVCnY/jE8FuKlk+dcCDLNEhVx8sSqtQsoP7Yq X-Received: by 2002:a2e:42ce:: with SMTP id h75-v6mr617591ljf.27.1549447706599; Wed, 06 Feb 2019 02:08:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549447706; cv=none; d=google.com; s=arc-20160816; b=sv12YHRuH5I4rDYWOfCSTtQRFkY85G0aGzkrqmtwnX1h/6wJLBP6cudkSoH/8yNGcN ezyHr8jBEmuEkg91LLHRQ9iSeyk2x2QRJwE8m25z/oK5aZFPo/uEtmfAskYtE1yLKYjp FN7wWhnZreaYcz3wlCyDDVGxvQw1hH+3jSWTffF2h9aoO1y984VcEuQADWIXolmATV9O fElxc6v6V7/KqJOBI7IB6oF1TlPIYAo1exD/qjeClDXBLPhkpJqN7GjkekGXS4QPcPhq NbFv8RqMrdqO70O09PHo4I5vXr2zzObg7RM/mHbvyVoGHktg38XiH1XRVGVFu9fJq7Ld jRqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=2xTDomCfznBNbOPRXlR1heLvzCYMZCY0qzyu+77w0H0=; b=gOhEwbyi6tKrPPjrJg1ZJhCrB2AJsx0eMWHlMFfMYq9L170cSYYtWY28YAqNwjHU6r lTRafQUPAZpOQ3twCG8IU3kgucRq+9PMxFoOf/SkfhOqTCmSzJ7HbSuSMqQmnGF0oh8F NyP2AGoEAw5c4+y9TGUZV0weBv0qeBvhI+p4RRZBTclCCPhgWo0KkUruLlSHcVTH0IB5 asa4iarXrUTX86aepA1HZ5JRbhDaOwilqjMfhG4pNoCL6zgAVLvT1cM6xfwgcSNND6MJ 3A3zTSlDwwtebGbZFWP5raHLuyHigbqk676C0tAB+pMbHOFJt4OHv9ga7yPFDpjGD6/V PegA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id q10-v6si1165253lji.4.2019.02.06.02.08.26 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Feb 2019 02:08:26 -0800 (PST) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x16A8Ocp014706 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 6 Feb 2019 11:08:25 +0100 Received: from [139.25.69.181] (linux-ses-ext02.ppmd.siemens.net [139.25.69.181]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x16A8NQY001422; Wed, 6 Feb 2019 11:08:23 +0100 Subject: Re: [PATCH 1/2] Fix all shell-script expansions To: Harald Seiler , isar-users@googlegroups.com References: <20190205130004.15200-1-hws@denx.de> <20190205130004.15200-2-hws@denx.de> <639d7105-ec7f-d004-ffb3-2514eddb643b@siemens.com> From: Claudius Heine Message-ID: Date: Wed, 6 Feb 2019 11:08:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: X1nRGe6pR4VJ On 06/02/2019 10.27, Harald Seiler wrote: > Hi Claudius, > > On Wed, 2019-02-06 at 08:49 +0100, Claudius Heine wrote: >> Hi Harald, >> >> >> On 05/02/2019 14.00, Harald Seiler wrote: >>> Expansions behave weirdly if paths contain special characters. >>> This commit fixes expansions in all applicable shell-scripts. >>> >>> Signed-off-by: Harald Seiler >>> --- >>> isar-init-build-env | 6 ++-- >>> meta-isar/conf/distro/raspbian-configscript.sh | 2 +- >>> .../isar-bootstrap/files/chroot-setup.sh | 8 ++--- >>> meta/recipes-devtools/buildchroot/files/common.sh | 2 +- >>> meta/recipes-kernel/linux/files/build-kernel.sh | 36 +++++++++++----------- >>> .../enable-fsck/files/enable-fsck.sh | 4 +-- >>> .../files/expand-last-partition.sh | 16 +++++----- >>> scripts/ci_build.sh | 14 ++++----- >>> scripts/mount_chroot.sh | 12 ++++---- >>> scripts/rpm2cpio.sh | 4 +-- >>> 10 files changed, 52 insertions(+), 52 deletions(-) >> >> Great idea! >> >> I think you used shellcheck to find most of those issues. I think you >> forgot one: >> >> In ./meta/recipes-kernel/linux-module/files/debian/postinst line 2: >> depmod -a $(ls /lib/modules) >> ^-- SC2046: Quote this to prevent word splitting. >> >> Maybe while you are at it, you could fix this one as well ;) > > Ah, I see ... I only checked files ending in .sh so I missed all > postinst files ... I think I'll send another patchset for fixes in > those + shell-scripts in recipes. Great! There are also some shell scripts without `.sh` in the `scripts/` directory. -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de