public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Baurzhan Ismagulov <ibr@radix50.net>
To: isar-users@googlegroups.com
Cc: Anton Mikanovich <amikan@ilbers.de>,
	Uladzimir Bely <ubely@ilbers.de>,
	Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH v6 4/4] meta: Deploy DTBs once per kernel
Date: Wed, 18 Feb 2026 17:21:09 +0100	[thread overview]
Message-ID: <aZXm9bM3vhRuQDE4@abai.de> (raw)
In-Reply-To: <743de9ab-12f8-4e8d-b6b5-b3b8af1e7482@siemens.com>

On 2026-02-16 18:51, 'Jan Kiszka' via isar-users wrote:
> > Our use case is:
> > 1. Two images, same dtb name, same dtb contents.
> 
> Which is just the tip of this issue. Other layers deploy bootloader
> files or firmware binaries under the same name, overwriting things right
> now if two images are built under different names. And that overwriting
> sometimes triggers the infamous bitbake deployment errors.

Thanks for the detailed elaboration. If the contents are the same, v6 patch 4
would handle it. The "same name, different contents" case we couldn't identify
from the past threads and the downstreams we see, so we had left it for later
when it would actually occur (often the real cases are different from what one
anticipates).

If "same name, different contents" is already the case today, duplicating is
the only option.

I'm a bit surprised that the errors occur only sometimes -- we can reproduce
them reliably given the right mix of build targets.


> > 2. Downstream already has many deliverables.
> > 
> > My underlying question: Should we always duplicate, or should we at least try
> > to identify cases where we can avoid duplication? "Same file -- single
> > deployment".
> 
> How would you switch between de-duplicated and different artifacts by
> name then? How would imagers or other users find deployed artifacts in
> both cases?

Yes, that would depend on the contents and might be counter-intuitive at times.
Maybe duplicating and having the complete sets for every machine would be the
easiest to understand for the end users. We need to see how it works in
practice.


> > Patch 4 "deploy dtb once per kernel" associates the dtb with the recipe
> > producing it, reducing shuffling around in the image recipe. Yes, the kernel is
> > still deployed in the image which is inconsistent at this step; I'd be fine
> > doing that later.
> > 
> > We'll try playing with splitting by image. Even if we end up doing it at this
> > time, I'd still propose to explore the other options step by step.
> 
> Please not so many user-visible changes "step by step". We need a design
> that holds now, and we need one step to get there, at least when that
> step implies path changes that downstream layers need to adjust to.

I agree -- this was the goal of v6 patch 4 -- it doesn't change the path if it
is not necessary, and a similar kernel consolidation also wouldn't change the
path.


> I guess we should rather introduce the pattern of creating a subfolder
> ${IMAGE_FULLNAME} and put all those potentially colliding artifacts there.

We'll send v7 with duplication.


Currently, some artifacts are duplicated via file names. Since we already break
the API, we could touch them as well. Opinions welcome.

1. Before the change:

   mc:phyboard-mira-bookworm:isar-image-base

   phyboard-mira/imx6q-phytec-mira-rdk-nand.dtb                                  # bitbake conflict
   phyboard-mira/isar-image-base-debian-bookworm-phyboard-mira-initrd.img
   phyboard-mira/isar-image-base-debian-bookworm-phyboard-mira-vmlinuz

   mc:phyboard-mira-bookworm:isar-image-ci

   phyboard-mira/imx6q-phytec-mira-rdk-nand.dtb                                  # bitbake conflict
   phyboard-mira/isar-image-ci-debian-bookworm-phyboard-mira-initrd.img
   phyboard-mira/isar-image-ci-debian-bookworm-phyboard-mira-vmlinuz

2. After the duplication e.g.:

   phyboard-mira/debian-bookworm-isar-image-base/imx6q-phytec-mira-rdk-nand.dtb  # Same contents in our testcase
   phyboard-mira/debian-bookworm-isar-image-ci/imx6q-phytec-mira-rdk-nand.dtb    # Same contents in our testcase
   phyboard-mira/isar-image-base-debian-bookworm-phyboard-mira-initrd.img        # Currently not in the subdir
   phyboard-mira/isar-image-base-debian-bookworm-phyboard-mira-vmlinuz           # Currently not in the subdir
   phyboard-mira/isar-image-ci-debian-bookworm-phyboard-mira-initrd.img          # Currently not in the subdir
   phyboard-mira/isar-image-ci-debian-bookworm-phyboard-mira-vmlinuz             # Currently not in the subdir

   Or we could move the kernels and initrds into the subdir as well:

   phyboard-mira/debian-bookworm-isar-image-base/imx6q-phytec-mira-rdk-nand.dtb
   phyboard-mira/debian-bookworm-isar-image-base/initrd.img
   phyboard-mira/debian-bookworm-isar-image-base/vmlinuz
   phyboard-mira/debian-bookworm-isar-image-ci/imx6q-phytec-mira-rdk-nand.dtb
   phyboard-mira/debian-bookworm-isar-image-ci/initrd.img
   phyboard-mira/debian-bookworm-isar-image-ci/vmlinuz


With kind regards,
Baurzhan

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/aZXm9bM3vhRuQDE4%40abai.de.

  reply	other threads:[~2026-02-18 16:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13  7:40 [PATCH v6 0/4] Deploy DTBs with separate recipe Anton Mikanovich
2026-02-13  7:40 ` [PATCH v6 1/4] wic: Obtain real machine name in isoimage source plugin Anton Mikanovich
2026-02-13  7:40 ` [PATCH v6 2/4] testsuite: Add testcases to check dtb deployment Anton Mikanovich
2026-02-13  7:40 ` [PATCH v6 3/4] meta: Fix do_copy_boot_files error for different distros of same machine Anton Mikanovich
2026-02-13  7:40 ` [PATCH v6 4/4] meta: Deploy DTBs once per kernel Anton Mikanovich
2026-02-13  8:01   ` 'Jan Kiszka' via isar-users
2026-02-16 17:15     ` Baurzhan Ismagulov
2026-02-16 17:51       ` 'Jan Kiszka' via isar-users
2026-02-18 16:21         ` Baurzhan Ismagulov [this message]
2026-02-18 16:45           ` 'Jan Kiszka' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZXm9bM3vhRuQDE4@abai.de \
    --to=ibr@radix50.net \
    --cc=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    --cc=ubely@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox