public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH] meta-isar: example-module: Fix ISAR_CROSS_COMPILE setting
@ 2018-11-12  8:27 Jan Kiszka
  2018-11-14  3:16 ` Maxim Yu. Osipov
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2018-11-12  8:27 UTC (permalink / raw)
  To: isar-users

From: Jan Kiszka <jan.kiszka@siemens.com>

Make sure ISAR_CROSS_COMPILE is updated prior to inheriting buildchroot
indirectly via module.inc. Otherwise, setting it to 0 will come too
late.

Fixes: 301f52378052 ("meta-isar: example-module: Only disable cross-compilation for Debian kernels")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta-isar/recipes-kernel/example-module/example-module.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-isar/recipes-kernel/example-module/example-module.bb b/meta-isar/recipes-kernel/example-module/example-module.bb
index 996b5e2..b62ef65 100644
--- a/meta-isar/recipes-kernel/example-module/example-module.bb
+++ b/meta-isar/recipes-kernel/example-module/example-module.bb
@@ -5,8 +5,6 @@
 #
 # SPDX-License-Identifier: MIT
 
-include recipes-kernel/linux-module/module.inc
-
 # Cross-compilation is not supported for the default Debian kernels.
 # For example, package with kernel headers for ARM:
 #   linux-headers-armmp
@@ -17,6 +15,8 @@ python() {
         d.setVar('ISAR_CROSS_COMPILE', '0')
 }
 
+include recipes-kernel/linux-module/module.inc
+
 SRC_URI += "file://src"
 
 S = "${WORKDIR}/src"
-- 
2.16.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] meta-isar: example-module: Fix ISAR_CROSS_COMPILE setting
  2018-11-12  8:27 [PATCH] meta-isar: example-module: Fix ISAR_CROSS_COMPILE setting Jan Kiszka
@ 2018-11-14  3:16 ` Maxim Yu. Osipov
  0 siblings, 0 replies; 2+ messages in thread
From: Maxim Yu. Osipov @ 2018-11-14  3:16 UTC (permalink / raw)
  To: Jan Kiszka, isar-users

On 11/12/18 11:27 AM, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Make sure ISAR_CROSS_COMPILE is updated prior to inheriting buildchroot
> indirectly via module.inc. Otherwise, setting it to 0 will come too
> late.

Applied to the 'next',

Thanks,
Maxim.

> Fixes: 301f52378052 ("meta-isar: example-module: Only disable cross-compilation for Debian kernels")
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>   meta-isar/recipes-kernel/example-module/example-module.bb | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-isar/recipes-kernel/example-module/example-module.bb b/meta-isar/recipes-kernel/example-module/example-module.bb
> index 996b5e2..b62ef65 100644
> --- a/meta-isar/recipes-kernel/example-module/example-module.bb
> +++ b/meta-isar/recipes-kernel/example-module/example-module.bb
> @@ -5,8 +5,6 @@
>   #
>   # SPDX-License-Identifier: MIT
>   
> -include recipes-kernel/linux-module/module.inc
> -
>   # Cross-compilation is not supported for the default Debian kernels.
>   # For example, package with kernel headers for ARM:
>   #   linux-headers-armmp
> @@ -17,6 +15,8 @@ python() {
>           d.setVar('ISAR_CROSS_COMPILE', '0')
>   }
>   
> +include recipes-kernel/linux-module/module.inc
> +
>   SRC_URI += "file://src"
>   
>   S = "${WORKDIR}/src"
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-11-14  3:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-12  8:27 [PATCH] meta-isar: example-module: Fix ISAR_CROSS_COMPILE setting Jan Kiszka
2018-11-14  3:16 ` Maxim Yu. Osipov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox