From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6491554293275951104 X-Received: by 10.25.163.6 with SMTP id m6mr123387lfe.2.1513021525298; Mon, 11 Dec 2017 11:45:25 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.25.90.201 with SMTP id y70ls179023lfk.8.gmail; Mon, 11 Dec 2017 11:45:24 -0800 (PST) X-Google-Smtp-Source: ACJfBotEnRXR3Gz/lcam45mtvrawJE0MVhDjVhJKZZ6RKItC6QDOS4MzKCiVNR3dI94jJkHEIJUo X-Received: by 10.46.86.214 with SMTP id k83mr144522lje.37.1513021524648; Mon, 11 Dec 2017 11:45:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513021524; cv=none; d=google.com; s=arc-20160816; b=ydVxxVP2CDykA6FCRwBebDuEwisWrduigwlnnAs9aHW8VlO536Ie7PjShJwaodRm1r SNUgmZ+wCd7y8XrDbBSMujxuiuXf1rmWqiPL6Nv0aOtL0VyHBrlNkFzijqc83nC68Js5 dIvFzmCDQMHbMyHrXWeJ1YiGTvYte2pu9Ps2ziH4HkdTdFAaCsi6EK/qxtx7EZSDw30E 32Z1R/e6MMrsFU3/WC2gxKGSb0Yq0JJQlKoB9S6MyuPxtVwOGnBdXXJs7GF/BqdxamJC dY447xiPJUZuJ5aJg7Apz2T4QirVhuKWW++VDJHdEw5v+Q2lMlBKxDDYLiNyRKGl+cVV Zlzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=50tqnZPtM5lFDKHXZKGkozOzlLE50UAUKyifYZh2nCA=; b=nCkgcO3g20saUEg0CJjB8qswRrzh2dEDHHkJqEGbYwcgRYrrART7f8neUuIhh9KFHi ttlbGzrp+d6OI5wgOWrQojqR4V13RWS6jE+9HWf2xU/L0v9nErmJFa2INLKbkuc5xg4P No1FzgPVUQkgOhTJ2bl/XQHSPSQ5VvP0CBXd9VAz2tj8Txxsm3PBdDwkycV48ECU55fq frM/hx6nwZXrJLONvXrYy174OeS8+uOAl+iojIjuBoIWL2jmaXVBTIdWSWLBHPuk50bD fs6QTxlZCp1XzYbsgt+mxNcwRBBUSXJbR88vEBNfNkYZjyHPHoPUQvoz4N1buvc3ZJs7 /snQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id q27si1478079lfd.0.2017.12.11.11.45.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Dec 2017 11:45:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id vBBJjKmh025262 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 11 Dec 2017 20:45:22 +0100 Subject: Re: [PATCH v3 4/4] dpkg-base: Update git alternates To: Henning Schild Cc: isar-users@googlegroups.com References: <20171126220025.14168-1-asmirnov@ilbers.de> <20171126220025.14168-5-asmirnov@ilbers.de> <20171211185646.02ca7be5@md1pvb1c> From: Alexander Smirnov Message-ID: Date: Mon, 11 Dec 2017 22:45:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171211185646.02ca7be5@md1pvb1c> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: UlRZmwTiQ+pr On 12/11/2017 08:56 PM, Henning Schild wrote: > Well i thought about this again. This is a very nasty workaround for a > problem this actually is in bitbake. That's an attempt to solve here and now git-3.0 issue reported by Christian. So if in general it's not critical problem for now, I could drop this series. > > https://github.com/openembedded/bitbake/blob/ebce92bf8d71f8a6e8af1c6cf6ba335faf9d67c8/lib/bb/fetch2/git.py#L179 > > That problem should be fixed in bitbake, if they accept patches. The > "-s" needs to depend on some condition. > I'm not sure that this is the best solution. The main idea of using '-s' was to avoid unnecessary copying of git repos within one build, it costs disk space and extra time for copying (for example linux.git is about 1GB). So usage of '-s' is quite reasonable here. Another solution could be deprecate 'downloads' directory and fetch gits directly to package WORKDIR. > For Isar i would tell people to fetch tarballs from git servers and > avoid git://. This should not be the requirement, because it limits Isar application area. Not all git repo could be fetched as tarball. Alex > > Henning > > Am Mon, 27 Nov 2017 01:00:25 +0300 > schrieb Alexander Smirnov : > >> Update git alternates to work in buildchroot. >> >> Signed-off-by: Alexander Smirnov >> --- >> meta/classes/dpkg-base.bbclass | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/meta/classes/dpkg-base.bbclass >> b/meta/classes/dpkg-base.bbclass index 5d7f8b6..6a78a26 100644 >> --- a/meta/classes/dpkg-base.bbclass >> +++ b/meta/classes/dpkg-base.bbclass >> @@ -18,12 +18,24 @@ dpkg_runbuild() { >> >> # Wrap the function dpkg_runbuild with the bind mount for buildroot >> do_build() { >> + if [ -d ${WORKDIR}/git/.git ]; then >> + OBJ_PATH=$(cat ${WORKDIR}/git/.git/objects/info/alternates) >> + REPO_PATH=$(dirname $OBJ_PATH) >> + REPO_NAME=$(basename $REPO_PATH) >> + echo "/git/$REPO_NAME/objects" > >> ${WORKDIR}/git/.git/objects/info/alternates >> + fi >> + >> mkdir -p ${BUILDROOT} >> sudo mount --bind ${WORKDIR} ${BUILDROOT} >> _do_build_cleanup() { >> ret=$? >> sudo umount ${BUILDROOT} 2>/dev/null || true >> sudo rmdir ${BUILDROOT} 2>/dev/null || true >> + >> + if [ -d ${WORKDIR}/git/.git ]; then >> + echo $OBJ_PATH > >> ${WORKDIR}/git/.git/objects/info/alternates >> + fi >> + >> (exit $ret) || sudo umount ${BUILDCHROOT_DIR}/git >> (exit $ret) || bb_exit_handler >> } > -- With best regards, Alexander Smirnov ilbers GmbH Baierbrunner Str. 28c D-81379 Munich +49 (89) 122 67 24-0 http://ilbers.de/ Commercial register Munich, HRB 214197 General manager: Baurzhan Ismagulov