On Wednesday, June 19, 2024 at 12:27:11 PM UTC+8 Jan Kiszka wrote:
On 19.06.24 05:04, 'Liu Yi' via isar-users wrote:
> The variable image_rootfs_dir will not be correctly defined if missing import of get_bitbake_var func.
>
> Signed-off-by: Liu Yi <li...@siemens.com>
> ---
> meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py b/meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py
> index 7dde49d4..5611f93a 100644
> --- a/meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py
> +++ b/meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py
> @@ -20,7 +20,7 @@ import os
>
> from wic import WicError
> from wic.plugins.source.rootfs import RootfsPlugin
> -from wic.misc import exec_cmd
> +from wic.misc import get_bitbake_var, exec_cmd
>
> logger = logging.getLogger('wic')
>
Interesting. The code was like that since its beginning 6 years ago. How
did you trigger the issue? Maybe you can augment the commit message with
this information. Otherwise:
Reviewed-by: Jan Kiszka <jan.k...@siemens.com>
Thanks,
Jan
--
Siemens AG, Technology
Linux Expert Center