From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7382045015631986688 Date: Tue, 18 Jun 2024 23:55:17 -0700 (PDT) From: Yi Liu To: isar-users Message-Id: In-Reply-To: References: <20240619030440.1858-1-liuyi@siemens.com> Subject: Re: [PATCH] rootfs-u-boot: add missing import get_bitbake_var MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_46107_197802940.1718780117496" X-TUID: c760HjZ2cRbX ------=_Part_46107_197802940.1718780117496 Content-Type: multipart/alternative; boundary="----=_Part_46108_2062818182.1718780117496" ------=_Part_46108_2062818182.1718780117496 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable This issue was found by my VSCode, which hinted that some error there when= =20 I went through this python file. Best Regards, Liu Yi=20 On Wednesday, June 19, 2024 at 12:27:11=E2=80=AFPM UTC+8 Jan Kiszka wrote: On 19.06.24 05:04, 'Liu Yi' via isar-users wrote:=20 > The variable image_rootfs_dir will not be correctly defined if missing=20 import of get_bitbake_var func.=20 >=20 > Signed-off-by: Liu Yi =20 > ---=20 > meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py | 2 +-=20 > 1 file changed, 1 insertion(+), 1 deletion(-)=20 >=20 > diff --git a/meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py=20 b/meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py=20 > index 7dde49d4..5611f93a 100644=20 > --- a/meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py=20 > +++ b/meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py=20 > @@ -20,7 +20,7 @@ import os=20 >=20 > from wic import WicError=20 > from wic.plugins.source.rootfs import RootfsPlugin=20 > -from wic.misc import exec_cmd=20 > +from wic.misc import get_bitbake_var, exec_cmd=20 >=20 > logger =3D logging.getLogger('wic')=20 >=20 Interesting. The code was like that since its beginning 6 years ago. How=20 did you trigger the issue? Maybe you can augment the commit message with=20 this information. Otherwise:=20 Reviewed-by: Jan Kiszka =20 Thanks,=20 Jan=20 --=20 Siemens AG, Technology=20 Linux Expert Center=20 ------=_Part_46108_2062818182.1718780117496 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable This issue was found by my VSCode, which hinted that some error there when = I went through this python file.

Best Regards,
Liu Yi=C2=A0

On Wednesday, June 19, 20= 24 at 12:27:11=E2=80=AFPM UTC+8 Jan Kiszka wrote:
On 19.06.24 05:04, 'Liu Yi' via isar-users wrote:
> The variable image_rootfs_dir will not be correctly defined if m= issing import of get_bitbake_var func.
>=20
> Signed-off-by: Liu Yi <li...@si= emens.com>
> ---
> meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/meta/scripts/lib/wic/plugins/source/rootfs-u-boot.p= y b/meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py
> index 7dde49d4..5611f93a 100644
> --- a/meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py
> +++ b/meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py
> @@ -20,7 +20,7 @@ import os
> =20
> from wic import WicError
> from wic.plugins.source.rootfs import RootfsPlugin
> -from wic.misc import exec_cmd
> +from wic.misc import get_bitbake_var, exec_cmd
> =20
> logger =3D logging.getLogger('wic')
> =20

Interesting. The code was like that since its beginning 6 years ago. = How
did you trigger the issue? Maybe you can augment the commit message w= ith
this information. Otherwise:

Reviewed-by: Jan Kiszka <jan.k...@si= emens.com>

Thanks,
Jan

--=20
Siemens AG, Technology
Linux Expert Center

------=_Part_46108_2062818182.1718780117496-- ------=_Part_46107_197802940.1718780117496--