From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7176574728906211328 X-Received: by 2002:aa7:9911:0:b0:576:796e:8128 with SMTP id z17-20020aa79911000000b00576796e8128mr29745264pff.68.1671564971166; Tue, 20 Dec 2022 11:36:11 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:902:e311:b0:186:af8a:6095 with SMTP id q17-20020a170902e31100b00186af8a6095ls14434386plc.4.-pod-prod-gmail; Tue, 20 Dec 2022 11:36:10 -0800 (PST) X-Google-Smtp-Source: AA0mqf6vmfRWbkEuS6ly29I6/so+xbdWQ0Qh1pULFZYrH7N/Lwd20pbWF7mxMKUEoA3//m/E4OLP X-Received: by 2002:a17:90b:8b:b0:219:aec6:ff93 with SMTP id bb11-20020a17090b008b00b00219aec6ff93mr50470557pjb.32.1671564970239; Tue, 20 Dec 2022 11:36:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671564970; cv=none; d=google.com; s=arc-20160816; b=CdmdetBJRE69LhZ7FhY17zgFV26DsrWFI3sElGxHG15g/pIpL/oGH8dxMDSkD7L/gv n3D/z3U0xLJPp5/iT3xQLOEXAoyjG7NHP+ho8eMhD9fIaMiXywqJz2qIziRgwmnm6UGv pPCDPrwf3p+QI5gIFhI9KNOxZWkYBJihw2pk3u8vfiYVDr8GK1CYsGSv1qIuRaXYDXbS M5HFCGZFosb8XF3hvJAh3VeNEF3Na9byW2I17CeiNHiNcUCBe6VH2KN5+fwf1miZ3haC eFdsUqXOY96X2ub/CNO/982H10je2bTP5EW4TzqrouR6t5rtVM4JQucaFfM/MqaLJZ/k /lqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id; bh=MnF5ptw0R42l/4k8g9n8BpO3z0kTr2m9dVVzvbKmpZg=; b=c7k/GKT3p7/Igy7cNBVZa+cdLXDQivqQckUpeszRZ/pFyI/MIEkGQTvLiJiP56nQac 3KhS8s+dFXkvokP8XlQZSP1djwZzvn85Fd3QTdOzuAinWYD7u0LDUnFVkxzHiFUrzPlH vRIlHxhDLCjRmQIAZnAtjQ03jn0TddLwchGQpmERGXFghXIJwBtOVDMakdaJWa3IngJt 467FWly9Rs5omhc70zdzdWPyhCGBtTUBhW25iFJN5PfAAe9ON/RQ4QvG6pDdbgkuhc+i KXTB/iC0/mwCudHcEcWLLHPbdhmXpEsSrSLso8v+7ooq/ONgXtwuzzSawVYT2oqfcHkM xEWg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id lt2-20020a17090b354200b00219c8920cd0si165173pjb.0.2022.12.20.11.36.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Dec 2022 11:36:09 -0800 (PST) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 2BKJa3nT002609 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Dec 2022 20:36:06 +0100 Message-ID: Date: Tue, 20 Dec 2022 22:36:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v6 0/6] expand-on-first-boot btrfs and CI testing Content-Language: en-US To: henning.schild@siemens.com, isar-users@googlegroups.com References: <20221215221606.5623-1-henning.schild@siemens.com> From: Anton Mikanovich In-Reply-To: <20221215221606.5623-1-henning.schild@siemens.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: R5TiB1w+0R1k 16.12.2022 01:16, henning.schild@siemens.com wrote: > From: Henning Schild > > changes since v5: > - drop dead code around mktemp subshell > - revert cosmetic mktemp stuff back to v3 > - remove "Suggested-by" tag to hopefully improve signal to noise ratio > in review process > > changes since v4: > - cosmetic fix in the way we call mktemp > - add a patch that makes sure the service is run only once, also on > error > - bump package version after changes are done > > changes since v3: > - rebased on "expand-on-first-boot: switch back away from systemd-growfs" > - implement btrfs resizing and CI testing it > - put the padding wks entry into an include > > changes since v2: > - add python namespace prefix for the bitbake get functions > - install only in images that use WKS_FILEs that have the "gap" > > changes since v1: > - complete rewrite to not focus only on the tests but rather the > feature for all examples > > This first was only about testing but meanwhile has a focus on enabling > the expand feature in all example images anyhow, and later look for > traces of that happening in CI test where we can. > We install the application in any image and in the wic images add some > scratch space at the end. That will enable improved interactive use of > all those wic images, so makes sense apart from any testing. > Later use the log reading feature of the qemu tests to look for traces > of successful resizing for non ubuntu images. In ubuntu the > console_loglevel is not verbose enough to find traces. > > Henning Schild (6): > expand-on-first-boot: really only do that once, especially on failure > expand-on-first-boot: support resizing a btrfs > meta-isar: introduce an example to use btrfs > CI: improve cibuilder readability > meta-isar: install expand-on-first-boot in most images and add space > CI: expect a message about filesystem resize vom expand script > > meta-isar/conf/machine/qemuamd64.conf | 6 ++++ > meta-isar/conf/machine/virtualbox.conf | 1 + > meta-isar/conf/machine/vmware.conf | 1 + > .../conf/multiconfig/qemuarm-bookworm.conf | 1 + > .../lib/wic/canned-wks/expand-padding.wks.inc | 5 +++ > .../lib/wic/canned-wks/sdimage-efi-btrfs.wks | 11 +++++++ > .../lib/wic/canned-wks/sdimage-efi-sd.wks | 2 ++ > .../lib/wic/canned-wks/sdimage-efi.wks | 2 ++ > ...oot_1.3.bb => expand-on-first-boot_1.4.bb} | 0 > .../files/expand-last-partition.sh | 31 ++++++++++++++++--- > .../files/expand-on-first-boot.service | 1 + > testsuite/cibuilder.py | 28 ++++++++++++++--- > 12 files changed, 80 insertions(+), 9 deletions(-) > create mode 100644 meta-isar/scripts/lib/wic/canned-wks/expand-padding.wks.inc > create mode 100644 meta-isar/scripts/lib/wic/canned-wks/sdimage-efi-btrfs.wks > rename meta/recipes-support/expand-on-first-boot/{expand-on-first-boot_1.3.bb => expand-on-first-boot_1.4.bb} (100%) > Hello Henning, This patchset look really good, but still fails on arm-bookworm startvm test of our fast CI. The issue can be reproduced by just building qemuarm-bookworm target with bitbake (even outside testsuite) and then execute VmBootTestFast.test_arm_bookworm test case. So my proposal is to apply revert expand commit now without waiting for this patchset to be ready.