From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7136477983660834816 X-Received: by 2002:a05:600c:410d:b0:3a6:1db8:b419 with SMTP id j13-20020a05600c410d00b003a61db8b419mr5669403wmi.119.1662048492096; Thu, 01 Sep 2022 09:08:12 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:6018:b0:3a8:3c9f:7e90 with SMTP id az24-20020a05600c601800b003a83c9f7e90ls1854750wmb.1.-pod-canary-gmail; Thu, 01 Sep 2022 09:08:10 -0700 (PDT) X-Google-Smtp-Source: AA6agR7k85aLg5J3zsKtq5cIEsz4CD7YTsiDx+K6hv8b1Dva8EUd/E1ngfSapFNk1PlBpmzdEIpw X-Received: by 2002:a05:600c:4f05:b0:3a5:ffec:b6b with SMTP id l5-20020a05600c4f0500b003a5ffec0b6bmr5596409wmq.199.1662048490732; Thu, 01 Sep 2022 09:08:10 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1662048490; cv=pass; d=google.com; s=arc-20160816; b=Sd40PsJTGCks8Cwo1O0u5uN6yPmX/ktALhFIp9j84+9pLiCkXijMtIasOV2CUXvcvo bbNpKzrzp6xMOQ4U1++gZs9CcuupwwRPevUJAss+VvYnPLClL1G4ZAepTuMp9gR6gqR8 kryTm2tYqw+GQSwpb+PLR9+cR7DgM9kw59ICUJwLHBlr2lITqhoy1RevbEJp8guByygq CAWEryI1fvMVv9T9Gi6WSfKGkf8TVyKWvkde1VG+nijct9UjBc+O1Y3ZlmUjkqS0pHKM XBhFRA68bCDB7w20pRZwmMfSO+eOxim8Wx4aqHxFlcDNIBss6bW+KuDdYY2HgN0MYUGa OZQw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=MsvggHoI5KjOW892BJo4Gfuww9lMVECXCPN6n8aQBlE=; b=Sdiw1bVQt9Vj8O+eRtYPE1xgr6ou+GBhxpi3Uq/kJC/aO1X8uBK2CiRFX/2EaK2NKF utAWsviO5/kCwDLC5xV+VyV+IcOUbkVg9lK2l0w0NXWQsb1uYSX9zO4jooFbsT5ufYzt odtKM9mqACRBRvGAwOjow/WGuHJdx7KLRuTcE3eFuvhyLzvRQg6FYXhiaXRXdcUjFhiX 5QAZs971Ygs79bUyJotgUGNtekq3oPBhgvEBsPEX/ZZwSEju1yiun495qmG62WIKLSSi fZiSWun28pR/WSsYJ4rkd9OV7TxUq5cXog8slXFzKdG8QJgxhOlqpyh1CHJ/bcnPP8NU 4ZuA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="gb1/bPr7"; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.22.85 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2085.outbound.protection.outlook.com. [40.107.22.85]) by gmr-mx.google.com with ESMTPS id n20-20020a05600c501400b003a5b20f80f5si322164wmr.1.2022.09.01.09.08.10 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Sep 2022 09:08:10 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.22.85 as permitted sender) client-ip=40.107.22.85; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="gb1/bPr7"; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.22.85 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iyZhURsnHub7gU5j1DV4wRXahkQQyRFSqIKVC98wU6PhOicXKE0uWkhfGtP8A+VMqOuZS73S/w46XbtZFTRl1szy8sN4fik+hF4qnUPX25I3dlaOO2QcqQPbFprhEP7iSfVoVLHKoFmKmmdGqtF1soPXYgUXSsBE46Xwt8hhV4J76bnE4BVLclRmPKdJXaJ0JoA66XXMoiFQEgNqf9OU02AOW2ihanbXYnJzDrvI2BG9mHRrecMWT5nxc/DnfWKAt56k10RffoFmxqkA7uL9GRFPx2FDkkyfE2wZwGrNq6BFpPjFDN1g0cWZREAgYuxgcOUwAFXoUeveG5YTw3nhpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MsvggHoI5KjOW892BJo4Gfuww9lMVECXCPN6n8aQBlE=; b=OIJtxn/XAF08P6c7L53xZfcZWdByYy8+dpdIanHT7PFGxHD9uqdeeuAPDl4BKNVMRzwcfhaYdkNvlYvp+Y3vDBzpJYxvqfYKMSBQyB7mGAGc8VrXx6iq74u856+Onlx4C6jiUrvf4XkQ6HxBQYWon4pmeRVfxbmbHiMHewhyYrDB2c/aAz9eNn2hAJWJrYrBAlnmiK5UGckTS8XB/hBFUbshIWa6e60lWt7bMuA3Ayjo3G/JLbhJgfnI1PrG16o6T1kfKWWj5LkJHbs8nw3mTgtiCH3Yw89WbhaN9wcLXbyuykywAKwPi3v+D8a08AqwzIfLcTSmL8auZGtu2kRwlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.75) smtp.rcpttodomain=googlegroups.com smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MsvggHoI5KjOW892BJo4Gfuww9lMVECXCPN6n8aQBlE=; b=gb1/bPr7dZvfVfKpu6dc2U8wh7dm8IoFAc3pu0a7lr4YqRc5bh0junX7yuIiYbLAqHk4GhMCZXdV9HQFKbz/YnGGs2LRxI0c+oHHw4bIpov/OzwLxLFZ4g/BhnUJkbEJFf47jnoHKWcGfUIvCfbiaFQvnwiNUoN84kmpUcJIaT/+hxv1phne+6LG3dlTW7MH+eL3LwDxGRLeBNlUuY7wmKylZyEkFYJUw6CkIbbPo9MG1kZRtxkSqV869dscaiNmgeytVhbpM2qSF91nCWpnwtVkAi86GSmSgKTI1ka95CSXo7Lf+qvBtX9Dnpw0wsa/OXfDnOPNeVEVWj4cKFoRBQ== Received: from DB7PR03CA0090.eurprd03.prod.outlook.com (2603:10a6:10:72::31) by AM0PR10MB3506.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:145::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 16:08:10 +0000 Received: from DB5EUR01FT033.eop-EUR01.prod.protection.outlook.com (2603:10a6:10:72:cafe::4f) by DB7PR03CA0090.outlook.office365.com (2603:10a6:10:72::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.13 via Frontend Transport; Thu, 1 Sep 2022 16:08:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.75) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.75 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.75; helo=hybrid.siemens.com; pr=C Received: from hybrid.siemens.com (194.138.21.75) by DB5EUR01FT033.mail.protection.outlook.com (10.152.4.248) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 16:08:09 +0000 Received: from DEMCHDC89XA.ad011.siemens.net (139.25.226.103) by DEMCHDC8VRA.ad011.siemens.net (194.138.21.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.12; Thu, 1 Sep 2022 18:08:09 +0200 Received: from [139.25.68.37] (139.25.68.37) by DEMCHDC89XA.ad011.siemens.net (139.25.226.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.9; Thu, 1 Sep 2022 18:08:09 +0200 Message-ID: Date: Thu, 1 Sep 2022 18:08:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 2/3] linux-module: honor modules Makefile Content-Language: en-US To: Henning Schild , CC: Pingfang Liao , Florian Bezdeka References: <20220827085905.6116-1-henning.schild@siemens.com> <20220827085905.6116-2-henning.schild@siemens.com> From: Jan Kiszka In-Reply-To: <20220827085905.6116-2-henning.schild@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [139.25.68.37] X-ClientProxiedBy: DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) To DEMCHDC89XA.ad011.siemens.net (139.25.226.103) X-TM-AS-Product-Ver: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-AS-Result: No-10--15.054000-8.000000 X-TMASE-MatchedRID: Fi1yTWlF5J85QaOxwNGfvo9bHfxDWoibXO5VFRptCqkK4MBRf7I7pgGo 1vhC/pWjLX3qyf3ewG/8XV/JQ2P2yp4bMrpTjTaQB6v+5gVW3HJPEtzipOABjKchFrOB9kanP6T ki+9nU38HZBaLwEXlKL6pxbTOjavyq5ewd0UPS9hrmmdBZjXYSD22DJ5ViWw/4gzXelDC6SwCn5 QffvZFlT+B/tp8itBTTkg03ybTpsjNwwTsLpftyw+Oi0Ldhbf9NO5dlFRJNAZuXgIqq6mQyvRU+ 9PTPHSYhz0lzsrxmqajxYyRBa/qJQPTK4qtAgwIAYt5KiTiutkLbigRnpKlKSBuGJWwgxAra7le oU/OMhNYsCaawSIuKci9wW2rqyBUx8nlPW1oCkJitcRtWgEzIlYlMkD/kMTRftwZ3X11IV0= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--15.054000-8.000000 X-TMASE-Version: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-SNTS-SMTP: 5223105543D814E7E95FEF4B3DA37AEB7A3010F0A082D91381538CFBEFF0BBC12000:8 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8d096c76-94d2-4c39-439c-08da8c342a2a X-MS-TrafficTypeDiagnostic: AM0PR10MB3506:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YrJfNsGhmo7Rd6Zif/8kY5Dde4hFkgvpCl0bmBmNFgsMEdF0eSyKUl24Ua3WeyevNznCs9OuNo0RXkcKDmyQP+5NA8l85GkRkkSxKrSX/7FPctXglZFDFNYohOGAOfPtNtG8QzIJCS5bMh88M+UW46F2FzBfN3SAPB/hpHzjOQl0QCHUvMRChxIuj4P/aVyCIqyT6uuZrsIr8jYoqQ/M7SizlUr35a6Mh/6vhLLg4wDzYmh5TxhKKI/E9VS2pfCTppijWYxX6mCuZwuQ4ci2ZjJIFEHPlAVw/ynB/5tVD4fhIi5zfoLjSk1ZAHWyxyfNvUtzEPQSvLKYIsfcwFAIMme8bRsAJuO+4p2TpKrFzLY8kXigLmU82HX/hLTcG2Mau84GrRpFJBEkIDXaRtt3AKYZsn6xr9TBbhEFaTBowg0A3rgLjFpEI7g1D2t/5CTWizqOAK+VT7Fw78yokeL7K0H8X55crMz795S+BH9n4NhjgjG2lJUnh7cG8IAEtSn8hi1e6LDmMvq9pOqOMcVcELcH3Zlc+kq8xb88cSIQ/Rv9khd+2SEJdJot5UyBMbhg4eUVG71D72t30rceDa+FlNs9217Zp6QqCkk+qgLUOSUmBcHufPooowZJglk7s+YhlTKspRYAbv+j2+UTF2Ep33OQXCwogWS8HS15iDBABk1FSC9l+IiNeYybT7vdos3ACXJLSTAulMk80a92zqw8axkXF5PeaaHxugC0HCIQArkwD7hg5zAV+YMdiXzhbOsVsvLF7+up4hus2mvdCwjmO5U1sP58KzzEcCQSoPVGT1XLo1n9IFYrHc+8UmiuowzNPZX8dLIZ+AU7oXYc7QtN8B72ryKkKVLLZnHilNYBnpA= X-Forefront-Antispam-Report: CIP:194.138.21.75;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(39860400002)(396003)(346002)(46966006)(40470700004)(36840700001)(82740400003)(16576012)(2906002)(70586007)(86362001)(8676002)(4326008)(70206006)(31696002)(81166007)(356005)(82960400001)(316002)(40460700003)(26005)(16526019)(54906003)(336012)(110136005)(6706004)(956004)(44832011)(2616005)(186003)(83380400001)(5660300002)(53546011)(47076005)(82310400005)(36860700001)(478600001)(41300700001)(107886003)(31686004)(8936002)(36756003)(40480700001)(3940600001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 16:08:09.9166 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8d096c76-94d2-4c39-439c-08da8c342a2a X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.75];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR01FT033.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB3506 X-TUID: V8+0mDUAb6WK On 27.08.22 10:59, Henning Schild wrote: > External modules might have their own appends and target definitions in > their Makefile. All we need to give them is the target name and KDIR, > not dive into KDIR right away. My observation with external modules makefile having their own rules is that they generally also have their own KDIR variables. There is no standard way of telling those pick up the kernel from a standard place and install it at the standard location. > > Signed-off-by: Henning Schild > --- > meta/recipes-kernel/linux-module/files/debian/rules.tmpl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/meta/recipes-kernel/linux-module/files/debian/rules.tmpl b/meta/recipes-kernel/linux-module/files/debian/rules.tmpl > index d3bd7dc30f21..0d16186b5ff3 100755 > --- a/meta/recipes-kernel/linux-module/files/debian/rules.tmpl > +++ b/meta/recipes-kernel/linux-module/files/debian/rules.tmpl > @@ -48,13 +48,13 @@ KDIR := $(shell dpkg -L $(KERNEL_DEP) | grep "/lib/modules/.*/build") > endif > > override_dh_auto_clean: > - $(MAKE) -C $(KDIR) M=$(PWD) clean > + $(MAKE) KDIR=$(KDIR) clean > > override_dh_auto_build: > - $(MAKE) -C $(KDIR) M=$(PWD) modules > + $(MAKE) KDIR=$(KDIR) modules > > override_dh_auto_install: > - $(MAKE) -C $(KDIR) M=$(PWD) INSTALL_MOD_PATH=$(PWD)/debian/${PN} modules_install > + $(MAKE) KDIR=$(KDIR) INSTALL_MOD_PATH=$(PWD)/debian/${PN} modules_install > > %: > CFLAGS= LDFLAGS= dh $@ --parallel This breaks existing users with makefile that are unusable or do not have own rules. I would refrain from that breakage. If you have a more complex case than what we support, you can simply provide your own rules and can then even account for the other specialties that usually come with such module makefiles. Same arguing applies to patch 3. Jan -- Siemens AG, Technology Competence Center Embedded Linux