Re: [PATCH 2/2] dpkg-source: Build source package only once

[Jan Kiszka <jan.kiszka@siemens.com>]

On 06.05.24 08:29, Schmidt, Adriaan (T CED EDC-DE) wrote:
> Kiszka, Jan, Sonntag, 5. Mai 2024 22:33:
>> Avoid building the source package multiple times, possibly even
>> inconsistently. This is achieved by delegating this task to to the base
>> package and installing the source package from isar-apt in the native
>> and compat package variants.
> 
> Hi Jan,
> 
> I thought about changes along those lines a while back, and had two problems
> that made this difficult for me:
> 
> - This assumes that the source packages are identical for different build
>   variants. That is how it should be (there should be only one source, possibly
>   even across distro releases and architectures), but Isar gives developers
>   the tools to break that rule (SRC_URI:append:xy = "some.patch"), and
>   they will use those tools! So we'd need at least documentation warning
>   about this, or probably better some checks that restrict how SRC_URI
>   can be constructed.

If developers do the wrong thing (like in this patch), they get what
they deserve. My patch prevents that this silently sneaks into production.

> - In dpkg_runbuild (dpkg.bbclass), the code that finds DEB_SOURCE_NAME
>   assumes extracted sources (with a debian/changelog). Looking at your
>   patch, I suspect this only works for you because you still have a
>   dependency on do_fetch, even for the compat/native case where
>   you probably want to only depend on the fetch_common_source job.

To my understanding, installing the source package ensures this.

Jan

-- 
Siemens AG, Technology
Linux Expert Center