From: Uladzimir Bely <ubely@ilbers.de>
To: Jan Kiszka <jan.kiszka@siemens.com>,
isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH v5 0/7] Simplify writing initramfs hooks
Date: Mon, 02 Dec 2024 11:04:29 +0300 [thread overview]
Message-ID: <acdc43e536d00a6e9bcad1a8a6c91bd7705c4758.camel@ilbers.de> (raw)
In-Reply-To: <8d01bbbe-f026-475b-8c0d-f5be81ed28ce@siemens.com>
On Mon, 2024-12-02 at 06:59 +0100, 'Jan Kiszka' via isar-users wrote:
> On 20.11.24 18:02, 'Jan Kiszka' via isar-users wrote:
> > Changes in v5:
> > - permit completely self-provided boot scripts as well
> > (now fully tested against an isar-cip-core port)
> >
> > Changes in v4:
> > - add forgotten header to boot scripts
> > (this part was apparently only build-tested so far...)
> >
> > Changes in v3:
> > - fix DEBIAN_DEPENDS for initramfs-tee-supplicant-hook
> > - use .= for extending DEBIAN_DEPENDS
> >
> > Changes in v2:
> > - add commit message to patch 1
> >
> > Specifically while looking at the initramfs recipes we have in
> > isar-cip-core, it felt like it's time to simplify their creation
> > and
> > offload the developers from all the related boilerplate bits. But
> > the
> > benefit can also be observed with the initramfs recipes in isar
> > itself.
> >
> > Jan
> >
> > Jan Kiszka (7):
> > initramfs-hook: Add infrastructure to ease writing hooks
> > doc: Describe initramfs customizations
> > isar-initramfs: Add initramfs-fsck-hook-ext4
> > initramfs-isar-example-hook: Convert recipe over to new hook.inc
> > initramfs-fsck-ext4-hook: Convert to hook.inc and improve
> > initramfs-tee-ftpm-hook: Convert to hook.inc
> > initramfs-tee-supplicant-hook: Convert to hook.inc
> >
> > doc/user_manual.md | 58 +++++++++++++
> > .../images/isar-initramfs.bb | 3 +-
> > .../initramfs-example/files/example.hook | 21 -----
> > .../initramfs-example/files/example.script | 23 ------
> > .../initramfs-example/files/local-top | 3 +
> > ....bb => initramfs-isar-example-hook_0.1.bb} | 21 ++---
> > .../files/initramfs-fsck-hook-ext4.triggers | 0
> > .../initramfs-fsck-ext4-hook_0.3.bb | 14 ++++
> > .../initramfs-hook/files/hook-header.tmpl | 39 +++++++++
> > .../initramfs-hook/files/script-header.tmpl | 26 ++++++
> > .../recipes-initramfs/initramfs-hook/hook.inc | 81
> > +++++++++++++++++++
> > .../files/{tee-ftpm.script => local-top} | 18 +----
> > .../files/tee-ftpm.hook | 28 -------
> > .../initramfs-tee-ftpm-hook_0.1.bb | 27 -------
> > .../initramfs-tee-ftpm-hook_0.2.bb | 15 ++++
> > .../{tee-supplicant.script => local-top} | 18 +----
> > .../files/tee-supplicant.hook | 36 ---------
> > .../initramfs-tee-supplicant-hook_0.1.bb | 27 -------
> > .../initramfs-tee-supplicant-hook_0.2.bb | 16 ++++
> > .../files/initramfs.fsck.ext4.hook | 39 ---------
> > .../initramfs-fsck-hook-ext4_0.2.bb | 18 -----
> > 21 files changed, 263 insertions(+), 268 deletions(-)
> > delete mode 100644 meta-isar/recipes-initramfs/initramfs-
> > example/files/example.hook
> > delete mode 100644 meta-isar/recipes-initramfs/initramfs-
> > example/files/example.script
> > create mode 100644 meta-isar/recipes-initramfs/initramfs-
> > example/files/local-top
> > rename meta-isar/recipes-initramfs/initramfs-example/{initramfs-
> > example.bb => initramfs-isar-example-hook_0.1.bb} (63%)
> > rename meta/{recipes-support => recipes-initramfs}/initramfs-fsck-
> > hook/files/initramfs-fsck-hook-ext4.triggers (100%)
> > create mode 100644 meta/recipes-initramfs/initramfs-fsck-
> > hook/initramfs-fsck-ext4-hook_0.3.bb
> > create mode 100644 meta/recipes-initramfs/initramfs-
> > hook/files/hook-header.tmpl
> > create mode 100644 meta/recipes-initramfs/initramfs-
> > hook/files/script-header.tmpl
> > create mode 100644 meta/recipes-initramfs/initramfs-hook/hook.inc
> > rename meta/recipes-initramfs/initramfs-tee-ftpm-hook/files/{tee-
> > ftpm.script => local-top} (75%)
> > delete mode 100644 meta/recipes-initramfs/initramfs-tee-ftpm-
> > hook/files/tee-ftpm.hook
> > delete mode 100644 meta/recipes-initramfs/initramfs-tee-ftpm-
> > hook/initramfs-tee-ftpm-hook_0.1.bb
> > create mode 100644 meta/recipes-initramfs/initramfs-tee-ftpm-
> > hook/initramfs-tee-ftpm-hook_0.2.bb
> > rename meta/recipes-initramfs/initramfs-tee-supplicant-
> > hook/files/{tee-supplicant.script => local-top} (68%)
> > delete mode 100644 meta/recipes-initramfs/initramfs-tee-
> > supplicant-hook/files/tee-supplicant.hook
> > delete mode 100644 meta/recipes-initramfs/initramfs-tee-
> > supplicant-hook/initramfs-tee-supplicant-hook_0.1.bb
> > create mode 100644 meta/recipes-initramfs/initramfs-tee-
> > supplicant-hook/initramfs-tee-supplicant-hook_0.2.bb
> > delete mode 100644 meta/recipes-support/initramfs-fsck-
> > hook/files/initramfs.fsck.ext4.hook
> > delete mode 100644 meta/recipes-support/initramfs-fsck-
> > hook/initramfs-fsck-hook-ext4_0.2.bb
> >
>
> Anything missing to get this merged? Downstream isar-cip-core would
> benefit from it for its next release.
>
> Jan
>
At least, not from the point of CI testing. The patchset recently was
tested and passes it. So, if there are no objections, it will be merged
today.
> --
> Siemens AG, Technology
> Linux Expert Center
>
--
Best regards,
Uladzimir.
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/acdc43e536d00a6e9bcad1a8a6c91bd7705c4758.camel%40ilbers.de.
next prev parent reply other threads:[~2024-12-02 8:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 17:02 'Jan Kiszka' via isar-users
2024-11-20 17:02 ` [PATCH v5 1/7] initramfs-hook: Add infrastructure to ease writing hooks 'Jan Kiszka' via isar-users
2024-11-20 17:02 ` [PATCH v5 2/7] doc: Describe initramfs customizations 'Jan Kiszka' via isar-users
2024-11-20 17:02 ` [PATCH v5 3/7] isar-initramfs: Add initramfs-fsck-hook-ext4 'Jan Kiszka' via isar-users
2024-11-20 17:02 ` [PATCH v5 4/7] initramfs-isar-example-hook: Convert recipe over to new hook.inc 'Jan Kiszka' via isar-users
2024-11-20 17:02 ` [PATCH v5 5/7] initramfs-fsck-ext4-hook: Convert to hook.inc and improve 'Jan Kiszka' via isar-users
2024-11-20 17:03 ` [PATCH v5 6/7] initramfs-tee-ftpm-hook: Convert to hook.inc 'Jan Kiszka' via isar-users
2024-11-20 17:03 ` [PATCH v5 7/7] initramfs-tee-supplicant-hook: " 'Jan Kiszka' via isar-users
2024-11-20 18:02 ` [PATCH v5 0/7] Simplify writing initramfs hooks 'Jan Kiszka' via isar-users
2024-12-02 5:59 ` 'Jan Kiszka' via isar-users
2024-12-02 8:04 ` Uladzimir Bely [this message]
2024-12-02 9:19 ` Uladzimir Bely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acdc43e536d00a6e9bcad1a8a6c91bd7705c4758.camel@ilbers.de \
--to=ubely@ilbers.de \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox