From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6458964006491127808 X-Received: by 10.99.176.8 with SMTP id h8mr2227137pgf.166.1503988090512; Mon, 28 Aug 2017 23:28:10 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.107.140.73 with SMTP id o70ls1726455iod.35.gmail; Mon, 28 Aug 2017 23:28:10 -0700 (PDT) X-Google-Smtp-Source: ADKCNb5yYAbcbfQaarNtRsZnXY/1ZY1hcVPIJYCuygClDcEO+7moJy3IBGrEMm54ERuQBaq4D+ev X-Received: by 10.129.121.77 with SMTP id u74mr2102061ywc.239.1503988089945; Mon, 28 Aug 2017 23:28:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503988089; cv=none; d=google.com; s=arc-20160816; b=0Lu6gQ3OyuYcpf0JbixVD1YoZxTbwS9d+/Aaup0jn5RKjCkgkJ4cgXmjv13zf7hz3h dZpPLRWYQglN2P4hMs/1wozu3Nnghj/v4YlaALwVJVf0tsKqRzM+2aPAOm+MYB1MZK+p B5yEhpcb6UF1X4PXAnEmtF1dqyKaJCxBovxNj+tSfeNnBVujMj5QukwhKigpxHpg3sCM 0yBgYBhdCrn5B0P0cIITmf1KVfJVsp2h8ubSzY+N2yDAgGk/nSMI9jNWLEJi6kptCF7K IAHrs73vUStR4X1ydi3dmu4o16gVYqXsiX5KTyfh9fpOmGtJoRN1F2DAYxYYPidecxx9 UtiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=C3kQ0XusVGxgE9Wj+Fyeldz60tCMHo8lz92EyAHIIC4=; b=mFK2GXKWJJEMffwK0ECbCb0/K7M0a6NM3TDxDfsAwmsxLv/rGrjjYr+EFzTfLXJC/w s8n2DUO58tlIhHcKc4GXG+3roWkmmO3BaKOmtrUC39yYoIA+ryaYrZ2YlQVDEi3Y1XRf eRwSJUMy4AR5I8jiPZdNodmrhVDaNy0TE/TUdu32mPyRp8VON1bQqPfUBpcQsMlo5A5m 4mDmghl2UGHLivxjLDX3cexyniOhXNIPC7g2M86eZmV4IyeXaewksjjl8wropAtGlgRU HRaZ0kXKHjQ0j2qEbKcgrBcBbWIQ8qcHDctZTvhwm/lRssVfGwVGIKrhyJqprWFS3oVL /vDg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id g79si74881ita.0.2017.08.28.23.28.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Aug 2017 23:28:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id v7T6S5pu013123 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Tue, 29 Aug 2017 08:28:06 +0200 Subject: Re: [PATCH 1/5] classes/base: Fix fetch task dependency To: Henning Schild Cc: isar-users@googlegroups.com References: <20170827143840.12436-1-asmirnov@ilbers.de> <20170827143840.12436-2-asmirnov@ilbers.de> <20170828165713.207c248c@md1em3qc> From: Alexander Smirnov Message-ID: Date: Tue, 29 Aug 2017 09:27:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170828165713.207c248c@md1em3qc> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: AWple92+vsG3 On 08/28/2017 05:57 PM, Henning Schild wrote: > Am Sun, 27 Aug 2017 17:38:36 +0300 > schrieb Alexander Smirnov : > >> Fetch task should be run before unpack, not before build. >> >> Signed-off-by: Alexander Smirnov >> --- >> meta/classes/dpkg.bbclass | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass >> index 23d5e6c..360a95c 100644 >> --- a/meta/classes/dpkg.bbclass >> +++ b/meta/classes/dpkg.bbclass >> @@ -25,7 +25,7 @@ python do_fetch() { >> raise bb.build.FuncFailed(e) >> } >> >> -addtask fetch before do_build >> +addtask fetch before do_unpack >> >> do_unpack[dirs] = "${BUILDROOT}" >> do_unpack[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > > A few lines below that you find: > >> addtask unpack after do_fetch before do_build > > With this patch you would have the order expressed twice, which is not > a good idea. This patches does not change anything, it just introduces > redundant information. This patch is not about technical issues, it just improves code readability and explicitly defines the order of tasks. If task fetch should go before unpack, it would be more evident do define it in this way. -- With best regards, Alexander Smirnov ilbers GmbH Baierbrunner Str. 28c D-81379 Munich +49 (89) 122 67 24-0 http://ilbers.de/ Commercial register Munich, HRB 214197 General manager: Baurzhan Ismagulov