From: Henning Schild <henning.schild@siemens.com>
To: isar-users@googlegroups.com
Cc: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>,
Christian Storm <christian.storm@siemens.com>,
Claudius Heine <ch@denx.de>,
Henning Schild <henning.schild@siemens.com>
Subject: [PATCH 1/6] meta/dpkg: Make 'do_unpack' more generic, prepare for pulling out
Date: Wed, 30 Aug 2017 21:03:52 +0200 [thread overview]
Message-ID: <ad14916f28a29898dbf0ab377d258552d12d3e68.1504119538.git.henning.schild@siemens.com> (raw)
In-Reply-To: <cover.1504119538.git.henning.schild@siemens.com>
In-Reply-To: <cover.1504119538.git.henning.schild@siemens.com>
Issue:
The unpacker in dpkg is not generic since it does not unpack to
WORKDIR, so it can not be pulled into a more generic class to make it
available for other users.
Change:
Make the unpacker generic by making it unpack to WORKDIR and keep the
old semantic by overwriting this variable for the task do_unpack. Change
the comment as well, it would be wrong outside this context.
Impact:
This patch does not change the behaviour of Isar. It addresses the issue
and prepares for another patch pulling the code to another class.
Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
meta/classes/dpkg.bbclass | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
index 23d5e6c..81e21ce 100644
--- a/meta/classes/dpkg.bbclass
+++ b/meta/classes/dpkg.bbclass
@@ -31,13 +31,15 @@ do_unpack[dirs] = "${BUILDROOT}"
do_unpack[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
S ?= "${BUILDROOT}"
-# Unpack package and put it into working directory in buildchroot
+WORKDIR_task-unpack = "${BUILDROOT}"
+
+# Unpack package and put it into working directory
python do_unpack() {
src_uri = (d.getVar('SRC_URI', True) or "").split()
if len(src_uri) == 0:
return
- rootdir = d.getVar('BUILDROOT', True)
+ rootdir = d.getVar('WORKDIR', True)
try:
fetcher = bb.fetch2.Fetch(src_uri, d)
--
2.13.5
next prev parent reply other threads:[~2017-08-30 19:03 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 19:03 [PATCH 0/6] v3 of getting the custom debian package in Henning Schild
2017-08-30 19:03 ` Henning Schild [this message]
2017-09-04 15:11 ` [PATCH 1/6] meta/dpkg: Make 'do_unpack' more generic, prepare for pulling out Alexander Smirnov
2017-09-04 16:47 ` Jan Kiszka
2017-09-05 7:05 ` Claudius Heine
2017-09-05 7:25 ` Alexander Smirnov
2017-09-05 7:37 ` Alexander Smirnov
2017-09-05 7:56 ` Claudius Heine
2017-09-08 8:30 ` Henning Schild
2017-09-08 8:44 ` Claudius Heine
2017-09-08 9:03 ` Henning Schild
2017-08-30 19:03 ` [PATCH 2/6] meta: Move 'do_fetch' and 'do_unpack' to base-class Henning Schild
2017-09-04 15:14 ` Alexander Smirnov
2017-09-04 16:03 ` Jan Kiszka
2017-09-04 16:10 ` Alexander Smirnov
2017-09-04 16:11 ` Jan Kiszka
2017-09-04 16:39 ` Alexander Smirnov
2017-09-04 16:45 ` Jan Kiszka
2017-08-30 19:03 ` [PATCH 3/6] meta/dpkg: rename to dpkg-debian and add comment Henning Schild
2017-08-31 8:23 ` Claudius Heine
2017-09-04 15:17 ` Alexander Smirnov
2017-09-04 16:05 ` Jan Kiszka
2017-08-30 19:03 ` [PATCH 4/6] meta/dpkg-debian: Make 'do_install' more generic, prepare for pulling out Henning Schild
2017-08-30 19:09 ` Henning Schild
2017-09-08 8:35 ` Henning Schild
2017-08-30 19:03 ` [PATCH 5/6] meta/dpkg: add dpkg-custom class Henning Schild
2017-08-31 8:38 ` Claudius Heine
2017-08-31 8:42 ` Jan Kiszka
2017-08-31 9:10 ` Claudius Heine
2017-08-31 9:32 ` Henning Schild
2017-08-31 12:14 ` Claudius Heine
2017-08-31 13:39 ` Henning Schild
2017-09-11 8:39 ` Alexander Smirnov
2017-08-31 8:53 ` Claudius Heine
2017-08-31 10:21 ` Henning Schild
2017-09-04 15:36 ` Alexander Smirnov
2017-09-04 16:08 ` Jan Kiszka
2017-09-04 16:30 ` Alexander Smirnov
2017-09-04 16:53 ` Jan Kiszka
2017-09-08 8:20 ` Henning Schild
2017-09-08 8:15 ` Henning Schild
2017-09-08 8:31 ` Alexander Smirnov
2017-09-08 8:42 ` Henning Schild
2017-09-08 8:50 ` Alexander Smirnov
2017-09-11 8:13 ` Claudius Heine
2017-09-11 8:19 ` Henning Schild
2017-09-11 9:12 ` Claudius Heine
2017-09-11 8:42 ` Claudius Heine
2017-08-30 19:03 ` [PATCH 6/6] recipes-app/example-custom: add example on how to use dpkg-custom Henning Schild
2017-09-04 15:40 ` Alexander Smirnov
2017-09-06 7:36 ` Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad14916f28a29898dbf0ab377d258552d12d3e68.1504119538.git.henning.schild@siemens.com \
--to=henning.schild@siemens.com \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=ch@denx.de \
--cc=christian.storm@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox