From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6460145511672315904 X-Received: by 10.46.21.72 with SMTP id 8mr250694ljv.21.1504119837852; Wed, 30 Aug 2017 12:03:57 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.206.200 with SMTP id e191ls971288wmg.2.canary-gmail; Wed, 30 Aug 2017 12:03:57 -0700 (PDT) X-Google-Smtp-Source: ADKCNb6H5mbng1QpglyPdGsrATpgrUUbXyM02puddvNDhsJP6n9XZa0P4G8kR2KQ9+Or3OKML3gK X-Received: by 10.223.130.120 with SMTP id 111mr173244wrb.26.1504119837504; Wed, 30 Aug 2017 12:03:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504119837; cv=none; d=google.com; s=arc-20160816; b=pv4bESEAhf+th4+A+W4bMRhbd3/MLUewDt6Jo4osZ9+qBoXbXoMgVlHKUProqeUtEt bx/NouWjNC4QK7KLCzoA7z/2/5jwMu4KF+4K2a58tkgiJVHcvXrVvgtHSrdwd8VBe6RJ ih4iXzKqq8hDQVL/5wb4wHGkM9a69EhbutyN3aFcFwqrl74Nyt3Dng8LrvE/LNjaKLEp h5nEwIyBr1M7/WcE2qEwqRW9jQNbmSyLW2h5ODp0jvgp62gTxFSu9uGEs52yoJfUIw0B JJEIdNXQlPo9EvuzJzaTCSIzI9pGubbiB6fq+3wmKs0hpIXvautCZorm9ktSQ17kPpUr YdHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=HCfLfYqeT9aIHpEDt8vP7ilz2Eg2PAnvFJTSmBDPgQY=; b=GihoaY+W7hQAF86+iGMz4wI5hJdVI1uNxslYAuq2NAmghgNC2Z4/BJxt4wfmOVDmOh L7/frPumBQMePPd1xQC4sRPhM+PGg5rVaPe6rKbcaZj0L+DEfcebogZ4KamycU8hPb4H 1M356oM4kkRdBbqjDG4uVyYtpC4EZ8EpVuw8ANmL1UPpezN7wUgFWcrXY2jbazYVGygB namZkhU1fNtODSmtPiRT9PvztEMo1NNfEYTa9m1CwLDdGg5vHcOnPxFxhOu2AJsz6dQs 454yT7BxhBl6rx3tYXZqEJOKnhrUom6UNASMmy4/5H5IqQC0RDnGZM3XP7kPeRTtFd3w gjaQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id q186si204550wmb.7.2017.08.30.12.03.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Aug 2017 12:03:57 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id v7UJ3uR3018147 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Aug 2017 21:03:56 +0200 Received: from md1em3qc.ad001.siemens.net ([139.25.68.40]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id v7UJ3t5g027281; Wed, 30 Aug 2017 21:03:56 +0200 From: Henning Schild To: isar-users@googlegroups.com Cc: Alexander Smirnov , Christian Storm , Claudius Heine , Henning Schild Subject: [PATCH 1/6] meta/dpkg: Make 'do_unpack' more generic, prepare for pulling out Date: Wed, 30 Aug 2017 21:03:52 +0200 Message-Id: X-Mailer: git-send-email 2.13.5 In-Reply-To: References: In-Reply-To: References: X-TUID: a5CjMw8okPG5 Issue: The unpacker in dpkg is not generic since it does not unpack to WORKDIR, so it can not be pulled into a more generic class to make it available for other users. Change: Make the unpacker generic by making it unpack to WORKDIR and keep the old semantic by overwriting this variable for the task do_unpack. Change the comment as well, it would be wrong outside this context. Impact: This patch does not change the behaviour of Isar. It addresses the issue and prepares for another patch pulling the code to another class. Signed-off-by: Henning Schild --- meta/classes/dpkg.bbclass | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass index 23d5e6c..81e21ce 100644 --- a/meta/classes/dpkg.bbclass +++ b/meta/classes/dpkg.bbclass @@ -31,13 +31,15 @@ do_unpack[dirs] = "${BUILDROOT}" do_unpack[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" S ?= "${BUILDROOT}" -# Unpack package and put it into working directory in buildchroot +WORKDIR_task-unpack = "${BUILDROOT}" + +# Unpack package and put it into working directory python do_unpack() { src_uri = (d.getVar('SRC_URI', True) or "").split() if len(src_uri) == 0: return - rootdir = d.getVar('BUILDROOT', True) + rootdir = d.getVar('WORKDIR', True) try: fetcher = bb.fetch2.Fetch(src_uri, d) -- 2.13.5