public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: "[ext] Lisicki, Raphael" <raphael.lisicki@siemens.com>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Subject: Re: do_adjust_git in dpkg-base.class
Date: Thu, 7 Feb 2019 16:31:31 +0100	[thread overview]
Message-ID: <adad42ff-1ac4-a8e6-a848-1084c1c2de58@siemens.com> (raw)
In-Reply-To: <AM5PR10MB1843112B9D56AD2BAC144085EC680@AM5PR10MB1843.EURPRD10.PROD.OUTLOOK.COM>

On 07.02.19 14:03, [ext] Lisicki, Raphael wrote:
> Hello everybody,
> 
> the function do_adjust_git in dpkg-base.class breaks git for all operations outside of the buildchroot. E.g. it is not possible to use git in a prepare_build command, as it is not yet done in the buildchroot, but the git adjustment has already been done.
> I would suggest to move the call to do_adjust_git into dpkg_do_mounts and maybe even undo it afterwards, so that targets that run after build can also have access to a working git repo.

Moving it earlier should probably be fine. But undoing after some step can cause 
troubles when your rebuild your target and do not restart the task that applies 
the adjustment.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

  reply	other threads:[~2019-02-07 15:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-07 13:03 Lisicki, Raphael
2019-02-07 15:31 ` Jan Kiszka [this message]
2019-02-07 17:51 ` Henning Schild
2019-02-07 18:19 ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adad42ff-1ac4-a8e6-a848-1084c1c2de58@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=raphael.lisicki@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox