From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6840330486346153984 X-Received: by 2002:a9d:4801:: with SMTP id c1mr21041090otf.10.1594114298413; Tue, 07 Jul 2020 02:31:38 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a9d:19a8:: with SMTP id k37ls4135468otk.10.gmail; Tue, 07 Jul 2020 02:31:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUPectsgGLw06alQ3lXCq9Zj9B8CPx9t0lZM7HCMZrHNl2xSCZ2appnZXhAiClkltIacTiY6odMg== X-Received: by 2002:a05:6830:443:: with SMTP id d3mr19235915otc.210.1594114297807; Tue, 07 Jul 2020 02:31:37 -0700 (PDT) X-Google-Web-Client: true Date: Tue, 7 Jul 2020 02:31:37 -0700 (PDT) From: Hombourger Cedric To: isar-users Message-Id: In-Reply-To: <20200620073520.9737-1-henning.schild@siemens.com> References: <20200620073520.9737-1-henning.schild@siemens.com> Subject: Re: [PATCH] bitbake.conf: make DEBDISTRONAME a weak default MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_914_670131036.1594114297430" X-TUID: 64MeCf3+CzIu ------=_Part_914_670131036.1594114297430 Content-Type: multipart/alternative; boundary="----=_Part_915_789934266.1594114297430" ------=_Part_915_789934266.1594114297430 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On Saturday, June 20, 2020 at 9:35:49 AM UTC+2 Henning Schild wrote: > From: Henning Schild > > If layers want to set their own value they can not because bitbake.conf > is always coming last. Making it a weak default gives layers a way to > choose their own value. > > Signed-off-by: Henning Schild > --- > meta/conf/bitbake.conf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > index 848e085acf..71f2f1c8b4 100644 > --- a/meta/conf/bitbake.conf > +++ b/meta/conf/bitbake.conf > @@ -74,7 +74,7 @@ QEMU_ARCH_mipsel = "mipsel" > QEMU_ARCH_riscv64 = "riscv64" > > # Codename of the repository created by the caching class > -DEBDISTRONAME = "isar" > +DEBDISTRONAME ?= "isar" > looks good to me. is there any chance we can get this change merged soon? > > # Isar apt repository paths > REPO_ISAR_DIR = "${DEPLOY_DIR}/isar-apt/apt" > -- > 2.26.2 > > ------=_Part_915_789934266.1594114297430 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
On Saturday, June 20, 2020 at 9:35:49 AM UTC+2 Henning Schild wrote:
From: Henning Schild <henning...@siemens.com>

If layers want to set their own value they can not because bitbake.conf
is always coming last. Making it a weak default gives layers a way to
choose their own value.

Signed-off-by: Henning Schild <henning...@siemens.com>
---
meta/conf/bitbake.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 848e085acf..71f2f1c8b4 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -74,7 +74,7 @@ QEMU_ARCH_mipsel = "mipsel"
QEMU_ARCH_riscv64 = "riscv64"

# Codename of the repository created by the caching class
-DEBDISTRONAME = "isar"
+DEBDISTRONAME ?= "isar"
looks good to me. is there any chance we can get this change merged soon? 

# Isar apt repository paths
REPO_ISAR_DIR = "${DEPLOY_DIR}/isar-apt/apt"
--
2.26.2

------=_Part_915_789934266.1594114297430-- ------=_Part_914_670131036.1594114297430--