Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Jan Kiszka <jan.kiszka@siemens.com>]

On 26.04.19 09:36, Claudius Heine wrote:
> Hi Maxim,
> 
> Quoting Maxim Yu. Osipov (2019-04-25 20:20:59)
>> On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote:
>>> From: Claudius Heine <ch@denx.de>
>>>
>>> isar-bootstrap-host only supports bootstrapping Debian root file
>>> systems. Therefore deactivate any DISTRO_APT_KEYS from other
>>> distributions.
>>>
>>> Signed-off-by: Claudius Heine <ch@denx.de>
>>> ---
>>>    meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>> index 08b068f..3e96281 100644
>>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>> @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
>>>    ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
>>>    
>>>    require isar-bootstrap.inc
>>> +# We only build debian host buildchroot environments
>>> +DISTRO_APT_KEYS = ""
>>
>>   From the first glance this modification limits functionality.
>> It looks like a hack and I would suggest to avoid this modification.
> 
> Well it is a fix and that limited functionality was already present but
> just implicit, hidden behind some bug and the cleanup just made it
> appear.
> 
>> Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to
>> avoid confusion between target and host apt keys.
> 
> Good idea. But that would be a new feature/improvement.
> 

If that is just about adding and documenting another variable, let's not discuss 
about when and who because just doing that will already be faster, even if it's 
a "drive-by" improvement /wrt this patchset.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux