From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6683827867816558592 X-Received: by 2002:a2e:8017:: with SMTP id j23mr1728229ljg.40.1556278301410; Fri, 26 Apr 2019 04:31:41 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:5289:: with SMTP id q9ls2158425lfm.2.gmail; Fri, 26 Apr 2019 04:31:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqzi8JH/YPPss2Bmiy8mhUrlBiPcJcINGJDv+tsNhHIQfAfgFjab0vtn3/MQTypkcL0LVUgc X-Received: by 2002:a19:ee17:: with SMTP id g23mr24738719lfb.43.1556278300758; Fri, 26 Apr 2019 04:31:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556278300; cv=none; d=google.com; s=arc-20160816; b=DnkIfz/S/c/Xl/Y7kOucHTIG4fqnu7x+RjeM3pcG9rvxiQKg/stgdTfEw2Ah/CLt7n aJAklshEAjuhkziErxMlhOl0CcaQ+EUcDykUzR/orAstqvEpkX4d/K6Y7juLQxoPJTV0 QK/Y3J9Ww5nXwpixZamLZRAjDaA9qj1MgF5+G/1R66FVfxMdwKaj2rTboSnK7bz1DDt1 dl7iqfs+YV3Ab6Ig78k+2nPfIV5vgbq7FbvKtgK8151xj9CxFVZceT7tXOWOAZvLlTMG RHsoBOJj4ES3erCxR+Hd/1GqHVEw2kOO9m0GA8Qn6QBBNp63gqo13p5rkDfH488ciJ2N 10Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=tG9U9/NWILrq6ANYiV97YGRlzpzLIPdXMk4tkI+EVq0=; b=Vg8Tm5aLbQsvG4GPGGrd3AhWGuhFnJhh/MmOve+nD5mkwugEIMQMTnJyD+0yyrMNMJ etGCPwd6hFJb7gPXJ9A4wiAKOic7g8PnCxGRG/4VWj3FsXGbSd/Z64uNvqzarWCj93ci pfWe5iA9zLATYTaf/98QGbgR3N2U16wjK67rSZzFNmA6oVTRpC4VBvEf7yDKfa3wfsz3 q2ypsXQvHKSh1brJ1FvfgnUwC3D+YKe4Vlq6k4J1CdKHgCAVAxsouXsXLFjyDnCXTsKj 1jnDy6V0AIAIAVH+cxdG2fLBVYULPQ+Nb6Z++hzrBW9bpRjRWGGC7PlwsHjI+Vm2PMeZ FYcw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id p16si1135677ljp.1.2019.04.26.04.31.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Apr 2019 04:31:40 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x3QBVdTi026923 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Apr 2019 13:31:39 +0200 Received: from [167.87.22.130] ([167.87.22.130]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x3QBVcl5028815; Fri, 26 Apr 2019 13:31:38 +0200 Subject: Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage To: Claudius Heine , "Maxim Yu. Osipov" , claudius.heine.ext@siemens.com, isar-users@googlegroups.com References: <20190425134450.13443-1-claudius.heine.ext@siemens.com> <20190425134450.13443-2-claudius.heine.ext@siemens.com> <155626421155.10914.2537647574220599237@ardipi> From: Jan Kiszka Message-ID: Date: Fri, 26 Apr 2019 13:31:38 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <155626421155.10914.2537647574220599237@ardipi> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: nNN0jpocJvnI On 26.04.19 09:36, Claudius Heine wrote: > Hi Maxim, > > Quoting Maxim Yu. Osipov (2019-04-25 20:20:59) >> On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote: >>> From: Claudius Heine >>> >>> isar-bootstrap-host only supports bootstrapping Debian root file >>> systems. Therefore deactivate any DISTRO_APT_KEYS from other >>> distributions. >>> >>> Signed-off-by: Claudius Heine >>> --- >>> meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb >>> index 08b068f..3e96281 100644 >>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb >>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb >>> @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}" >>> ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock" >>> >>> require isar-bootstrap.inc >>> +# We only build debian host buildchroot environments >>> +DISTRO_APT_KEYS = "" >> >> From the first glance this modification limits functionality. >> It looks like a hack and I would suggest to avoid this modification. > > Well it is a fix and that limited functionality was already present but > just implicit, hidden behind some bug and the cleanup just made it > appear. > >> Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to >> avoid confusion between target and host apt keys. > > Good idea. But that would be a new feature/improvement. > If that is just about adding and documenting another variable, let's not discuss about when and who because just doing that will already be faster, even if it's a "drive-by" improvement /wrt this patchset. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux