From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6927266035414335488 X-Received: by 2002:a05:6512:2356:: with SMTP id p22mr13433070lfu.3.1612895985814; Tue, 09 Feb 2021 10:39:45 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:8745:: with SMTP id q5ls3848106ljj.6.gmail; Tue, 09 Feb 2021 10:39:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJwMhDa9BTFktnwH3BgG2gGM5wsHFEi9HPOBKEcYwkzRau1Ca5i7/Jc/jNRfVBGP0koQBN24 X-Received: by 2002:a2e:9117:: with SMTP id m23mr11496486ljg.259.1612895984628; Tue, 09 Feb 2021 10:39:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612895984; cv=none; d=google.com; s=arc-20160816; b=NtVXGZheJmP6K9gZgjduDaezFw3t5prIBr8LdVmLO4d0ec0dq5ibaGrw7Gkycf8WPA hUsFFlZzkyEIAbSwnz9snd4LTuQ7HAz8y7a9Mc2aqmmLssqtdo9Ttpebp49nP6zw3k73 eqMqC8e3CyMMmY7PaMGfkguDFgqrcP2gC95s8bEaF7IJqoumSIbdNecQphAPjvDhkm2g sW7oVKZcTFkeqHjaecoPOs9lr8YJkcDv30XiRjWrtQTet78f6uuYzs6ssHZViyHY+63j Asy7tpsc4tDbHtDGyTLE7C9dVK2e587byk63KfgGeSyATEjq+yaIn098LpS3pbkDwORT cEyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=0vyX7ScXcEnk64ncE7Um4lB0SELOMdKWcEr/j/lD7bM=; b=F2KlVW4BIh+P/CuBRGBVTxHBvm7Zu+rVpEGR0QgXgwS6tWfx+a8PLzZ0CIj9Ve6Z0V diYP8sEYrQcZYZyDVfISP4dOpqCNQz1LV7f+k/xBDSdN+B7lfYOmAzFSGS8hkVMDLabC C2XBVQvFyt3Tob9g5nds0kXB04iZQN2XTUG2CK1/J3+XQputH0QRS9h3fQdUHVD+VPfv YxeimHyryxgaqPlQ1T1wpEZPZF/X/c7fsDdqBGk2pZ4bKMMPHnRfxg/mhCwNY4qsdRk4 5g2J+OuU7/2nyd4y9wsebXsjsPkovKVWt++Tby7vd39VfqR/GQgJekAWdBAjzedrkZI2 sjlQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id m17si672857lfg.0.2021.02.09.10.39.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Feb 2021 10:39:44 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 119IdhTx019269 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 9 Feb 2021 19:39:43 +0100 Received: from [167.87.249.204] ([167.87.249.204]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 119Idh88020180; Tue, 9 Feb 2021 19:39:43 +0100 Subject: Re: [PATCH V2 0/2] Add support for containerized root filesystems To: Silvano Cirujano Cuesta , isar-users@googlegroups.com References: <20210209141005.45491-1-silvano.cirujano-cuesta@siemens.com> From: Jan Kiszka Message-ID: Date: Tue, 9 Feb 2021 19:39:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 35ownrgdpvjO On 09.02.21 18:37, Silvano Cirujano Cuesta wrote: > > On 09/02/2021 17:50, Jan Kiszka wrote: >> On 09.02.21 15:10, [ext] Silvano Cirujano Cuesta wrote: >>> This patch series provides support for containerized root filesystems, >>> for both target images and SDKs. >>> >>> For containerized target images the new image type `container-img` has >>> been added. >>> >>> For containerized SDKs the task `populate_sdk` has been extended. >>> >>> Containerized root filesystems are easy to distribute and run, enabling >>> this way following scenarios: >>> - Use ISAR to build container images meant to be run only in containers. >>> - Use the same ISAR configuration to build images for containers, VMs >>> and bare-metal. >>> - Easy SDK distribution and "installation". >>> - Quickly testing certain applications in the workstation using the >>> target root filesystem. >>> >>> In order to build containerized rootfilesystems `IMAGE_TYPE` as to be >>> `container-img`, additionally the container image format can be selected >>> with the variable `CONTAINER_FORMAT`. The default format is >>> `docker-archive`. >>> >> But you dropped control over building the SDK (and only the SDK) as >> container, didn't you? Where did that SDK_FORMATS go? >> >> Jan > > Yes, if we want to have so much control, them we'll need at least 3 variables instead of 2. But I can introduce them, if desired. > > Two of them to select the container format(s) to generate. For these I'd propose CONTAINER_FORMAT and SDK_FORMAT. > > Another one to select the build of a container image for target, IMAGE_TYPE="container-img" would be my proposal. > > The selection of containerized SDK would be implicit with the presence of a valid SDK_FORMAT. If that selection should be explicit, then a 4th variable would be needed. > > I don't have a strong opinion on this, so simply make a wish. There are two use cases (target image format = container, SDK = container), and those should be independently configurable. I was fine with your previous way of configuring the SDK_FORMATS. Here, we should add container-img as another IMAGE_TYPE, further configurable regarding its output formats (CONTAINER_FORMATS). And both use cases should share container-img.bbclass for their common bits. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux