Re: [PATCH 1/6] meta/dpkg: Make 'do_unpack' more generic, prepare for pulling out

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi,

On 09/05/2017 09:37 AM, Alexander Smirnov wrote:
> Hi,
> 
>>> On 09/04/2017 05:11 PM, Alexander Smirnov wrote:
>>>> On 08/30/2017 10:03 PM, Henning Schild wrote:
>>>>> Issue:
>>>>> The unpacker in dpkg is not generic since it does not unpack to
>>>>> WORKDIR, so it can not be pulled into a more generic class to make it
>>>>> available for other users.
>>>>>
>>>>
>>>> As I already wrote to mail-list, WORKDIR and BUILDROOT are different 
>>>> folders, and there was the reason to do so.
>>>
>>> Yes we (Henning and I) get that. That is the reason why the patch 
>>> includes the line:
>>>
>>> +WORKDIR_task-unpack = "${BUILDROOT}"
>>>
>>> That means that only for the unpack task in the dpkg.bbclass the 
>>> variable WORKDIR is set to the BUILDROOT variable. This makes the 
>>> unpack step more generic so that it can be moved to the base class. 
>>> Essentially removing the dependency of the unpack task to the dpkg 
>>> class.
>>
>> Does this mean that "log.do_unpack" and "run.do_unpack" will be stored 
>> in buildchroot? Let me check this.
>>
> 
> Yes it does:
> 
> ls 
> isar/build/tmp/work/buildchroot/debian-wheezy-armhf/rootfs/home/builder/hello/temp/ 
> 
> 
> log.do_unpack
> log.do_unpack.19557
> log.task_order
> run.do_unpack
> run.do_unpack.19557
> 
> While it's assumed that they should be stored in: 
> isar/build/tmp/work/hello-0.1+g7f35942-1-r0/temp/

Ok then the solution would be to overwrite all there variables that use 
the WORKDIR variable as well (could be done automatically via a python 
script), or to use for example a "UNPACKDIR" variable, that if set, is 
used instead of the "WORKDIR" variable. The first approach might be more 
compatible with OE, the second approach might be easier to do.

Claudius


-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de