From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6460145511672315904 X-Received: by 10.25.195.194 with SMTP id t185mr269563lff.10.1504598167822; Tue, 05 Sep 2017 00:56:07 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.30.7 with SMTP id e7ls1704853wme.20.canary-gmail; Tue, 05 Sep 2017 00:56:07 -0700 (PDT) X-Google-Smtp-Source: ADKCNb6sXcQWWqn1UnshILdbO2ws9LtBHfYGpvKKjzAemij1H8UM8xKItmSSTP8xbs6BtFEyuhk1 X-Received: by 10.28.31.206 with SMTP id f197mr304961wmf.16.1504598167460; Tue, 05 Sep 2017 00:56:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504598167; cv=none; d=google.com; s=arc-20160816; b=xhTB7zG7oEIckfnFlE/Zb+6tQNb5gAiFoa3XSRUwVPpzPvgROHx/V0pjRbcBgfIf+R KL9CHEpXwzDV9GCKy0SrIlbux+KbZsPzWvNb6WRYNEyPXlXBum2aA9IJI0WC5DIGB6hg Rv6zwX8mYq7wwd4Iyt3TOE/4Rnu+i1qYSeNk7yaJo+ZNf+dZ2QfAyDY1hut14g0hfF62 TgPz1tgrQIOTWZYHzUIT/UdDuOBJv/8Dfk/q91Fr+tQju7tBwlVbgpZflx8GViVqYR9k xHB50RYYmoKAr5Ni742jTxtqFStUaYU9KvxxzqTj4fNA2CdTJT1MuMOjtMRXTuYg0/cB tHMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=n3fQHFhHPl1YDIkNJ/cqIJgTsywLKHO94VUAzmSw/iY=; b=OX4TGcDBoKhIU8b3sPrsAyhKGqx/oA4Ctb6DcKgRuTER2bXhX/plDC6mBVx95Rwiwr 4nZNWVRrgk7FCw0DBq155NgDJkpde8KnVo50Sq9ewXDPwKgzsFsZtf0qDDTIS12IXxMu AjjNw7CIxsE/S0N++YQ7Mky4e3bpsOk59KMPMoqTb5aqvAU4vS2i8GQRSg9be6a99Rsk nWikV36mnDKXw6tpizodyYhWyMoaBADPdwx34oJV5w1g81oMtSvtStMQFmeZ3xb7Jro2 FITzaOeg7uc14Yx3sUTtDac6EdZy1JN+FgY5I/QkLZFxtpj+BIpN3KWPdMOa71/8Oh+G zucQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of claudius.heine.ext@siemens.com) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id t142si1257wmt.2.2017.09.05.00.56.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Sep 2017 00:56:07 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of claudius.heine.ext@siemens.com) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of claudius.heine.ext@siemens.com) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id v857u68k026884 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 5 Sep 2017 09:56:07 +0200 Received: from [139.25.68.223] (linux-ses-ext02.ppmd.siemens.net [139.25.68.223]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id v857u6h1008565; Tue, 5 Sep 2017 09:56:06 +0200 Subject: Re: [PATCH 1/6] meta/dpkg: Make 'do_unpack' more generic, prepare for pulling out To: Alexander Smirnov , isar-users@googlegroups.com References: <6f7b53c5-3238-1d8d-88a7-7afc3859a9ec@ilbers.de> <62849b3a-fd2f-3184-ace0-0941fd3f9325@siemens.com> From: Claudius Heine Message-ID: Date: Tue, 5 Sep 2017 09:56:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 5koZC9xYVg/9 Hi, On 09/05/2017 09:37 AM, Alexander Smirnov wrote: > Hi, > >>> On 09/04/2017 05:11 PM, Alexander Smirnov wrote: >>>> On 08/30/2017 10:03 PM, Henning Schild wrote: >>>>> Issue: >>>>> The unpacker in dpkg is not generic since it does not unpack to >>>>> WORKDIR, so it can not be pulled into a more generic class to make it >>>>> available for other users. >>>>> >>>> >>>> As I already wrote to mail-list, WORKDIR and BUILDROOT are different >>>> folders, and there was the reason to do so. >>> >>> Yes we (Henning and I) get that. That is the reason why the patch >>> includes the line: >>> >>> +WORKDIR_task-unpack = "${BUILDROOT}" >>> >>> That means that only for the unpack task in the dpkg.bbclass the >>> variable WORKDIR is set to the BUILDROOT variable. This makes the >>> unpack step more generic so that it can be moved to the base class. >>> Essentially removing the dependency of the unpack task to the dpkg >>> class. >> >> Does this mean that "log.do_unpack" and "run.do_unpack" will be stored >> in buildchroot? Let me check this. >> > > Yes it does: > > ls > isar/build/tmp/work/buildchroot/debian-wheezy-armhf/rootfs/home/builder/hello/temp/ > > > log.do_unpack > log.do_unpack.19557 > log.task_order > run.do_unpack > run.do_unpack.19557 > > While it's assumed that they should be stored in: > isar/build/tmp/work/hello-0.1+g7f35942-1-r0/temp/ Ok then the solution would be to overwrite all there variables that use the WORKDIR variable as well (could be done automatically via a python script), or to use for example a "UNPACKDIR" variable, that if set, is used instead of the "WORKDIR" variable. The first approach might be more compatible with OE, the second approach might be easier to do. Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de