From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users@googlegroups.com
Subject: Re: [[PATCH v2] 3/3] dpkg-raw: make sure templates are processed before do_install
Date: Tue, 14 Apr 2020 08:02:56 +0200 [thread overview]
Message-ID: <aeeabc60-0002-5392-2e3a-508c44b3d15f@siemens.com> (raw)
In-Reply-To: <20200410121132.oaaxohphxq7qlqze@yssyq.m.ilbers.de>
On 10.04.20 14:11, Baurzhan Ismagulov wrote:
> Hello Cedric,
>
> On Mon, Mar 16, 2020 at 01:55:52PM +0100, Cedric Hombourger wrote:
>> --- a/meta/classes/dpkg-raw.bbclass
>> +++ b/meta/classes/dpkg-raw.bbclass
>> @@ -24,3 +24,7 @@ do_prepare_build() {
>>
>> deb_debianize
>> }
>> +
>> +# make sure templates are processed before do_install
>> +inherit template
>> +addtask do_transform_template after do_unpack before do_install
>
> How does this relate to "addtask do_transform_template after do_unpack" in
> meta/classes/template.bbclass? Is one of them superfluous? If yes, would
> modifying template.bbclass be better?
do_install is dpkg-raw only, so you can't do that in template.bbclass.
But I would rather model this via the addtask of install which is under
this class' control already.
Also, that inherit is redundant because it's already part of the base
class, thus every other class.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2020-04-14 6:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 16:04 [PATCH 0/3] minor fixes Cedric Hombourger
2020-03-10 16:04 ` [PATCH 1/3] sshd-regen-keys: correct dependency on ssh daemon service Cedric Hombourger
2020-03-11 8:34 ` Henning Schild
2020-03-11 8:50 ` Henning Schild
2020-03-11 9:32 ` Jan Kiszka
2020-03-11 10:04 ` Henning Schild
2020-03-12 13:50 ` Gylstorff Quirin
2020-03-16 12:39 ` Henning Schild
2020-03-16 12:55 ` [PATCH v2 0/3] minor fixes Cedric Hombourger
2020-03-16 12:55 ` [[PATCH v2] 1/3] sshd-regen-keys: depend on ssh.service instead of sshd.service Cedric Hombourger
2020-03-16 12:55 ` [[PATCH v2] 2/3] linux-custom: support use of an arbitrary in-tree defconfig Cedric Hombourger
2020-03-16 12:55 ` [[PATCH v2] 3/3] dpkg-raw: make sure templates are processed before do_install Cedric Hombourger
2020-04-10 12:11 ` Baurzhan Ismagulov
2020-04-14 6:02 ` Jan Kiszka [this message]
2020-04-17 15:30 ` Baurzhan Ismagulov
2020-04-17 15:46 ` Jan Kiszka
2020-07-28 16:27 ` [PATCH v2 0/3] minor fixes Baurzhan Ismagulov
2020-07-28 20:46 ` Henning Schild
2020-07-30 16:08 ` Baurzhan Ismagulov
2020-03-10 16:04 ` [PATCH 2/3] linux-custom: support use of an arbitrary in-tree defconfig Cedric Hombourger
2020-03-10 16:04 ` [PATCH 3/3] dpkg-raw: make sure templates are processed before do_install Cedric Hombourger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeeabc60-0002-5392-2e3a-508c44b3d15f@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox