From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6802611076497145856 X-Received: by 2002:adf:b6a8:: with SMTP id j40mr23302265wre.255.1586844179070; Mon, 13 Apr 2020 23:02:59 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:f6c4:: with SMTP id y4ls1876077wrp.2.gmail; Mon, 13 Apr 2020 23:02:58 -0700 (PDT) X-Google-Smtp-Source: APiQypJqpIYTubHxeXrRguwKTW40CYAhjRe3rXj7bMhJ02ML6Sue+adOEuZZorI4ROCMcp7wu5XY X-Received: by 2002:a5d:61c2:: with SMTP id q2mr23798127wrv.152.1586844178367; Mon, 13 Apr 2020 23:02:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586844178; cv=none; d=google.com; s=arc-20160816; b=p1zw5cvoXEqVzs33Mh/mCJyCLwNNwYQOPSkGw0MG+SFGARaS6em107WuW37IbijaHZ egIzRrhwmnddfjXYVj0OYjE6ltqfmtWWuMRC9XeP3H/b80a44A1XNEPfox0omSvFIpa9 jhneTRLi5peGS7+ELncacIn82NnA6yiFuwo4wJKg8d5BOQtkEoomfqCYNHe9oGSi66nU sRBeQniEa4ISEJlLIgEBpyMz4ez5dkXS2nhQS495EGtPslW3w2YwTZ2aTX1j4nC6q6Ji GHEo0CX+jl2rHNAxUGqyQNzirkSN3q8a+G/2P+rkQUVPLzuxv3BgFgKyu81aKo1jlmpv nteg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=9G6Gw1CkMofqA6rKFzHoK/JDv/nd1UfJDpC9QAlOr3c=; b=1ApkikjqaybUnkVlLZv28sed1yrOaUr3+gkxDmvfziMkEM7GE9CCVOuyG70gOhvMHE 4vtvFcDfRcHt60G1pMGBHJ40ulOw3xzNo5kQBvpw2yiYkbZLrC7++dGPvWmPcpLDBbzq 8wXJw8Ls6os5tVTF7X7TF8yGg/9Gb2tN9jk9dhjSSJFBkzrgHuScvnS/PZmH///mwPHI 9mLwWqupaDEQfQKZ1X5c7zNYJ68tkn0paq+PkxSY4oTmnX/eT++NYyxL46z8rMztndPw 7+9bytTiubG0xBXKPjmd9Z5tcp7TxHwlesD927wi0x33zbDRfpJkXMUotwnl1hcxsZCe YuCA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id z84si635340wmc.2.2020.04.13.23.02.58 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Apr 2020 23:02:58 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id 03E62vNi030000 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 14 Apr 2020 08:02:58 +0200 Received: from [167.87.42.238] ([167.87.42.238]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 03E62ujR004695 for ; Tue, 14 Apr 2020 08:02:57 +0200 Subject: Re: [[PATCH v2] 3/3] dpkg-raw: make sure templates are processed before do_install To: isar-users@googlegroups.com References: <20200316133934.223e4a0b@md1za8fc.ad001.siemens.net> <1584363352-866-1-git-send-email-Cedric_Hombourger@mentor.com> <1584363352-866-4-git-send-email-Cedric_Hombourger@mentor.com> <20200410121132.oaaxohphxq7qlqze@yssyq.m.ilbers.de> From: Jan Kiszka Message-ID: Date: Tue, 14 Apr 2020 08:02:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200410121132.oaaxohphxq7qlqze@yssyq.m.ilbers.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: CYYlwKEZ0dwG On 10.04.20 14:11, Baurzhan Ismagulov wrote: > Hello Cedric, > > On Mon, Mar 16, 2020 at 01:55:52PM +0100, Cedric Hombourger wrote: >> --- a/meta/classes/dpkg-raw.bbclass >> +++ b/meta/classes/dpkg-raw.bbclass >> @@ -24,3 +24,7 @@ do_prepare_build() { >> >> deb_debianize >> } >> + >> +# make sure templates are processed before do_install >> +inherit template >> +addtask do_transform_template after do_unpack before do_install > > How does this relate to "addtask do_transform_template after do_unpack" in > meta/classes/template.bbclass? Is one of them superfluous? If yes, would > modifying template.bbclass be better? do_install is dpkg-raw only, so you can't do that in template.bbclass. But I would rather model this via the addtask of install which is under this class' control already. Also, that inherit is redundant because it's already part of the base class, thus every other class. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux