public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users <isar-users@googlegroups.com>
Cc: Henning Schild <henning.schild@siemens.com>
Subject: [PATCH 1/6] meta: image: Account for Ubuntu differences in do_copy_boot_files
Date: Mon, 14 Dec 2020 08:11:22 +0100	[thread overview]
Message-ID: <af2f24e9869059ef0328f7fc77d8c055900d5062.1607929886.git.jan.kiszka@siemens.com> (raw)
In-Reply-To: <cover.1607929886.git.jan.kiszka@siemens.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

Ubuntu places kernel and initrd links under /boot. Furthermore, it makes
the kernel unreadable for non-root users. Account for the latter by
cat'ing the kernel under sudo, redirecting the output to the deployment
artifact so that it is owned by the building user.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/classes/image.bbclass | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 74fc8500..eddc4449 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -132,15 +132,18 @@ EOF
 
 do_copy_boot_files[dirs] = "${DEPLOY_DIR_IMAGE}"
 do_copy_boot_files() {
-    kernel="$(realpath -q '${IMAGE_ROOTFS}/vmlinuz')"
+    kernel="$(realpath -q '${IMAGE_ROOTFS}'/vmlinu[xz])"
     if [ ! -f "$kernel" ]; then
-        kernel="$(realpath -q '${IMAGE_ROOTFS}/vmlinux')"
+        kernel="$(realpath -q '${IMAGE_ROOTFS}'/boot/vmlinu[xz])"
     fi
     if [ -f "$kernel" ]; then
-        cp -f "$kernel" '${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGE}'
+        sudo cat "$kernel" > "${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGE}"
     fi
 
     initrd="$(realpath -q '${IMAGE_ROOTFS}/initrd.img')"
+    if [ ! -f "$initrd" ]; then
+        initrd="$(realpath -q '${IMAGE_ROOTFS}/boot/initrd.img')"
+    fi
     if [ -f "$initrd" ]; then
         cp -f "$initrd" '${DEPLOY_DIR_IMAGE}/${INITRD_IMAGE}'
     fi
-- 
2.26.2


  reply	other threads:[~2020-12-14  7:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-14  7:11 [PATCH 0/6] Add support for Ubuntu Jan Kiszka
2020-12-14  7:11 ` Jan Kiszka [this message]
2020-12-14 12:16   ` [PATCH 1/6] meta: image: Account for Ubuntu differences in do_copy_boot_files Henning Schild
2020-12-14 12:27     ` Jan Kiszka
2020-12-14 12:36       ` Henning Schild
2020-12-14 16:39         ` Jan Kiszka
2020-12-14 16:40           ` Henning Schild
2020-12-15  9:22             ` Jan Kiszka
2020-12-14  7:11 ` [PATCH 2/6] meta/isar-bootstrap: allow passing a SCRIPT to debootstrap Jan Kiszka
2020-12-14  7:11 ` [PATCH 3/6] wic: bootimg-efi-isar: Add support for Ubuntu Jan Kiszka
2020-12-14 12:13   ` Henning Schild
2020-12-14 12:28     ` Jan Kiszka
2020-12-14 12:33       ` Henning Schild
2020-12-14  7:11 ` [PATCH 4/6] meta: cache_deb_src: Account for the case that resolv.conf is a non-existent link Jan Kiszka
2020-12-14  7:11 ` [PATCH 5/6] meta-isar: Add new distro ubuntu with suite "focal" Jan Kiszka
2020-12-14  7:11 ` [PATCH 6/6] meta-isar: linux-mainline: Adjust cfg fragment test to arm64 defconfig Jan Kiszka
2020-12-14 12:06 ` [PATCH 0/6] Add support for Ubuntu Henning Schild
2020-12-14 12:26   ` Jan Kiszka
2021-01-18 16:15 ` Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af2f24e9869059ef0328f7fc77d8c055900d5062.1607929886.git.jan.kiszka@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox