From: "Maxim Yu. Osipov" <mosipov@ilbers.de>
To: chombourger@gmail.com, isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] dpkg-base: apt-get "update" before "source"
Date: Mon, 18 Feb 2019 15:16:52 +0100 [thread overview]
Message-ID: <af4bfa05-ea92-c037-5993-d801a745225e@ilbers.de> (raw)
In-Reply-To: <b9ca5913-f1be-441d-9e2c-3304bc6c5868@googlegroups.com>
Hi Cedric,
Any updates on this topic?
Thanks,
Maxim.
On 2/11/19 2:33 PM, chombourger@gmail.com wrote:
> Hi Jan,
>
> Will need to recheck things here but there should be no .list files
> referencing public repos when building from the local apt cache (and
> therefore when you are wanting a reproducible build)
> My local patch essentially does a full apt-get update but I now need to
> check if I did not alter the expected behavior :)
>
> Cedric
>
> On Monday, February 11, 2019 at 1:53:09 PM UTC+1, Jan Kiszka wrote:
>
> On 11.02.19 10:35, [ext] Henning Schild wrote:
> > Here i see an often repeating pattern. That "apt-get update" is now
> > present in many entry points to the buildchroot.
> > I guess we should factor it out and put it into a central place. And
> > the rule of thumb probably is ... whenever you use anything apt,
> > apt-get update before you do ...
>
> If you are only talking about updating our locally maintained repo
> (like below),
> that is fine to factor out and reuse. However, we must not update
> against public
> repos after the initial pulling, in order to ensure we have a
> consistent package
> set along the whole build.
>
> Jan
>
> >
> > Henning
> >
> > Am Mon, 11 Feb 2019 10:33:24 +0100
> > schrieb Henning Schild <henning...@siemens.com <javascript:>>:
> >
> >> From: Henning Schild <henning...@siemens.com <javascript:>>
> >>
> >> When rebuilding we can run into an inconsistent view where
> buildchroot
> >> assumes it could download the sources of a modified upstream
> package.
> >> After a "reprepro ... remove" we always need to "apt-get update" to
> >> not operate on an old version of the metadata.
> >>
> >> Signed-off-by: Henning Schild <henning...@siemens.com
> <javascript:>>
> >> ---
> >> meta/classes/dpkg-base.bbclass | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/meta/classes/dpkg-base.bbclass
> >> b/meta/classes/dpkg-base.bbclass index 175dc80..5425df8 100644
> >> --- a/meta/classes/dpkg-base.bbclass
> >> +++ b/meta/classes/dpkg-base.bbclass
> >> @@ -31,6 +31,10 @@ do_apt_fetch() {
> >> fi
> >> dpkg_do_mounts
> >> E="${@ bb.utils.export_proxies(d)}"
> >> + sudo -E chroot ${BUILDCHROOT_DIR} /usr/bin/apt-get
> update \
> >> + -o
> >> Dir::Etc::sourcelist="sources.list.d/isar-apt.list" \
> >> + -o Dir::Etc::sourceparts="-" \
> >> + -o APT::Get::List-Cleanup="0"
> >> sudo -E chroot --userspec=$( id -u ):$( id -g )
> >> ${BUILDCHROOT_DIR} \ sh -c 'cd ${PP} && apt-get -y source
> ${SRC_APT}'
> >> dpkg_undo_mounts
> >
>
> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
>
> --
> You received this message because you are subscribed to the Google
> Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to isar-users+unsubscribe@googlegroups.com
> <mailto:isar-users+unsubscribe@googlegroups.com>.
> To post to this group, send email to isar-users@googlegroups.com
> <mailto:isar-users@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/isar-users/b9ca5913-f1be-441d-9e2c-3304bc6c5868%40googlegroups.com
> <https://groups.google.com/d/msgid/isar-users/b9ca5913-f1be-441d-9e2c-3304bc6c5868%40googlegroups.com?utm_medium=email&utm_source=footer>.
> For more options, visit https://groups.google.com/d/optout.
--
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov
next prev parent reply other threads:[~2019-02-18 14:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 9:33 Henning Schild
2019-02-11 9:35 ` Henning Schild
2019-02-11 10:50 ` chombourger
2019-02-11 12:53 ` Jan Kiszka
2019-02-11 13:33 ` chombourger
2019-02-18 14:16 ` Maxim Yu. Osipov [this message]
2019-02-11 18:08 ` Henning Schild
2019-02-26 15:00 ` Henning Schild
2019-02-26 15:03 ` Jan Kiszka
2019-03-05 10:11 ` Henning Schild
2019-02-18 22:01 ` Maxim Yu. Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af4bfa05-ea92-c037-5993-d801a745225e@ilbers.de \
--to=mosipov@ilbers.de \
--cc=chombourger@gmail.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox