From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7026294254479605760 X-Received: by 2002:a63:b63:: with SMTP id a35mr31925442pgl.141.1637562057349; Sun, 21 Nov 2021 22:20:57 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:903:32cf:: with SMTP id i15ls3988812plr.2.gmail; Sun, 21 Nov 2021 22:20:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJxLUXDR6o3l5p8aQOv/0tSEx72XkgendIveVTnieYQ430RYMrncEN2gEoW1xrtN+orErywa X-Received: by 2002:a17:90a:a083:: with SMTP id r3mr27691678pjp.55.1637562056666; Sun, 21 Nov 2021 22:20:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637562056; cv=none; d=google.com; s=arc-20160816; b=pZMFrbPlhBy/ZVy+Gsb+kcKmd1fwo0vAk0NF7RDrMFo4y59d69L2mtTorszl2pQ0BP TJ0gFv7oJgs6Q9fZhK5TX8s4J8syaGXETXFgEub0OPiJXYrX0HjecZBuFmktjLnrw7Vt J135ukQo/CNfeoIwx2h6z8/QDktvOJNz4ipnak6VeiP3wXB6n6kYNhAvu20JSnPzIjgD eWMs0alYHn0n33L3FKYRqUaepJSkmAwqL+V0aXVTDupUkDU1Hjj3s5abd1ABXzw21p1c 30cuUd2nbRcB6Ob2vZcPOchTPvw4GRWdEZhGJ4Lce7OWu6ZUAW1La5zZhGjaUdCSS80J 2gKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=Hxob+52O4zBOpoBC2v/YqX54EdQ8dNq1hqpJ+aQe12A=; b=xVgr1RQt6uAVFvCPnxZuw9JiFPixudqTyg5ZyxkJaadaCROOqR4YpndL+PrKaMfEnD 8xOLztbvF7Pknxgb5hI94v2+rV+R0Bhcj5K9wJ2IzTibHDRDNmrChzNW+8wcVtxVYoen WS8RgH/ppHI6+KD7+uOmxJbRJO2oXr5gYV2BW2CVJ0H2sQXcusXBX7Qfg6JMC6wFilz2 fPkHQhCD+xaLUlo48tJKWvipCvah4YthRPgMtamYXPFTZ0H6TN3+tDBtU57fUDrUFzW+ JAdwMgU4F38++uUnLnjZBgKSUIic1xNQTiLTLwDCk8k+C8hmoGSBEImRi7fyPOgdNAzj MB6w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id j18si474716pgb.5.2021.11.21.22.20.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Nov 2021 22:20:56 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 1AM6Kqit029490 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Nov 2021 07:20:52 +0100 Received: from [167.87.32.217] ([167.87.32.217]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 1AM6Kp8c014349; Mon, 22 Nov 2021 07:20:52 +0100 Subject: Re: [PATCH v3 2/2] u-boot: Move libssl-dev dependency to u-boot-custom To: vijai kumar Cc: Vijai Kumar K , isar-users References: <20211105061521.2142204-2-Vijaikumar_Kanagarajan@mentor.com> <20211106121203.3210294-1-Vijaikumar_Kanagarajan@mentor.com> <20211106121203.3210294-2-Vijaikumar_Kanagarajan@mentor.com> <07718b5f-1186-d912-419e-9dac134f9367@siemens.com> From: Jan Kiszka Message-ID: Date: Mon, 22 Nov 2021 07:20:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: Y7KYGadbKPce On 19.11.21 17:54, vijai kumar wrote: > On Tue, Nov 9, 2021 at 11:31 AM Jan Kiszka wrote: >> >> On 06.11.21 13:12, Vijai Kumar K wrote: >>> Move the libssl-dependency to u-boot-custom.inc. >>> >>> Signed-off-by: Vijai Kumar K >>> --- >>> meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc | 3 --- >>> meta/recipes-bsp/u-boot/u-boot-custom.inc | 4 +++- >>> 2 files changed, 3 insertions(+), 4 deletions(-) >>> >>> diff --git a/meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc b/meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc >>> index 158c297..f3f822a 100644 >>> --- a/meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc >>> +++ b/meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc >>> @@ -5,9 +5,6 @@ >>> >>> require recipes-bsp/u-boot/u-boot-custom.inc >>> >>> -DEBIAN_BUILD_DEPENDS += ", libssl-dev:native" >>> -DEBIAN_BUILD_DEPENDS += "${@', libssl-dev' if d.getVar('ISAR_CROSS_COMPILE') == '1' else ''}" >>> - >>> SRC_URI += " \ >>> https://ftp.denx.de/pub/u-boot/u-boot-${PV}.tar.bz2 \ >>> " >>> diff --git a/meta/recipes-bsp/u-boot/u-boot-custom.inc b/meta/recipes-bsp/u-boot/u-boot-custom.inc >>> index 9984d8c..57d4f36 100644 >>> --- a/meta/recipes-bsp/u-boot/u-boot-custom.inc >>> +++ b/meta/recipes-bsp/u-boot/u-boot-custom.inc >>> @@ -24,7 +24,9 @@ python() { >>> d.setVar('DEBIAN_BUILD_DEPENDS', d.getVar('BUILD_DEPENDS')) >>> } >>> >>> -DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git" >>> +DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git, libssl-dev:native" >>> +DEBIAN_BUILD_DEPENDS += "${@', libssl-dev' if d.getVar('ISAR_CROSS_COMPILE') == '1' else ''}" >>> + >> >> It would feel more logical to me to put the :native part under the >> cross-compile condition. The outcome will be the same, but :native is a >> redundant statement in the native build case. > > Hi Jan, > > Sorry I thought I had replied to this. But it looks like not. > > From my testing, > 1. libssl-dev:native is needed to build the u-boot image(bin). > 2. libssl-dev of host(Debian) is needed only when we cross compile u-boot-tools. > > Even though the :native looks redundant, from the perspective of > u-boot, it makes sense. > Also, we now make it depend on cross-compile because tools are always built. > > If you see my patches on u-boot refactor[1], the libssl-dev inclusion > will only take place in case we cross > compile tools. (ISAR_CROSS_COMPILE == 1 && U_BOOT_TOOLS_PACKAGE = 1) > > [1]: https://groups.google.com/g/isar-users/c/RvvuZ5BRI0U/m/-m8u_mZMAQAJ > Well, thinking about this again, the best way would be to only make this dependent on whether we are building tools or not. The cross-compile dependency is just unneeded, will not save any installation in practice because non-cross means libssl-dev:native == libssl-dev. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux