From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7231085468566159360 X-Received: by 2002:a05:6870:40cf:b0:1b7:2dfe:c221 with SMTP id l15-20020a05687040cf00b001b72dfec221mr5116857oal.33.1689057749559; Mon, 10 Jul 2023 23:42:29 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6870:d626:b0:1b3:e129:dc1 with SMTP id a38-20020a056870d62600b001b3e1290dc1ls519163oaq.0.-pod-prod-09-us; Mon, 10 Jul 2023 23:42:29 -0700 (PDT) X-Google-Smtp-Source: APBJJlHZBy/z+BDepd8nRrP9TfRr3iH0FzEBoW2CDeglHbdqGLoOZKGt7kr1DDFhuXe36xcnOUq8 X-Received: by 2002:a05:6870:b6a2:b0:1b0:45df:cf86 with SMTP id cy34-20020a056870b6a200b001b045dfcf86mr17699613oab.55.1689057748997; Mon, 10 Jul 2023 23:42:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689057748; cv=none; d=google.com; s=arc-20160816; b=tNUDeGbcGJbeY0vj5v5JyJfN5qO8snG/lz/rYRobMdYoTRyr635k8zEw2/E9K+waDl T00+yevAnR+6ZiSRzhusbeMqOgcT8kmINT1u6WQaB/SD7Vx8Yhq54QEaNBrVt5Ht2/Hb 823k6pqdPHRQ2IAgR6GxppaF0rvpl3wk+kH2sknx9FYOWiaOYOvildi9fsMIZ+Vj3VbN 3DneS3nzhRze0oYPPpb+X4KWtVIXqYHnWf1zluZo9tmfqpMzJN8MjH6Fp2K69GPQrQxz /vftQiQJY+U5bF1XynClM0H/6KBANR5QihjN5lWRHSGcdvW3Q0xRBQRJ8NzPxQOghaJT enZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id; bh=OxWRieu1T9BGVppHURWu4ssO57vm09T+zClI0/6vL1s=; fh=swRs1+OhWjovx1IrvOlKBWsdq9manB5qdcuGoHoh5Ak=; b=aSba+7n9MQJPZP1kRs0VzLqSGzjgH+K9HpAG4Dg8/4LpDxxB2q+vsfcHNl9z3ZAF7Z YSC9jNv+T+kM3Re4pz6dDxAwFVsEk7WAQRUkbRsBhaqHVeXg3fqXT49CtJF07bNmM6g0 oNWeKkGvvCo8EdXLNCVFoSBqP0Fc1FfOkYfckaRKcNoDXIdd6lf0mZT8ha7l8K6TnyuU O8J+g3IWy4SpYYMIJsCHBPGjZTCHqpdgnXIaKMDMhex+/CQpk/hnFDbcm+e17DqxOOZr byb2SF4fcrLMGw6x3gDFRjyS8tr3Gb+cn4w+pBk4PUKeFXb3x0WxD23qTN/Wr60IZL6K UIZg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id lu26-20020a056871431a00b001b39eee00b5si125655oab.3.2023.07.10.23.42.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Jul 2023 23:42:28 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 36B6gRqg028522 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 11 Jul 2023 08:42:28 +0200 Message-ID: Subject: Re: [PATCH v3 0/4] Rewrite the image-account-extension in python From: Uladzimir Bely To: isar-users@googlegroups.com Date: Tue, 11 Jul 2023 09:42:31 +0300 In-Reply-To: <20230522065531.2300448-1-tobias.schaffner@siemens.com> References: <20230522065531.2300448-1-tobias.schaffner@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: PrD3jFjbx8k5 On Mon, 2023-05-22 at 08:55 +0200, T. Schaffner wrote: > From: Tobias Schaffner >=20 > This allows us to drop a lot of encoding and parsing code that was > used > to transition to shell and therefore makes it easier to read and > maintain. >=20 > Using python functions for more complex tasks allows us the usage of > unittests. A very basic infrastructure for unittesting using the > build > in python unittest and the bb.parse module was added. This was used > to > test the re-implementation of the image-account-extension as a first > showcase. >=20 > This is a rebased version of the refactoring part of the "allow > creation > of users/groups before rootfs creation" patch series to decouple the > merge of the simplifications. >=20 > Changes since v1: > - Fix wrong year in copyright of image-account-extension >=20 > Changes since v2: > - Only set system flag if a new group is created and create a > unittest > =C2=A0 that proofs that it is not added for existing groups. >=20 > Tobias Schaffner (4): > =C2=A0 simplify image-account-extension > =C2=A0 create a minimal python unittest infrastructure > =C2=A0 add unittests for the image-account-extension > =C2=A0 set minimal python version in user_manual to 3.5 >=20 > =C2=A0doc/user_manual.md=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 2 +- > =C2=A0meta/classes/image-account-extension.bbclass=C2=A0 | 368 ++++++----= ------ > -- > =C2=A0testsuite/unittests/README.md=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 28 ++ > =C2=A0testsuite/unittests/bitbake.py=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 37 ++ > =C2=A0testsuite/unittests/rootfs.py=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 45 +++ > =C2=A0.../unittests/test_image_account_extension.py | 157 ++++++++ > =C2=A06 files changed, 392 insertions(+), 245 deletions(-) > =C2=A0create mode 100644 testsuite/unittests/README.md > =C2=A0create mode 100644 testsuite/unittests/bitbake.py > =C2=A0create mode 100644 testsuite/unittests/rootfs.py > =C2=A0create mode 100644 > testsuite/unittests/test_image_account_extension.py >=20 Applied to next, thanks.