Re: [PATCH v5 3/5] classes: allow more control over container image name and tag

[Anton Mikanovich <amikan@ilbers.de>]

05.08.2021 19:09, Henning Schild wrote:
> diff --git a/doc/user_manual.md b/doc/user_manual.md
> index cf7dc2fee35e..e5c07bd41fc5 100644
> --- a/doc/user_manual.md
> +++ b/doc/user_manual.md
> @@ -1070,14 +1070,14 @@ bitbake -c do_populate_sdk mc:qemuarm-buster:isar-image-base
>    - Load the SDK container image into the Docker Daemon
>   
>   ```
> -docker load -i build/tmp/deploy/images/qemuarm/sdk-debian-buster-armhf-docker-archive.tar.xz
> +docker load -i build/tmp/deploy/images/qemuarm/isar-image-base-debian-buster-armhf-1.0-r0-docker-archive.tar.xz
>   ```
>   
>    - Run a container using the SDK container image (following commands starting
>      with `#~:` are to be run in the container)
>   
>   ```
> -docker run --rm -ti --volume "$(pwd):/build" isar-sdk-buster-armhf:latest
> +docker run --rm -ti --volume "$(pwd):/build" isar-image-base-debian-buster-armhf:1.0-r0
>   ```
>   
>    - Check that cross toolchains are installed
> diff --git a/meta/classes/image-sdk-extension.bbclass b/meta/classes/image-sdk-extension.bbclass
> index 426b92595554..fa15b588068c 100644
> --- a/meta/classes/image-sdk-extension.bbclass
> +++ b/meta/classes/image-sdk-extension.bbclass
> @@ -80,7 +80,7 @@ do_populate_sdk() {
>       # generate the SDK in all the desired container formats
>       if [ -n "${sdk_container_formats}" ] ; then
>           bbnote "Generating SDK container in ${sdk_container_formats} format"
> -        containerize_rootfs "${SDKCHROOT_DIR}" "sdk-${DISTRO}-${DISTRO_ARCH}" "${sdk_container_formats}"
> +        containerize_rootfs "${SDKCHROOT_DIR}" "${sdk_container_formats}"
>       fi
>   }
>   

This might be wrong. Containerized rootfs image and containerized sdk 
image are using the same name, so output files will be overwritten.
Meantime normal non-containerized SDK image is still using sdk-*.tar.xz 
output file mask.

-- 
Anton Mikanovich
Promwad Ltd.
External service provider of ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn, Germany
+49 (89) 122 67 24-0
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov