public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Anton Mikanovich <amikan@ilbers.de>, isar-users@googlegroups.com
Subject: Re: [PATCH] buildchroot: Add buildchroot dependency for imager
Date: Thu, 8 Jul 2021 13:37:32 +0200	[thread overview]
Message-ID: <affadbb7-28e9-b4aa-d62f-d5434bec90cc@siemens.com> (raw)
In-Reply-To: <20210707164122.204484-1-amikan@ilbers.de>

On 07.07.21 18:41, Anton Mikanovich wrote:
> Task do_install_imager_deps is using BUILDCHROOT but not depends on it.
> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  meta/classes/buildchroot.bbclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/buildchroot.bbclass b/meta/classes/buildchroot.bbclass
> index 806a29f..1f90768 100644
> --- a/meta/classes/buildchroot.bbclass
> +++ b/meta/classes/buildchroot.bbclass
> @@ -18,6 +18,7 @@ python __anonymous() {
>          rootfs = d.getVar('BUILDCHROOT_HOST_DIR', True)
>  
>      d.setVarFlag('do_apt_fetch', 'depends', dep)
> +    d.setVarFlag('do_install_imager_deps', 'depends', dep)
>      d.setVar('BUILDCHROOT_DIR', rootfs)
>  }
>  
> 

But there is

do_install_imager_deps[depends] = "buildchroot-target:do_build"

in meta/classes/image-tools-extension.bbclass. Why is the above
additionally needed?

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

  reply	other threads:[~2021-07-08 11:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07 16:41 Anton Mikanovich
2021-07-08 11:37 ` Jan Kiszka [this message]
2021-07-08 11:44   ` Anton Mikanovich
2021-07-08 12:11     ` Jan Kiszka
2021-07-08 12:25       ` Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=affadbb7-28e9-b4aa-d62f-d5434bec90cc@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox