Re: [PATCH 01/10] meta: builchroot: Preserve environment when calling dpkg-buildpackage

[Jan Kiszka <jan.kiszka@siemens.com>]

On 05.11.18 10:41, Henning Schild wrote:
> Am Mon, 5 Nov 2018 07:52:01 +0100
> schrieb "Jan Kiszka" <jan.kiszka@siemens.com>:
> 
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> This is required in order to allow recipes to pass variables down to
>> the rules file. E.g., u-boot-custom.inc makes use of this.
> 
> Good catch! Will u-boot recipes fail to build or will the binaries just
> be broken?

It fails to build because we pass the name of the defconfig and of the generated 
u-boot binary down to the rules file this way.

Jan

> 
> Henning
> 
>> Fixes: be291cd991bd ("buildchroot: build debian packages as "builder"
>> not "root"") Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>   meta/recipes-devtools/buildchroot/files/build.sh | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/buildchroot/files/build.sh
>> b/meta/recipes-devtools/buildchroot/files/build.sh index
>> d98eb2e..5855f29 100644 ---
>> a/meta/recipes-devtools/buildchroot/files/build.sh +++
>> b/meta/recipes-devtools/buildchroot/files/build.sh @@ -17,4 +17,4 @@
>> done # Build the package as user "builder"
>>   chown -R builder:builder $1 # the sources
>>   chown builder:builder $1/.. # the output
>> -su - builder -c "cd $1; dpkg-buildpackage -a$target_arch -d
>> --source-option=-I" +su - builder -p -c "cd $1; dpkg-buildpackage
>> -a$target_arch -d --source-option=-I"
> 
-
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux