From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6620265736346533888 X-Received: by 2002:a19:519a:: with SMTP id g26-v6mr1571565lfl.2.1541411201371; Mon, 05 Nov 2018 01:46:41 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:67:: with SMTP id 100-v6ls2735907lja.15.gmail; Mon, 05 Nov 2018 01:46:40 -0800 (PST) X-Google-Smtp-Source: AJdET5f8Fziq2WDK4lMhDDr0GSyz+6fWuUUkShZJ+sxrtE1hsgcOQ9s7HehH3GdoD63GRfPNoju2 X-Received: by 2002:a2e:954b:: with SMTP id t11-v6mr1223431ljh.28.1541411200849; Mon, 05 Nov 2018 01:46:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541411200; cv=none; d=google.com; s=arc-20160816; b=t4HIviWWvKL+e0lqPlDiWs+eIDluRjE2t01sczAtliCowIIwS9cQQtmUtxyBh+zuwT uF99angwL3Jk2eBrGuBBGbqp+Tzv2gNsQEkAMGrceK6Cn+KaaZRaVBFClkxPj+JCwOxP 9hR6dC8XRM4tv18ii5cI7jG/ZkKkp2TgR/wUP6TF31tL9yTJ3/aNyjMx5PQKH5JEZodF 7oa9oc1dP6t/i0PNbRbXnmomTS7PQQHL0WRXlhCQyAFmyHk6qLVZ0LDDdRpf/IDZQu/Q 7WneFNuzozxRuX6wmQIFF41XJo/PO4rQTQhkiebdisewFVHiVIKFdy8uXbvlMJEZKSjo wYvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=M8s6JGv0Pa3S1UwOkO07pZd3AHsJRmzsAAdf91nU/RQ=; b=c6wjOsUELtKZHIOGuLOYgHyzYk+bxFhwNbJENhBY8eNOl62BXBZX6ptMTAkG3Q8oyb BHbC+R+wD2lQQDjDUixNdKwEsASu8dHfZJ6RxT1EyWxSYoR0bYJrJYGT887Qq3Ov4TJI QAJG2Dp/odcmnmOON9q4xUwbZwqLoo78R273YaB7jY7vdVGSH42mnspWtLNfjEr2Lbe7 BPEufEEYlowb6t3rk3ZDz6vZoAkh3cdZquinYp04yta9uxGb4qF4LcieqSTeh54eVHen ysXfP9AGSFi6LPJ/n47wnWFf6jLoKdxf0zdiZEv1OzDA87FeLc4loUQ2A9Hf4pPbYpSB 3mwg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id a79-v6si1264559ljf.1.2018.11.05.01.46.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Nov 2018 01:46:40 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id wA59ka8v011861 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 5 Nov 2018 10:46:36 +0100 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id wA59kaRX025385; Mon, 5 Nov 2018 10:46:36 +0100 Subject: Re: [PATCH 01/10] meta: builchroot: Preserve environment when calling dpkg-buildpackage To: Henning Schild Cc: isar-users References: <18dfabd13a9701da5182e41bb12840c315fcc0b8.1541400730.git.jan.kiszka@siemens.com> <20181105104115.5f1bfe1f@md1za8fc.ad001.siemens.net> From: Jan Kiszka Message-ID: Date: Mon, 5 Nov 2018 10:46:35 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20181105104115.5f1bfe1f@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: WmK8i5VjJxCe On 05.11.18 10:41, Henning Schild wrote: > Am Mon, 5 Nov 2018 07:52:01 +0100 > schrieb "Jan Kiszka" : > >> From: Jan Kiszka >> >> This is required in order to allow recipes to pass variables down to >> the rules file. E.g., u-boot-custom.inc makes use of this. > > Good catch! Will u-boot recipes fail to build or will the binaries just > be broken? It fails to build because we pass the name of the defconfig and of the generated u-boot binary down to the rules file this way. Jan > > Henning > >> Fixes: be291cd991bd ("buildchroot: build debian packages as "builder" >> not "root"") Signed-off-by: Jan Kiszka >> --- >> meta/recipes-devtools/buildchroot/files/build.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/recipes-devtools/buildchroot/files/build.sh >> b/meta/recipes-devtools/buildchroot/files/build.sh index >> d98eb2e..5855f29 100644 --- >> a/meta/recipes-devtools/buildchroot/files/build.sh +++ >> b/meta/recipes-devtools/buildchroot/files/build.sh @@ -17,4 +17,4 @@ >> done # Build the package as user "builder" >> chown -R builder:builder $1 # the sources >> chown builder:builder $1/.. # the output >> -su - builder -c "cd $1; dpkg-buildpackage -a$target_arch -d >> --source-option=-I" +su - builder -p -c "cd $1; dpkg-buildpackage >> -a$target_arch -d --source-option=-I" > - Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux