From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7062963440528130048 X-Received: by 2002:a05:6512:3341:b0:433:b033:bd22 with SMTP id y1-20020a056512334100b00433b033bd22mr24549676lfd.190.1646416463200; Fri, 04 Mar 2022 09:54:23 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3b8e:b0:443:9610:6a0c with SMTP id g14-20020a0565123b8e00b0044396106a0cls413725lfv.1.gmail; Fri, 04 Mar 2022 09:54:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJzMnu1db8JS2IikezuLj3WmEJjQqtzaV8hzcQ98nsKOOrqdPngieBKRRZAtyTeZ5fgBvKaQ X-Received: by 2002:a05:6512:39c4:b0:445:c939:6230 with SMTP id k4-20020a05651239c400b00445c9396230mr5396047lfu.517.1646416462154; Fri, 04 Mar 2022 09:54:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646416462; cv=none; d=google.com; s=arc-20160816; b=R1F3gX21Kkcpsb4lDp9CY4b4kgv5DlPJg1VQoZl2V49xaK5TjxEpQ85s12mo8FJQX1 alBeaH1tZhHH8fbT1fSrlytf/WIoMtS3uLCXNT+xiJCQuMcxqeY//c8ulA+sR+nZsKwd SUVhcvsnwm924nWnQv2WZAuxVSQvBj/khmeM9hxjBzz5R1TlBFpowl2GTCRKI2JcTVSM NKcIxW8sGKTCmwKcPKUBeXZ65PGb6TB1OS94fl914XXtkML15YAZwd8rJMBf0ohr3tYD fkSzOl/ni9iiBm08NTbrxOr2EnCgJ2YD7e0/vaOmi7vlEXWZHIqaTei2ssHpGUKC3MQA uG4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id; bh=Xn4QomQN6tm0/Dvi8SEKGWx20mFrAsPs+pYGcsBoCjs=; b=Fu0p5aRLvcwK1TB4vRd6gf5tYPOZr3WPShWh05AGgX7JzgyGmU0NUcSpGXEDMmVKCZ 6Ny0F819DFvdpkRmlbHfsSJLnhDgZDh7KIkSVHa9uLvDxYwlUCNEPjfMOBTt4hQI1XU8 4dC6eDc2CTGyChlI9rl4PvIDHGepyEojjrbbnpnCFvSkkbCDhQ4bqIOWQp+dK/2PGdoe RKIlYFIp/EU/+NfvJ7la51heNeVAd2v3Sh1HfwTVAYcrbit+cdXWLvRkEzflVNzBSz4C UrACEcDlLEaXv5uJ1FHc88e2hswqlrl93SHB96KxrHyvLXRGHbzXgemQM9+7Iyi8/Z3l kdvg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id w24-20020a2e9598000000b002463b72fb7esi369715ljh.5.2022.03.04.09.54.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Mar 2022 09:54:22 -0800 (PST) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 224HsG79001843 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 4 Mar 2022 18:54:19 +0100 Message-ID: Date: Fri, 4 Mar 2022 20:54:15 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 0/6] imagetypes Content-Language: en-US To: Henning Schild Cc: Adriaan Schmidt , isar-users@googlegroups.com References: <20220210062446.4145565-1-adriaan.schmidt@siemens.com> <4bb37893-596f-8a2c-3f7c-9d48ee493602@ilbers.de> <20220303195504.2494664c@md1za8fc.ad001.siemens.net> From: Anton Mikanovich In-Reply-To: <20220303195504.2494664c@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: lHZWnuH+Ya8z 03.03.2022 21:55, Henning Schild wrote: > Am Thu, 3 Mar 2022 21:35:12 +0300 > schrieb Anton Mikanovich : > >> 10.02.2022 09:24, Adriaan Schmidt wrote: >>> This series introduces image types and conversions as known from OE. >>> The main motivation is to provide a more flexible way of generating >>> and processing images, without the need to insert custom tasks >>> (e.g., currently we have custom classes adding tasks for things >>> like bz2 or xz compression of images in several downstream layers). >>> >>> These patches have been tested on some of our layers, and also >>> work with some more "challenging" use cases like image-in-image >>> recipes and custom image types brought by layers. >>> >>> It's not perfect (e.g., documentation is still missing). Also I >>> added just the bare minimum of conversions, so there should >>> probably be follow-ups for additional compressions, or things >>> like checksums, which can also be nicely done with this. >>> >>> - p1 prepares by removing image-type-suffix from image build >>> directories, which enables sharing of the completed rootfs across >>> image types >>> - p2 refactors the SDK, and makes it an image feature instead of >>> a separate recipe (has been discussed here a while ago) >>> - p3 does the actual work, but keeps all original files >>> - p4 moves code to different files >>> - p5 adapts meta-isar >>> - p6 removes IMAGE_FSTYPES as a dimension in multiconfig. Now that >>> we can build multiple types from one rootfs, multconfig is >>> just the wrong way of doing this (also been discussed here). >>> >>> Adriaan Schmidt (6): >>> image: remove IMAGE_SUFFIX >>> image: refactor SDK >>> meta: introduce IMAGE_CMD_* >>> imagetypes: restructure files >>> imagetypes: switch meta-isar to the new scheme >>> meta-isar: remove IMAGE_FSTYPES from multiconfig definitions >>> >>> meta-isar/classes/rpi-sdimg.bbclass | 10 +- >>> meta-isar/classes/ubi-ubifs-img.bbclass | 11 +- >>> meta-isar/conf/local.conf.sample | 4 - >>> meta-isar/conf/machine/bananapi.conf | 2 +- >>> meta-isar/conf/machine/container-amd64.conf | 2 +- >>> meta-isar/conf/machine/de0-nano-soc.conf | 2 +- >>> meta-isar/conf/machine/hikey.conf | 2 +- >>> meta-isar/conf/machine/imx6-sabrelite.conf | 3 +- >>> meta-isar/conf/machine/nanopi-neo.conf | 2 +- >>> meta-isar/conf/machine/phyboard-mira.conf | 3 +- >>> meta-isar/conf/machine/qemuamd64.conf | 2 +- >>> meta-isar/conf/machine/qemuarm.conf | 2 +- >>> meta-isar/conf/machine/qemuarm64.conf | 2 +- >>> meta-isar/conf/machine/qemui386.conf | 2 +- >>> meta-isar/conf/machine/qemumipsel.conf | 2 +- >>> meta-isar/conf/machine/qemuriscv64.conf | 2 +- >>> meta-isar/conf/machine/rpi-common.conf | 1 + >>> meta-isar/conf/machine/rpi.conf | 1 + >>> meta-isar/conf/machine/sifive-fu540.conf | 2 +- >>> meta-isar/conf/machine/stm32mp15x.conf | 2 +- >>> meta-isar/conf/machine/virtualbox.conf | 2 +- >>> meta-isar/conf/machine/vmware.conf | 2 +- >>> .../qemuamd64-bullseye-cpiogz.conf | 7 - >>> .../multiconfig/qemuamd64-bullseye-tgz.conf | 7 - >>> .../conf/multiconfig/qemuamd64-bullseye.conf | 2 + >>> .../multiconfig/qemuamd64-buster-cpiogz.conf | 9 - >>> .../multiconfig/qemuamd64-buster-tgz.conf | 9 - >>> .../conf/multiconfig/qemuamd64-buster.conf | 2 +- >>> .../recipes-core/images/isar-image-ubi.bb | 4 +- >>> meta/classes/container-img.bbclass | 17 -- >>> meta/classes/cpiogz-img.bbclass | 22 -- >>> meta/classes/ext4-img.bbclass | 24 --- >>> meta/classes/fit-img.bbclass | 29 --- >>> .../classes/image-container-extension.bbclass | 83 ------- >>> meta/classes/image-sdk-extension.bbclass | 87 -------- >>> meta/classes/image.bbclass | 202 >>> ++++++++++++++++-- meta/classes/imagetypes.bbclass | >>> 89 ++++++++ meta/classes/imagetypes_container.bbclass | 95 >>> ++++++++ .../{vm-img.bbclass => imagetypes_vm.bbclass} | 24 +-- >>> ...wic-img.bbclass => imagetypes_wic.bbclass} | 45 ++-- >>> meta/classes/rootfs.bbclass | 1 + >>> meta/classes/sdk.bbclass | 137 ++++++++++++ >>> meta/classes/targz-img.bbclass | 15 -- >>> meta/classes/ubi-img.bbclass | 32 --- >>> meta/classes/ubifs-img.bbclass | 32 --- >>> .../{sdkchroot => sdk-files}/files/README.sdk | 0 >>> .../files/configscript.sh | 0 >>> .../files/gcc-sysroot-wrapper.sh | 0 >>> .../files/relocate-sdk.sh | 0 >>> meta/recipes-devtools/sdk-files/sdk-files.bb | 26 +++ >>> meta/recipes-devtools/sdkchroot/sdkchroot.bb | 78 ------- >>> testsuite/build_test/build_test.py | 2 - >>> 52 files changed, 599 insertions(+), 544 deletions(-) >>> delete mode 100644 >>> meta-isar/conf/multiconfig/qemuamd64-bullseye-cpiogz.conf delete >>> mode 100644 meta-isar/conf/multiconfig/qemuamd64-bullseye-tgz.conf >>> delete mode 100644 >>> meta-isar/conf/multiconfig/qemuamd64-buster-cpiogz.conf delete mode >>> 100644 meta-isar/conf/multiconfig/qemuamd64-buster-tgz.conf delete >>> mode 100644 meta/classes/container-img.bbclass delete mode 100644 >>> meta/classes/cpiogz-img.bbclass delete mode 100644 >>> meta/classes/ext4-img.bbclass delete mode 100644 >>> meta/classes/fit-img.bbclass delete mode 100644 >>> meta/classes/image-container-extension.bbclass delete mode 100644 >>> meta/classes/image-sdk-extension.bbclass create mode 100644 >>> meta/classes/imagetypes.bbclass create mode 100644 >>> meta/classes/imagetypes_container.bbclass rename >>> meta/classes/{vm-img.bbclass => imagetypes_vm.bbclass} (89%) rename >>> meta/classes/{wic-img.bbclass => imagetypes_wic.bbclass} (86%) >>> create mode 100644 meta/classes/sdk.bbclass delete mode 100644 >>> meta/classes/targz-img.bbclass delete mode 100644 >>> meta/classes/ubi-img.bbclass delete mode 100644 >>> meta/classes/ubifs-img.bbclass rename >>> meta/recipes-devtools/{sdkchroot => sdk-files}/files/README.sdk >>> (100%) rename meta/recipes-devtools/{sdkchroot => >>> sdk-files}/files/configscript.sh (100%) rename >>> meta/recipes-devtools/{sdkchroot => >>> sdk-files}/files/gcc-sysroot-wrapper.sh (100%) rename >>> meta/recipes-devtools/{sdkchroot => >>> sdk-files}/files/relocate-sdk.sh (100%) create mode 100644 >>> meta/recipes-devtools/sdk-files/sdk-files.bb delete mode 100644 >>> meta/recipes-devtools/sdkchroot/sdkchroot.bb >> This patchset also fails on mc:rpi-arm-v7-bullseye:isar-image-base >> target if using BASE_REPO_FEATURES = "cache-deb-src". > Would it be ok to remove rpi-sdimg.bbclass and switch over to wic for > rpis? This class is causing headache and seems legacy from very old > days. > > Henning > I agree rpi-sdimg image type should be removed in favor of more generic SD image generation way can be used not only by raspberry targets. P.S. I will be out of office next week, will back 2022-03-14